Re: [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues

Hi Nikolay, Thank you for the patch. On Sun, Feb 21, 2021 at 10:53:08PM +0300, Nikolay Kyx wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues > > in file iss_regs.h > > Signed-off-by: Nikolay Kyx

Re: [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues

Hi Nikolay, On Mon, Feb 22, 2021 at 12:21:36AM +0300, Nikolay K. wrote: > Hi Laurent, > > Thank you for the review. > I think that if we drop the unneeded parentheses here, we need to drop > them everywhere in the file for consistency, even in places checkpatch.pl That's a good point. >

Re: [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues

Hi Laurent, Thank you for the review. I think that if we drop the unneeded parentheses here, we need to drop them everywhere in the file for consistency, even in places checkpatch.pl doesn't warn about. It'll increase patch size without actual usefullness gain, as for me. I am very (very) novice

Re: [PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues

Hi Nikolay, Thank you for the patch. On Sun, Feb 21, 2021 at 10:53:08PM +0300, Nikolay Kyx wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues > > in file iss_regs.h > > Signed-off-by: Nikolay Kyx > ---

[PATCH] staging: media: omap4iss: code style - avoid macro argument precedence issues

This patch fixes the following checkpatch.pl check: CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues in file iss_regs.h Signed-off-by: Nikolay Kyx --- Additionally some style warnings remain valid here and could be fixed by another patch.