Re: [PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-05 Thread Laurent Pinchart
Hi Baoyou, Thank you for the patch. On Sunday 04 Sep 2016 14:41:41 Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype > for 'omap4iss_flush' [-Wmissing-prototypes] > > In fact, this function is only

Re: [PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-05 Thread Arnd Bergmann
On Sunday, September 4, 2016 2:41:41 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for > 'omap4iss_flush' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which

[PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-04 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for 'omap4iss_flush' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so