Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

2015-08-07 Thread Johannes Postma
On 06/08/15 at 08:21am, Jes Sorensen wrote: Looks OK to me. Probably worth changing the *(usPtr + index) to be usPtr[index] as well to make the code easier to read. Jes Thank you for reviewing. I will make a seperate patch for that. I will send it after this one is accepted. Or should

Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

2015-08-07 Thread Jes Sorensen
Johannes Postma jgmpos...@gmail.com writes: On 06/08/15 at 08:21am, Jes Sorensen wrote: Looks OK to me. Probably worth changing the *(usPtr + index) to be usPtr[index] as well to make the code easier to read. Jes Thank you for reviewing. I will make a seperate patch for that. I will

Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

2015-08-07 Thread Johannes Postma
On 07/08/15 at 08:26am, Jes Sorensen wrote: Johannes Postma jgmpos...@gmail.com writes: On 06/08/15 at 08:21am, Jes Sorensen wrote: Looks OK to me. Probably worth changing the *(usPtr + index) to be usPtr[index] as well to make the code easier to read. Jes Thank you for

[PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

2015-08-06 Thread Johannes Postma
usPtr is used as __le16 *, but was defined as u16 *. This was reported by sparse as: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to restricted __le16 This patch fixes the type of usPtr. Signed-off-by: Johannes Postma jgmpos...@gmail.com ---

Re: [PATCH] staging: rtl8723au: Fix sparse warning: cast to restricted __le16

2015-08-06 Thread Jes Sorensen
Johannes Postma jgmpos...@gmail.com writes: usPtr is used as __le16 *, but was defined as u16 *. This was reported by sparse as: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1850:29: warning: cast to restricted __le16 This patch fixes the type of usPtr. Signed-off-by: Johannes Postma

Re: [PATCH] staging: rtl8723au: fix sparse warning

2015-05-26 Thread Jes Sorensen
Juston Li juston.h...@gmail.com writes: change cast to __le16 to fix the following warning: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16 Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |

[PATCH] staging: rtl8723au: fix sparse warning

2015-05-22 Thread Juston Li
change cast to __le16 to fix the following warning: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16 Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] staging: rtl8723au: Fix sparse warning cast to restricted __le16

2015-03-11 Thread Marcus Folkesson
This patch fixes the following sparse warnings: CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning: cast to restricted __le16 drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:39: warning: cast to restricted

Re: [PATCH] staging: rtl8723au: Fix sparse warning cast to restricted __le16

2015-03-11 Thread Jes Sorensen
Marcus Folkesson marcus.folkes...@gmail.com writes: This patch fixes the following sparse warnings: CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning: cast to restricted __le16

Re: [PATCH] staging: rtl8723au: fix sparse warning

2014-11-19 Thread Jes Sorensen
Aleh Suprunovich b...@ahlamon.org writes: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static? Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current staging code. Before, it was available

[PATCH] staging: rtl8723au: fix sparse warning

2014-11-17 Thread Aleh Suprunovich
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static? Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current staging code. Before, it was available as 'static s32 Hal_EfusePgPacketRead', but code

[PATCH] staging: rtl8723au: fix sparse warning

2014-06-24 Thread Clement Calmels
From: Clément Calmels clement.calm...@free.fr Found running sparse on the rtl8723au driver. CHECK drivers/staging/rtl8723au/core/rtw_cmd.c drivers/staging/rtl8723au/core/rtw_cmd.c:1479:54: warning: incorrect type in argument 2 (different base types)

[PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

2014-05-15 Thread Konrad Zapalowicz
This commit fixes the following sparse warning: drivers/staging/rtl8723au/os_dep/os_intfs.c: - 322:14: warning: restricted __be16 degrades to integer Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +- 1 file changed, 1

Re: [PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

2014-05-15 Thread Dan Carpenter
On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote: This commit fixes the following sparse warning: drivers/staging/rtl8723au/os_dep/os_intfs.c: - 322:14: warning: restricted __be16 degrades to integer Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com ---