Re: [PATCH] staging: rtl8723bs: remove get_monotonic_boottime()

2018-06-19 Thread Arnd Bergmann
On Tue, Jun 19, 2018 at 9:18 AM, Quytelda Kahja wrote: > I'm fairly sure this doesn't matter functionally (yet), but perhaps > 'notify_timestamp' should be updated to an 's64' type since ktime_to_us() > returns a signed type? I think it's fine either way, ktime_t is only signed to deal with

Re: [PATCH] staging: rtl8723bs: remove get_monotonic_boottime()

2018-06-19 Thread Quytelda Kahja
I'm fairly sure this doesn't matter functionally (yet), but perhaps 'notify_timestamp' should be updated to an 's64' type since ktime_to_us() returns a signed type? That note aside, I think this is good. On Mon, Jun 18, 2018 at 05:06:50PM +0200, Arnd Bergmann wrote: > get_monotonic_boottime() is

[PATCH] staging: rtl8723bs: remove get_monotonic_boottime()

2018-06-18 Thread Arnd Bergmann
get_monotonic_boottime() is deprecated because it uses the old 'timespec' structure. This replaces one of the last callers with a call to ktime_get_boottime, which also simplifies it a bit by avoiding a double conversion. Signed-off-by: Arnd Bergmann ---