Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type

2016-09-24 Thread Moshe Green
On Fri, Sep 23, 2016 at 02:13:52PM +0200, Greg KH wrote: > On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote: > > Rename CamelCased function getChipType to get_chip_type. > > This issue was found by checkpatch.pl > > As this is a global function, can you rename it to something like >

Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type

2016-09-23 Thread Greg KH
On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote: > Rename CamelCased function getChipType to get_chip_type. > This issue was found by checkpatch.pl As this is a global function, can you rename it to something like "sm750_get_chip_type()"? Having a driver-specific function called

[PATCH] staging: sm750fb: rename getChipType to get_chip_type

2016-09-22 Thread Moshe Green
Rename CamelCased function getChipType to get_chip_type. This issue was found by checkpatch.pl Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 16 drivers/staging/sm750fb/ddk750_chip.h | 2 +- drivers/staging/sm750fb/ddk750_mode.c