Re: [PATCH] staging: wilc1000: Remove unnecessary pointer check

2018-09-21 Thread Dan Carpenter
On Fri, Sep 21, 2018 at 01:25:32AM -0400, valdis.kletni...@vt.edu wrote: > On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said: > > Clang warns that the address of a pointer will always evaluated as true > > in a boolean context: > > > > drivers/staging/wilc1000/linux_wlan.c:267:20:

Re: [PATCH] staging: wilc1000: Remove unnecessary pointer check

2018-09-21 Thread Ajay Singh
Reviewed-by: Ajay Singh On Thu, 20 Sep 2018 22:39:11 -0700 Nathan Chancellor wrote: > On Fri, Sep 21, 2018 at 01:25:32AM -0400, valdis.kletni...@vt.edu > wrote: > > On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said: > > > Clang warns that the address of a pointer will always

Re: [PATCH] staging: wilc1000: Remove unnecessary pointer check

2018-09-20 Thread valdis . kletnieks
On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said: > Clang warns that the address of a pointer will always evaluated as true > in a boolean context: > > drivers/staging/wilc1000/linux_wlan.c:267:20: warning: address of > 'vif->ndev->dev' will always evaluate to 'true' >

Re: [PATCH] staging: wilc1000: Remove unnecessary pointer check

2018-09-20 Thread Nathan Chancellor
On Fri, Sep 21, 2018 at 01:25:32AM -0400, valdis.kletni...@vt.edu wrote: > On Thu, 20 Sep 2018 14:26:49 -0700, Nathan Chancellor said: > > Clang warns that the address of a pointer will always evaluated as true > > in a boolean context: > > > > drivers/staging/wilc1000/linux_wlan.c:267:20:

[PATCH] staging: wilc1000: Remove unnecessary pointer check

2018-09-20 Thread Nathan Chancellor
Clang warns that the address of a pointer will always evaluated as true in a boolean context: drivers/staging/wilc1000/linux_wlan.c:267:20: warning: address of 'vif->ndev->dev' will always evaluate to 'true' [-Wpointer-bool-conversion] if (!(>ndev->dev)) ~ ~~~^~~ 1