Re: [PATCH 01/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-06 Thread Mark Hounschell
On 03/05/2014 04:39 PM, Dan Carpenter wrote: Btw, if you don't get any messages from me that means I have given your patch the stamp of approval. So good job on your previous patchset. :) On Wed, Mar 05, 2014 at 03:54:49PM -0500, Mark Hounschell wrote: @@ -1613,7 +1616,8 @@ static void

Re: [PATCH 01/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-06 Thread Dan Carpenter
On Thu, Mar 06, 2014 at 09:19:08AM -0500, Mark Hounschell wrote: Function arguments line up: memcpy(ch-ch_sniff_buf + ch-ch_sniff_in, p, r); As you say below, Breaking the lines up like this isn't ideal. This one I feel

Re: [PATCH 01/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

2014-03-05 Thread Dan Carpenter
Btw, if you don't get any messages from me that means I have given your patch the stamp of approval. So good job on your previous patchset. :) On Wed, Mar 05, 2014 at 03:54:49PM -0500, Mark Hounschell wrote: @@ -1613,7 +1616,8 @@ static void dgap_tty_uninit(struct board_t *brd) * dgap_sniff