Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Nishka Dasgupta
On 13/06/19 2:05 PM, Dan Carpenter wrote: On Thu, Jun 13, 2019 at 01:53:20PM +0530, Nishka Dasgupta wrote: On 13/06/19 12:15 PM, Dan Carpenter wrote: On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: Remove unused function eeprom_read_sz. Issue found with Coccinelle.

Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Dan Carpenter
On Thu, Jun 13, 2019 at 01:53:20PM +0530, Nishka Dasgupta wrote: > On 13/06/19 12:15 PM, Dan Carpenter wrote: > > On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: > > > Remove unused function eeprom_read_sz. > > > Issue found with Coccinelle. > > > > > > Signed-off-by: Nishka

Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Nishka Dasgupta
On 13/06/19 12:15 PM, Dan Carpenter wrote: On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: Remove unused function eeprom_read_sz. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta This is great but you need to remove the declaration from the .h file as well. I

Re: [PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-13 Thread Dan Carpenter
On Wed, Jun 12, 2019 at 11:34:29PM +0530, Nishka Dasgupta wrote: > Remove unused function eeprom_read_sz. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta This is great but you need to remove the declaration from the .h file as well. I noticed some of the other patches have

[PATCH 01/11] staging: rtl8723bs: core: Remove function eeprom_read_sz()

2019-06-12 Thread Nishka Dasgupta
Remove unused function eeprom_read_sz. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rtl8723bs/core/rtw_eeprom.c | 47 - 1 file changed, 47 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_eeprom.c