Re: [PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

2018-03-07 Thread Jonathan Cameron
On Mon, 5 Mar 2018 13:19:22 +0530 Himanshu Jha wrote: > Remove unnecessary comments since the definitions are pretty clear > with their macro names. > > Signed-off-by: Himanshu Jha Hi, The art of commenting (and indeed removing

Re: [PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

2018-03-06 Thread Himanshu Jha
Hi Shreeya, > I was just going through your patch for giving myself  > a habit of reading patches. Great! > I see here that there are many comments which are necessary > have also been removed. > Jonathan told that some of the names do not explain > much about the how registers are related to

Re: [PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

2018-03-06 Thread Shreeya Patel
On Mon, 2018-03-05 at 13:19 +0530, Himanshu Jha wrote: > Remove unnecessary comments since the definitions are pretty clear > with their macro names. > > Signed-off-by: Himanshu Jha > --- >  drivers/staging/iio/accel/adis16201.c | 82 +-- >

[PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

2018-03-04 Thread Himanshu Jha
Remove unnecessary comments since the definitions are pretty clear with their macro names. Signed-off-by: Himanshu Jha --- drivers/staging/iio/accel/adis16201.c | 82 +-- 1 file changed, 10 insertions(+), 72 deletions(-) diff --git