Re: [PATCH 1/2] staging: dgnc: make error codes uniform

2017-03-16 Thread Tobin C. Harding
On Thu, Mar 16, 2017 at 03:32:50PM +0900, Greg Kroah-Hartman wrote: > On Thu, Mar 16, 2017 at 03:46:58PM +1100, Tobin C. Harding wrote: > > On Thu, Mar 16, 2017 at 11:45:17AM +0900, Greg Kroah-Hartman wrote: > > > On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote: > > > > Driver

Re: [PATCH 1/2] staging: dgnc: make error codes uniform

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 03:46:58PM +1100, Tobin C. Harding wrote: > On Thu, Mar 16, 2017 at 11:45:17AM +0900, Greg Kroah-Hartman wrote: > > On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote: > > > Driver code is non-uniform in its use of error return codes, identical > > > failures

Re: [PATCH 1/2] staging: dgnc: make error codes uniform

2017-03-15 Thread Tobin C. Harding
On Thu, Mar 16, 2017 at 11:45:17AM +0900, Greg Kroah-Hartman wrote: > On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote: > > Driver code is non-uniform in its use of error return codes, identical > > failures are returning different error codes. Return is on failure > > when

Re: [PATCH 1/2] staging: dgnc: make error codes uniform

2017-03-15 Thread Greg Kroah-Hartman
On Wed, Mar 15, 2017 at 10:44:28AM +1100, Tobin C. Harding wrote: > Driver code is non-uniform in its use of error return codes, identical > failures are returning different error codes. Return is on failure > when checking struct magic numbers. Error codes used include -ENODEV, > -ENXIO, -EIO,

[PATCH 1/2] staging: dgnc: make error codes uniform

2017-03-14 Thread Tobin C. Harding
Driver code is non-uniform in its use of error return codes, identical failures are returning different error codes. Return is on failure when checking struct magic numbers. Error codes used include -ENODEV, -ENXIO, -EIO, and -EFAULT. Use -ENXIO. Justification is that usual call includes a check