Re: [PATCH 1/2] staging: ks7010: return on failure

2016-09-01 Thread Greg Kroah-Hartman
On Wed, Aug 24, 2016 at 12:07:35AM +0530, Sudip Mukherjee wrote: > On failure we were jumping to error_out0 where we were trying > sdio_release_host() but at this point of execution we still have not > done sdio_claim_host() and as a result host->claimed can still be 0. > And if host->claimed is 0

[PATCH 1/2] staging: ks7010: return on failure

2016-08-23 Thread Sudip Mukherjee
On failure we were jumping to error_out0 where we were trying sdio_release_host() but at this point of execution we still have not done sdio_claim_host() and as a result host->claimed can still be 0. And if host->claimed is 0 then WARN_ON(!host->claimed) will give a warning. Moreover, if it is