Re: [PATCH 1/2] staging: rts5208: Rewrite redundant if statement to improve code style

2019-07-17 Thread Dan Carpenter
On Sun, Jun 30, 2019 at 04:12:44PM +0200, Tobias Nießen wrote: > Am 26.06.2019 um 16:56 schrieb Dan Carpenter: > > Both these patches seem fine. > > > > On Wed, Jun 26, 2019 at 04:28:56PM +0200, Tobias Nießen wrote: > >> This commit uses the fact that > >> > >> if (a) { > >> if

Re: [PATCH 1/2] staging: rts5208: Rewrite redundant if statement to improve code style

2019-06-30 Thread Tobias Nießen
Am 26.06.2019 um 16:56 schrieb Dan Carpenter: > Both these patches seem fine. > > On Wed, Jun 26, 2019 at 04:28:56PM +0200, Tobias Nießen wrote: >> This commit uses the fact that >> >> if (a) { >> if (b) { >> ... >> } >> } >> >> can instead be

Re: [PATCH 1/2] staging: rts5208: Rewrite redundant if statement to improve code style

2019-06-26 Thread Joe Perches
On Wed, 2019-06-26 at 16:28 +0200, Tobias Nießen wrote: > This commit uses the fact that > > if (a) { > if (b) { > ... > } > } > > can instead be written as > > if (a && b) { > ... > } > > without any change in behavior,

Re: [PATCH 1/2] staging: rts5208: Rewrite redundant if statement to improve code style

2019-06-26 Thread Dan Carpenter
Both these patches seem fine. On Wed, Jun 26, 2019 at 04:28:56PM +0200, Tobias Nießen wrote: > This commit uses the fact that > > if (a) { > if (b) { > ... > } > } > > can instead be written as > > if (a && b) { > ... > }

[PATCH 1/2] staging: rts5208: Rewrite redundant if statement to improve code style

2019-06-26 Thread Tobias Nießen
This commit uses the fact that if (a) { if (b) { ... } } can instead be written as if (a && b) { ... } without any change in behavior, allowing to decrease the indentation of the contained code block and thus reducing the