[V2 PATCH 10/10] added kernel build, configuration, and TODO files

2014-11-10 Thread Stephanie Wallick
Signed-off-by: Sean O. Stalley sean.stal...@intel.com Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com --- MAINTAINERS| 7 +++ drivers/staging/Kconfig| 2 ++ drivers/staging/Makefile | 1 +

Re: [V2 PATCH 10/10] added kernel build, configuration, and TODO files

2014-11-10 Thread Greg KH
On Mon, Nov 10, 2014 at 06:09:41PM -0800, Stephanie Wallick wrote: Signed-off-by: Sean O. Stalley sean.stal...@intel.com Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com No changelog entry? --- MAINTAINERS| 7 +++ drivers/staging/Kconfig

Re: [PATCH 10/10] added kernel build, configuration, and TODO files

2014-11-04 Thread sostalle
On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: +- checkpatch.pl cleanups Is this still true? checkpatch.pl reports: total: 7 errors, 208

Re: [PATCH 10/10] added kernel build, configuration, and TODO files

2014-11-04 Thread Greg KH
On Tue, Nov 04, 2014 at 09:55:19AM -0800, sostalle wrote: On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is

[PATCH 10/10] added kernel build, configuration, and TODO files

2014-11-03 Thread Stephanie Wallick
Signed-off-by: Sean O. Stalley sean.stal...@intel.com Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com --- drivers/staging/Kconfig| 2 ++ drivers/staging/Makefile | 1 + drivers/staging/mausb/Kconfig | 16

Re: [PATCH 10/10] added kernel build, configuration, and TODO files

2014-11-03 Thread Greg KH
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,20 @@ +#MY_CFLAGS =-g -O0 -DEBUG_OUTPUT Please remove that line, it's not ever to be used. ___ devel mailing

Re: [PATCH 10/10] added kernel build, configuration, and TODO files

2014-11-03 Thread Greg KH
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is this still true? And why does this need to be a staging driver? What's wrong with making it a real driver now? +