[V2 PATCH 10/10] added kernel build, configuration, and TODO files
Signed-off-by: Sean O. Stalley sean.stal...@intel.com Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com --- MAINTAINERS| 7 +++ drivers/staging/Kconfig| 2 ++ drivers/staging/Makefile | 1 + drivers/staging/mausb/Kconfig | 16 drivers/staging/mausb/Makefile | 2 ++ drivers/staging/mausb/TODO | 5 + drivers/staging/mausb/drivers/Kconfig | 34 ++ drivers/staging/mausb/drivers/Makefile | 18 ++ 8 files changed, 85 insertions(+) create mode 100644 drivers/staging/mausb/Kconfig create mode 100644 drivers/staging/mausb/Makefile create mode 100644 drivers/staging/mausb/TODO create mode 100644 drivers/staging/mausb/drivers/Kconfig create mode 100644 drivers/staging/mausb/drivers/Makefile diff --git a/MAINTAINERS b/MAINTAINERS index c3cfa1b..bd52ec2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8721,6 +8721,13 @@ W: http://www.lirc.org/ S: Odd Fixes F: drivers/staging/media/lirc/ +STAGING - MEDIA AGNOSTIC USB DRIVERS +M: Sean O. Stalley sean.stal...@intel.com +M: Stephanie Wallick stephanie.s.wall...@intel.com +L: linux-...@vger.kernel.org +S: Maintained +F: drivers/staging/mausb + STAGING - NVIDIA COMPLIANT EMBEDDED CONTROLLER INTERFACE (nvec) M: Julian Andres Klode j...@jak-linux.org M: Marc Dietrich marvi...@gmx.de diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 35b494f..f57621b 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -24,6 +24,8 @@ menuconfig STAGING if STAGING +source drivers/staging/mausb/Kconfig + source drivers/staging/et131x/Kconfig source drivers/staging/slicoss/Kconfig diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile index e66a5db..7615c85 100644 --- a/drivers/staging/Makefile +++ b/drivers/staging/Makefile @@ -51,3 +51,4 @@ obj-$(CONFIG_GS_FPGABOOT) += gs_fpgaboot/ obj-$(CONFIG_BT_NOKIA_H4P) += nokia_h4p/ obj-$(CONFIG_CRYPTO_SKEIN) += skein/ obj-$(CONFIG_UNISYSSPAR) += unisys/ +obj-$(CONFIG_MAUSB)+= mausb/ diff --git a/drivers/staging/mausb/Kconfig b/drivers/staging/mausb/Kconfig new file mode 100644 index 000..095c08b --- /dev/null +++ b/drivers/staging/mausb/Kconfig @@ -0,0 +1,16 @@ + +menuconfig MAUSB + bool MA USB drivers + depends on USB + ---help--- + This option allows you to select from the various MA USB + drivers. Note that a media-specific driver (e.g. tcp or SNAP) + is needed in addition to the media agnostic host or device driver. + + +if MAUSB + +source drivers/staging/mausb/drivers/Kconfig + +endif + diff --git a/drivers/staging/mausb/Makefile b/drivers/staging/mausb/Makefile new file mode 100644 index 000..fc09fb5 --- /dev/null +++ b/drivers/staging/mausb/Makefile @@ -0,0 +1,2 @@ +obj-y += drivers/ + diff --git a/drivers/staging/mausb/TODO b/drivers/staging/mausb/TODO new file mode 100644 index 000..710ee936 --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,5 @@ +TODO: + - checkpatch.pl cleanups + - address miscellaneous TODO statements in code + - add support for multiple media agnostic (MA) devices + - add/improve support for unimplemented packet types diff --git a/drivers/staging/mausb/drivers/Kconfig b/drivers/staging/mausb/drivers/Kconfig new file mode 100644 index 000..9e12e22 --- /dev/null +++ b/drivers/staging/mausb/drivers/Kconfig @@ -0,0 +1,34 @@ +config MA_CORE + tristate MA USB core + ---help--- + This builds ma_core module. + +config MAUSB_HOST + tristate MA USB host + depends on MA_CORE + ---help--- + This builds MA USB host driver module. + +config MAUSB_DEVICE + tristate MA USB device + depends on MA_CORE USB_GADGET + ---help--- + This builds MA USB device driver module. + +config MATCP_CORE + tristate MA USB tcp core + ---help--- + This builds tcp_core module. + +config MATCP_HOST + tristate MA USB host tcp + depends on MATCP_CORE + ---help--- + This builds tcp_host module. + +config MATCP_DEVICE + tristate MA USB device tcp + depends on MATCP_CORE + ---help--- + This builds tcp_dev module. + diff --git a/drivers/staging/mausb/drivers/Makefile b/drivers/staging/mausb/drivers/Makefile new file mode 100644 index 000..47f3222 --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,18 @@ +obj-$(CONFIG_MA_CORE) += ma_core.o +ma_core-y := mausb_pkt.o mausb_tx.o mausb_msapi.o mausb_mem.o mausb_mgmt.o + +obj-$(CONFIG_MAUSB_HOST) += mausb.o +mausb-y := mausb_hcd.o mausb_hub.o mausb_tx-host.o mausb_mem-host.o + +obj-$(CONFIG_MAUSB_DEVICE) += maudc.o +maudc-y := mausb_udc.o mausb_tx-device.o + +obj-$(CONFIG_MATCP_HOST) += matcp_host.o +matcp_host-y := mausb_tcp-host.o +
Re: [V2 PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 10, 2014 at 06:09:41PM -0800, Stephanie Wallick wrote: Signed-off-by: Sean O. Stalley sean.stal...@intel.com Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com No changelog entry? --- MAINTAINERS| 7 +++ drivers/staging/Kconfig| 2 ++ drivers/staging/Makefile | 1 + drivers/staging/mausb/Kconfig | 16 drivers/staging/mausb/Makefile | 2 ++ drivers/staging/mausb/TODO | 5 + drivers/staging/mausb/drivers/Kconfig | 34 ++ drivers/staging/mausb/drivers/Makefile | 18 ++ 8 files changed, 85 insertions(+) create mode 100644 drivers/staging/mausb/Kconfig create mode 100644 drivers/staging/mausb/Makefile create mode 100644 drivers/staging/mausb/TODO create mode 100644 drivers/staging/mausb/drivers/Kconfig create mode 100644 drivers/staging/mausb/drivers/Makefile diff --git a/MAINTAINERS b/MAINTAINERS index c3cfa1b..bd52ec2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8721,6 +8721,13 @@ W: http://www.lirc.org/ S: Odd Fixes F: drivers/staging/media/lirc/ +STAGING - MEDIA AGNOSTIC USB DRIVERS +M: Sean O. Stalley sean.stal...@intel.com +M: Stephanie Wallick stephanie.s.wall...@intel.com +L: linux-...@vger.kernel.org +S: Maintained +F: drivers/staging/mausb + STAGING - NVIDIA COMPLIANT EMBEDDED CONTROLLER INTERFACE (nvec) M: Julian Andres Klode j...@jak-linux.org M: Marc Dietrich marvi...@gmx.de diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 35b494f..f57621b 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -24,6 +24,8 @@ menuconfig STAGING if STAGING +source drivers/staging/mausb/Kconfig + source drivers/staging/et131x/Kconfig source drivers/staging/slicoss/Kconfig Please put yourself at the end, not the top of this file. --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,5 @@ +TODO: + - checkpatch.pl cleanups + - address miscellaneous TODO statements in code + - add support for multiple media agnostic (MA) devices + - add/improve support for unimplemented packet types What about the other comments you already received such as: - unify with usbip diff --git a/drivers/staging/mausb/drivers/Kconfig b/drivers/staging/mausb/drivers/Kconfig new file mode 100644 index 000..9e12e22 --- /dev/null +++ b/drivers/staging/mausb/drivers/Kconfig @@ -0,0 +1,34 @@ +config MA_CORE + tristate MA USB core + ---help--- + This builds ma_core module. + +config MAUSB_HOST + tristate MA USB host + depends on MA_CORE + ---help--- + This builds MA USB host driver module. + +config MAUSB_DEVICE + tristate MA USB device + depends on MA_CORE USB_GADGET + ---help--- + This builds MA USB device driver module. + +config MATCP_CORE + tristate MA USB tcp core + ---help--- + This builds tcp_core module. + +config MATCP_HOST + tristate MA USB host tcp + depends on MATCP_CORE + ---help--- + This builds tcp_host module. + +config MATCP_DEVICE + tristate MA USB device tcp + depends on MATCP_CORE + ---help--- + This builds tcp_dev module. + diff --git a/drivers/staging/mausb/drivers/Makefile b/drivers/staging/mausb/drivers/Makefile new file mode 100644 index 000..47f3222 --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,18 @@ +obj-$(CONFIG_MA_CORE) += ma_core.o +ma_core-y := mausb_pkt.o mausb_tx.o mausb_msapi.o mausb_mem.o mausb_mgmt.o + +obj-$(CONFIG_MAUSB_HOST) += mausb.o +mausb-y := mausb_hcd.o mausb_hub.o mausb_tx-host.o mausb_mem-host.o + +obj-$(CONFIG_MAUSB_DEVICE) += maudc.o +maudc-y := mausb_udc.o mausb_tx-device.o + +obj-$(CONFIG_MATCP_HOST) += matcp_host.o +matcp_host-y := mausb_tcp-host.o + +obj-$(CONFIG_MATCP_DEVICE) += matcp_dev.o +matcp_dev-y := mausb_tcp-device.o + +obj-$(CONFIG_MATCP_CORE) += matcp_core.o +matcp_core-y := mausb_tcp.o mausb_ioctl.o Why so many different modules? Can't you merge most of these together as you can't do anything with just a few of them alone. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: +- checkpatch.pl cleanups Is this still true? checkpatch.pl reports: total: 7 errors, 208 warnings, 10489 lines checked And why does this need to be a staging driver? What's wrong with making it a real driver now? The short answer is: We don't think it's ready to be real. We didn't want to release it as a real driver because: - It's not stable enough yet. - It doesn't implement all the features required by the MA USB spec. - The MA USB spec isn't standalone. It requires a supplemental spec to define media-specific behavior, like how MA USB packets are encapsulated, how to discover MA USB devices on a network, etc. So far, no media-specific specifications have been published. - There are no commercially-available Media Agnostic USB devices. We wanted to release it to staging now because: - We have received requests from multiple companies for our host MA USB driver. Putting it in staging seemed the best way to distribute it. - We feel that releasing what we have to staging now could promote collaboration on one driver help prevent duplicate work. +- address miscellaneous TODO statements in code +- add support for multiple media agnostic (MA) devices +- add/improve support for unimplemented packet types +- handle errors and failure with more grace and less crash + +Please send patches to Greg Kroah-Hartman g...@kroah.com and cc: You didn't use this email address... +Sean Stalley sean.stal...@intel.com +Stephanie Wallick stephanie.s.wall...@intel.com + Just make a MAINTAINERS entry please for this info. We will include a MAINTAINERS entry in our next patch in lieu of emails (especially incorrect emails) in the TODO. Thanks, Sean ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Tue, Nov 04, 2014 at 09:55:19AM -0800, sostalle wrote: On Mon, Nov 03, 2014 at 01:24:04PM -0800, Greg KH wrote: On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is this still true? checkpatch.pl reports: total: 7 errors, 208 warnings, 10489 lines checked Ok, fair enough. And why does this need to be a staging driver? What's wrong with making it a real driver now? The short answer is: We don't think it's ready to be real. We didn't want to release it as a real driver because: - It's not stable enough yet. - It doesn't implement all the features required by the MA USB spec. - The MA USB spec isn't standalone. It requires a supplemental spec to define media-specific behavior, like how MA USB packets are encapsulated, how to discover MA USB devices on a network, etc. So far, no media-specific specifications have been published. - There are no commercially-available Media Agnostic USB devices. We wanted to release it to staging now because: - We have received requests from multiple companies for our host MA USB driver. Putting it in staging seemed the best way to distribute it. - We feel that releasing what we have to staging now could promote collaboration on one driver help prevent duplicate work. Ok, please include that information in the first email, it's much more helpful :) Can you resend this series, and cc: the linux-usb mailing list, and address the what about usbip? questions as well? thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH 10/10] added kernel build, configuration, and TODO files
Signed-off-by: Sean O. Stalley sean.stal...@intel.com Signed-off-by: Stephanie Wallick stephanie.s.wall...@intel.com --- drivers/staging/Kconfig| 2 ++ drivers/staging/Makefile | 1 + drivers/staging/mausb/Kconfig | 16 drivers/staging/mausb/Makefile | 3 +++ drivers/staging/mausb/TODO | 14 ++ drivers/staging/mausb/drivers/Kconfig | 34 ++ drivers/staging/mausb/drivers/Makefile | 20 7 files changed, 90 insertions(+) create mode 100644 drivers/staging/mausb/Kconfig create mode 100644 drivers/staging/mausb/Makefile create mode 100644 drivers/staging/mausb/TODO create mode 100644 drivers/staging/mausb/drivers/Kconfig create mode 100644 drivers/staging/mausb/drivers/Makefile diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index 35b494f..f57621b 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -24,6 +24,8 @@ menuconfig STAGING if STAGING +source drivers/staging/mausb/Kconfig + source drivers/staging/et131x/Kconfig source drivers/staging/slicoss/Kconfig diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile index e66a5db..7615c85 100644 --- a/drivers/staging/Makefile +++ b/drivers/staging/Makefile @@ -51,3 +51,4 @@ obj-$(CONFIG_GS_FPGABOOT) += gs_fpgaboot/ obj-$(CONFIG_BT_NOKIA_H4P) += nokia_h4p/ obj-$(CONFIG_CRYPTO_SKEIN) += skein/ obj-$(CONFIG_UNISYSSPAR) += unisys/ +obj-$(CONFIG_MAUSB)+= mausb/ diff --git a/drivers/staging/mausb/Kconfig b/drivers/staging/mausb/Kconfig new file mode 100644 index 000..095c08b --- /dev/null +++ b/drivers/staging/mausb/Kconfig @@ -0,0 +1,16 @@ + +menuconfig MAUSB + bool MA USB drivers + depends on USB + ---help--- + This option allows you to select from the various MA USB + drivers. Note that a media-specific driver (e.g. tcp or SNAP) + is needed in addition to the media agnostic host or device driver. + + +if MAUSB + +source drivers/staging/mausb/drivers/Kconfig + +endif + diff --git a/drivers/staging/mausb/Makefile b/drivers/staging/mausb/Makefile new file mode 100644 index 000..b559322 --- /dev/null +++ b/drivers/staging/mausb/Makefile @@ -0,0 +1,3 @@ +#obj-$(CONFIG_MAUSB) += drivers/ +obj-y += drivers/ + diff --git a/drivers/staging/mausb/TODO b/drivers/staging/mausb/TODO new file mode 100644 index 000..dd124ed --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups + - address miscellaneous TODO statements in code + - add support for multiple media agnostic (MA) devices + - add/improve support for unimplemented packet types + - handle errors and failure with more grace and less crash + +Please send patches to Greg Kroah-Hartman g...@kroah.com and cc: + + Sean Stalley sean.stal...@intel.com + Stephanie Wallick stephanie.s.wall...@intel.com + + + diff --git a/drivers/staging/mausb/drivers/Kconfig b/drivers/staging/mausb/drivers/Kconfig new file mode 100644 index 000..9e12e22 --- /dev/null +++ b/drivers/staging/mausb/drivers/Kconfig @@ -0,0 +1,34 @@ +config MA_CORE + tristate MA USB core + ---help--- + This builds ma_core module. + +config MAUSB_HOST + tristate MA USB host + depends on MA_CORE + ---help--- + This builds MA USB host driver module. + +config MAUSB_DEVICE + tristate MA USB device + depends on MA_CORE USB_GADGET + ---help--- + This builds MA USB device driver module. + +config MATCP_CORE + tristate MA USB tcp core + ---help--- + This builds tcp_core module. + +config MATCP_HOST + tristate MA USB host tcp + depends on MATCP_CORE + ---help--- + This builds tcp_host module. + +config MATCP_DEVICE + tristate MA USB device tcp + depends on MATCP_CORE + ---help--- + This builds tcp_dev module. + diff --git a/drivers/staging/mausb/drivers/Makefile b/drivers/staging/mausb/drivers/Makefile new file mode 100644 index 000..a38491e --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,20 @@ +#MY_CFLAGS =-g -O0 -DEBUG_OUTPUT + +obj-$(CONFIG_MA_CORE) += ma_core.o +ma_core-y := mausb_pkt.o mausb_tx.o mausb_msapi.o mausb_mem.o mausb_mgmt.o + +obj-$(CONFIG_MAUSB_HOST) += mausb.o +mausb-y := mausb_hcd.o mausb_hub.o mausb_tx-host.o mausb_mem-host.o + +obj-$(CONFIG_MAUSB_DEVICE) += maudc.o +maudc-y := mausb_udc.o mausb_tx-device.o + +obj-$(CONFIG_MATCP_HOST) += matcp_host.o +matcp_host-y := mausb_tcp-host.o + +obj-$(CONFIG_MATCP_DEVICE) += matcp_dev.o +matcp_dev-y := mausb_tcp-device.o + +obj-$(CONFIG_MATCP_CORE) += matcp_core.o +matcp_core-y := mausb_tcp.o mausb_ioctl.o + -- 1.9.1 ___ devel mailing list de...@linuxdriverproject.org
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/drivers/Makefile @@ -0,0 +1,20 @@ +#MY_CFLAGS =-g -O0 -DEBUG_OUTPUT Please remove that line, it's not ever to be used. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 10/10] added kernel build, configuration, and TODO files
On Mon, Nov 03, 2014 at 12:42:57PM -0800, Stephanie Wallick wrote: --- /dev/null +++ b/drivers/staging/mausb/TODO @@ -0,0 +1,14 @@ +TODO: + - checkpatch.pl cleanups Is this still true? And why does this need to be a staging driver? What's wrong with making it a real driver now? + - address miscellaneous TODO statements in code + - add support for multiple media agnostic (MA) devices + - add/improve support for unimplemented packet types + - handle errors and failure with more grace and less crash + +Please send patches to Greg Kroah-Hartman g...@kroah.com and cc: You didn't use this email address... + Sean Stalley sean.stal...@intel.com + Stephanie Wallick stephanie.s.wall...@intel.com + Just make a MAINTAINERS entry please for this info. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
