Re: [PATCH 14/22] staging: lustre: obd: add callback for llog_cat_process_or_fork

[Greg Kroah-Hartman]

On Fri, Dec 02, 2016 at 07:53:21PM -0500, James Simmons wrote:
> From: Alexander Boyko 
> 
> Currently llog_process_or_fork() is hard coded to
> always pass the function pointer llog_cat_process_cb().
> Change llog_cat_process_or_fork() to pass in any
> function pointer which will allow us more options
> for llog_cat callback routines in the future.

Don't change this until you have an actual user for this.  Adding
infrastructure that is not used is not ok for a staging driver, or
really any kernel driver at all.

sorry,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 14/22] staging: lustre: obd: add callback for llog_cat_process_or_fork

[James Simmons]

From: Alexander Boyko 

Currently llog_process_or_fork() is hard coded to
always pass the function pointer llog_cat_process_cb().
Change llog_cat_process_or_fork() to pass in any
function pointer which will allow us more options
for llog_cat callback routines in the future.

Signed-off-by: Alexander Boyko 
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7156
Seagate-bug-id: MRP-2383
Reviewed-on: http://review.whamcloud.com/16416
Reviewed-by: Andreas Dilger 
Reviewed-by: Nathaniel Clark 
Signed-off-by: James Simmons 
---
 drivers/staging/lustre/lustre/obdclass/llog_cat.c |   16 +++-
 1 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/llog_cat.c 
b/drivers/staging/lustre/lustre/obdclass/llog_cat.c
index ce8e2f6..de9d01d 100644
--- a/drivers/staging/lustre/lustre/obdclass/llog_cat.c
+++ b/drivers/staging/lustre/lustre/obdclass/llog_cat.c
@@ -188,7 +188,8 @@ static int llog_cat_process_cb(const struct lu_env *env,
 
 static int llog_cat_process_or_fork(const struct lu_env *env,
struct llog_handle *cat_llh,
-   llog_cb_t cb, void *data, int startcat,
+   llog_cb_t cat_cb, llog_cb_t cb,
+   void *data, int startcat,
int startidx, bool fork)
 {
struct llog_process_data d;
@@ -209,18 +210,15 @@ static int llog_cat_process_or_fork(const struct lu_env 
*env,
 
cd.lpcd_first_idx = llh->llh_cat_idx;
cd.lpcd_last_idx = 0;
-   rc = llog_process_or_fork(env, cat_llh, llog_cat_process_cb,
- , , fork);
+   rc = llog_process_or_fork(env, cat_llh, cat_cb, , , fork);
if (rc != 0)
return rc;
 
cd.lpcd_first_idx = 0;
cd.lpcd_last_idx = cat_llh->lgh_last_idx;
-   rc = llog_process_or_fork(env, cat_llh, llog_cat_process_cb,
- , , fork);
+   rc = llog_process_or_fork(env, cat_llh, cat_cb, , , fork);
} else {
-   rc = llog_process_or_fork(env, cat_llh, llog_cat_process_cb,
- , NULL, fork);
+   rc = llog_process_or_fork(env, cat_llh, cat_cb, , NULL, fork);
}
 
return rc;
@@ -229,7 +227,7 @@ static int llog_cat_process_or_fork(const struct lu_env 
*env,
 int llog_cat_process(const struct lu_env *env, struct llog_handle *cat_llh,
 llog_cb_t cb, void *data, int startcat, int startidx)
 {
-   return llog_cat_process_or_fork(env, cat_llh, cb, data, startcat,
-   startidx, false);
+   return llog_cat_process_or_fork(env, cat_llh, llog_cat_process_cb, cb,
+   data, startcat, startidx, false);
 }
 EXPORT_SYMBOL(llog_cat_process);
-- 
1.7.1

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel