Re: [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'

[Dan Carpenter]

On Tue, Oct 08, 2019 at 09:06:11AM +0300, Dan Carpenter wrote:
> On Tue, Oct 08, 2019 at 01:38:58PM +0800, zhengbin wrote:
> > diff --git a/drivers/staging/sm750fb/ddk750_mode.c 
> > b/drivers/staging/sm750fb/ddk750_mode.c
> > index 9722692..e0230f4 100644
> > --- a/drivers/staging/sm750fb/ddk750_mode.c
> > +++ b/drivers/staging/sm750fb/ddk750_mode.c
> > @@ -209,12 +209,11 @@ static int programModeRegisters(struct mode_parameter 
> > *pModeParam,
> >  int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type 
> > clock)
> >  {
> > struct pll_value pll;
> > -   unsigned int uiActualPixelClk;
> > 
> > pll.input_freq = DEFAULT_INPUT_CLOCK;
> > pll.clock_type = clock;
> > 
> > -   uiActualPixelClk = sm750_calc_pll_value(parm->pixel_clock, );
> > +   sm750_calc_pll_value(parm->pixel_clock, );
> 
> Get rid of this function as well.

Oops.  I'm wrong.  Sorry for the noise.  Leave the function.

regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'

[Dan Carpenter]

On Tue, Oct 08, 2019 at 01:38:58PM +0800, zhengbin wrote:
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c 
> b/drivers/staging/sm750fb/ddk750_mode.c
> index 9722692..e0230f4 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -209,12 +209,11 @@ static int programModeRegisters(struct mode_parameter 
> *pModeParam,
>  int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock)
>  {
>   struct pll_value pll;
> - unsigned int uiActualPixelClk;
> 
>   pll.input_freq = DEFAULT_INPUT_CLOCK;
>   pll.clock_type = clock;
> 
> - uiActualPixelClk = sm750_calc_pll_value(parm->pixel_clock, );
> + sm750_calc_pll_value(parm->pixel_clock, );

Get rid of this function as well.

regards,
dan carpenter


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 2/6] staging: sm750fb: Remove set but not used variable 'uiActualPixelClk'

[zhengbin]

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/staging/sm750fb/ddk750_mode.c: In function ddk750_setModeTiming:
drivers/staging/sm750fb/ddk750_mode.c:212:15: warning: variable 
uiActualPixelClk set but not used [-Wunused-but-set-variable]

It is not used since commit 81dee67e215b ("staging:
sm750fb: add sm750 to staging")

Reported-by: Hulk Robot 
Signed-off-by: zhengbin 
---
 drivers/staging/sm750fb/ddk750_mode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_mode.c 
b/drivers/staging/sm750fb/ddk750_mode.c
index 9722692..e0230f4 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -209,12 +209,11 @@ static int programModeRegisters(struct mode_parameter 
*pModeParam,
 int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock)
 {
struct pll_value pll;
-   unsigned int uiActualPixelClk;

pll.input_freq = DEFAULT_INPUT_CLOCK;
pll.clock_type = clock;

-   uiActualPixelClk = sm750_calc_pll_value(parm->pixel_clock, );
+   sm750_calc_pll_value(parm->pixel_clock, );
if (sm750_get_chip_type() == SM750LE) {
/* set graphic mode via IO method */
outb_p(0x88, 0x3d4);
--
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel