Re: [PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-16 Thread Mark Hounschell
On 07/15/2014 11:30 AM, Greg KH wrote: On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. configuration files should not be parsed in the kernel at all. That logic should be

Re: [PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-16 Thread Dan Carpenter
On Wed, Jul 16, 2014 at 08:39:33AM -0400, Mark Hounschell wrote: We also have this DIGI_EXPANDERS_SUPPORTED thingy. I have none of these cards. These cards interrogate the expander to find out how many ports there are. Then configure accordingly. Should we just remove all that code and NOT

Re: [PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-16 Thread DaeSeok Youn
Hi, Mark Thanks for reply. 2014-07-16 21:39 GMT+09:00 Mark Hounschell ma...@compro.net: On 07/15/2014 11:30 AM, Greg KH wrote: On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for

[PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-15 Thread Daeseok Youn
When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn

Re: [PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

2014-07-15 Thread Greg KH
On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote: When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. configuration files should not be parsed in the kernel at all. That logic should be removed as it should not be needed. Mark,