Re: [PATCH v1] staging: greybus: audio: fix uninitialized value issue

2020-08-11 Thread Vaibhav Agarwal
On Mon, Aug 10, 2020 at 8:34 PM Dan Carpenter wrote: > > On Thu, Aug 06, 2020 at 09:51:57PM +0530, Vaibhav Agarwal wrote: > > diff --git a/drivers/staging/greybus/audio_topology.c > > b/drivers/staging/greybus/audio_topology.c > > index 2f9fdbdcd547..4b914d0edef2 100644 > > ---

Re: [PATCH v1] staging: greybus: audio: fix uninitialized value issue

2020-08-10 Thread Dan Carpenter
On Thu, Aug 06, 2020 at 09:51:57PM +0530, Vaibhav Agarwal wrote: > diff --git a/drivers/staging/greybus/audio_topology.c > b/drivers/staging/greybus/audio_topology.c > index 2f9fdbdcd547..4b914d0edef2 100644 > --- a/drivers/staging/greybus/audio_topology.c > +++

[PATCH v1] staging: greybus: audio: fix uninitialized value issue

2020-08-06 Thread Vaibhav Agarwal
The current implementation for gbcodec_mixer_dapm_ctl_put() uses uninitialized gbvalue for comparison with updated value. This was found using static analysis with coverity. Uninitialized scalar variable (UNINIT) 11. uninit_use: Using uninitialized value gbvalue.value.integer_value[0]. 460