Re: [PATCH v2] Staging: slicoss: slicoss: replaced memcpy with ether_addr_copy

2014-10-08 Thread Greg KH
On Fri, Oct 03, 2014 at 10:19:44PM +0200, Abel Moyo wrote: Replaced memcpy with ether_addr_copy in slic_mcast_add_list. Addresses are _aligned(2) as the struct mcast_address has only single field of type unsigned char. Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- Changes in v2:

[PATCH v2] Staging: slicoss: slicoss: replaced memcpy with ether_addr_copy

2014-10-03 Thread Abel Moyo
Replaced memcpy with ether_addr_copy in slic_mcast_add_list. Addresses are _aligned(2) as the struct mcast_address has only single field of type unsigned char. Signed-off-by: Abel Moyo abelmoyo...@gmail.com --- Changes in v2: - Indicate how ether_addr_copy is safe in changelog

Re: [PATCH v2] Staging: slicoss: slicoss: replaced memcpy with ether_addr_copy

2014-10-03 Thread Dan Carpenter
On Fri, Oct 03, 2014 at 10:19:44PM +0200, Abel Moyo wrote: Replaced memcpy with ether_addr_copy in slic_mcast_add_list. Addresses are _aligned(2) as the struct mcast_address has only single field of type unsigned char. You have to consider the source address as well, but fair enough, that one