Re: [PATCH v2] staging:rtl8723bs: removed unwanted if..else condition

[Dan Carpenter]

On Thu, Oct 17, 2019 at 07:48:26PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti 
> 
> There is use of if..elseif..else condition which has same logic
> in all three blocks.
> Removed if..else block and placed log message instead that.
> 
> Signed-off-by: Aliasgar Surti 
> ---
> v2: Fixed alignment problem.

Thanks!

Reviewed-by: Dan Carpenter 

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2] staging:rtl8723bs: removed unwanted if..else condition

[Aliasgar Surti]

From: Aliasgar Surti 

There is use of if..elseif..else condition which has same logic
in all three blocks.
Removed if..else block and placed log message instead that.

Signed-off-by: Aliasgar Surti 
---
v2: Fixed alignment problem.
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 16 +++-
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c 
b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index e6fea96..13a9b54 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -507,19 +507,9 @@ int rtw_cmd_thread(void *context)
 
cmd_process_time = jiffies_to_msecs(jiffies - cmd_start_time);
if (cmd_process_time > 1000) {
-   if (pcmd->cmdcode == GEN_CMD_CODE(_Set_Drv_Extra)) {
-   DBG_871X(ADPT_FMT" cmd =%d process_time =%lu > 
1 sec\n",
-   ADPT_ARG(pcmd->padapter), 
pcmd->cmdcode, cmd_process_time);
-   /* rtw_warn_on(1); */
-   } else if (pcmd->cmdcode == 
GEN_CMD_CODE(_Set_MLME_EVT)) {
-   DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 
1 sec\n",
-   ADPT_ARG(pcmd->padapter), 
pcmd->cmdcode, cmd_process_time);
-   /* rtw_warn_on(1); */
-   } else {
-   DBG_871X(ADPT_FMT" cmd =%d, process_time =%lu > 
1 sec\n",
-   ADPT_ARG(pcmd->padapter), 
pcmd->cmdcode, cmd_process_time);
-   /* rtw_warn_on(1); */
-   }
+   DBG_871X(ADPT_FMT "cmd= %d process_time= %lu > 1 sec\n",
+ADPT_ARG(pcmd->padapter), pcmd->cmdcode,
+cmd_process_time);
}
 
/* call callback function for post-processed */
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel