Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-12 Thread Mark Brown
On Fri, Jun 12, 2020 at 09:07:24PM +0530, Vaibhav Agarwal wrote: > On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote: > > > Kindly suggest me the preferred way to follow on this thread. > > This is effectively out of tree code, until someone submits it properly > > I'm not sure it's

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-12 Thread Vaibhav Agarwal
On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote: > On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote: > > > With patch#6 in this series, I'm proposing some of the (dummy) helper > > APIs required to link DAPM DAI widgets for the GB Audio modules > > added/removed

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-11 Thread Mark Brown
On Wed, Jun 10, 2020 at 08:01:18PM +0200, Alexandre Belloni wrote: > My point was that if we were to keep that driver, the goal would be to > have it out of staging instead of simply making it compile. Yes, definitely - that should be the goal for anything in staging. signature.asc

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-11 Thread Mark Brown
On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote: > With patch#6 in this series, I'm proposing some of the (dummy) helper > APIs required to link DAPM DAI widgets for the GB Audio modules > added/removed dynamically. > Eventually, I would like to propose relevant changes in

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-10 Thread Vaibhav Agarwal
On Wed, Jun 10, 2020 at 06:37:11PM +0100, Mark Brown wrote: > On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote: > > The existing GB Audio codec driver is dependent on MSM8994 Audio driver. > > During the development stage, this dependency was configured due to > > various changes

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-10 Thread Alexandre Belloni
On 10/06/2020 18:37:11+0100, Mark Brown wrote: > On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote: > > The existing GB Audio codec driver is dependent on MSM8994 Audio driver. > > During the development stage, this dependency was configured due to > > various changes involved in MSM

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-10 Thread Dan Carpenter
I love this patchset so much more... Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-10 Thread Mark Brown
On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote: > The existing GB Audio codec driver is dependent on MSM8994 Audio driver. > During the development stage, this dependency was configured due to > various changes involved in MSM Audio driver to enable addtional codec > card and some

[PATCH v2 0/6] Enable Greybus Audio codec driver

2020-06-10 Thread Vaibhav Agarwal
The existing GB Audio codec driver is dependent on MSM8994 Audio driver. During the development stage, this dependency was configured due to various changes involved in MSM Audio driver to enable addtional codec card and some of the changes proposed in mainline ASoC framework. However, these are