Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio

2020-03-20 Thread Alex Riesen
Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 12:05:20 +0100: > On Fri, Mar 20, 2020 at 11:58 AM Alex Riesen > wrote: > > Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > > > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen > > > wrote: > > > > This adds an implemention of SoC DAI driver

Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio

2020-03-20 Thread Geert Uytterhoeven
Hi Alex, On Fri, Mar 20, 2020 at 11:58 AM Alex Riesen wrote: > Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen > > wrote: > > > This adds an implemention of SoC DAI driver which provides access to the > > > I2S port of the device. > > I

Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio

2020-03-20 Thread Alex Riesen
Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > CC linux-clk for the clock provider. > > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen > wrote: > > This adds an implemention of SoC DAI driver which provides access to the > > I2S port of the device. I just noticed I don't do

Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio

2020-03-20 Thread Geert Uytterhoeven
Hi Alex, On Fri, Mar 20, 2020 at 9:58 AM Alex Riesen wrote: > Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > > > +int adv748x_dai_init(struct adv748x_dai *dai) > > > +{ > > > + int ret; > > > + struct adv748x_state *state = adv748x_dai_to_state(dai); > > > + > > > +

Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio

2020-03-20 Thread Alex Riesen
Hi Geert, Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100: > CC linux-clk for the clock provider. Thanks! > > +int adv748x_dai_init(struct adv748x_dai *dai) > > +{ > > + int ret; > > + struct adv748x_state *state = adv748x_dai_to_state(dai); > > + > > + dai->mclk =

Re: [PATCH v2 05/10] media: adv748x: add support for HDMI audio

2020-03-20 Thread Geert Uytterhoeven
Hi Alex, CC linux-clk for the clock provider. On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen wrote: > This adds an implemention of SoC DAI driver which provides access to the > I2S port of the device. > > Signed-off-by: Alexander Riesen Thanks for your patch! One comment below. > --- >

[PATCH v2 05/10] media: adv748x: add support for HDMI audio

2020-03-19 Thread Alex Riesen
This adds an implemention of SoC DAI driver which provides access to the I2S port of the device. Signed-off-by: Alexander Riesen --- drivers/media/i2c/adv748x/Makefile | 3 +- drivers/media/i2c/adv748x/adv748x-core.c | 9 +- drivers/media/i2c/adv748x/adv748x-dai.c | 256