Re: [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms

2019-09-09 Thread Valentin Vidić
On Sun, Sep 08, 2019 at 08:19:21PM -0400, Valdis Klētnieks wrote: > In that case, rather than removing it, shouldn't we be *adding* > code to properly set it instead? Right, setting the UtcOffset fields to 0 is the first step marking them as invalid for now. This is also why access_time_ms did

Re: [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms

2019-09-08 Thread Valdis Klētnieks
On Sun, 08 Sep 2019 16:10:14 -, Valentin Vidic said: > Not used in the exfat-fuse implementation and spec defines > this position should hold the value for CreateUtcOffset. In that case, rather than removing it, shouldn't we be *adding* code to properly set it instead? pgpDFfdaGOzRf.pgp

Re: [PATCH v2 2/3] staging: exfat: drop unused field access_time_ms

2019-09-08 Thread Greg Kroah-Hartman
On Sun, Sep 08, 2019 at 04:10:14PM +, Valentin Vidic wrote: > Not used in the exfat-fuse implementation and spec defines > this position should hold the value for CreateUtcOffset. Then why not just put CreateUtcOffset in here instaed of deleting it? I would much rather the fields match the

[PATCH v2 2/3] staging: exfat: drop unused field access_time_ms

2019-09-08 Thread Valentin Vidic
Not used in the exfat-fuse implementation and spec defines this position should hold the value for CreateUtcOffset. Signed-off-by: Valentin Vidic --- drivers/staging/exfat/exfat.h | 3 +-- drivers/staging/exfat/exfat_core.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git