Re: [PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable"

On Mon, May 06, 2019 at 04:40:29PM +0200, Nicolas Saenz Julienne wrote: > The killable version of wait_for_completion() is meant to be used on > situations where it should not fail at all costs, but still have the > convenience of being able to kill it if really necessary. VCHIQ doesn't > fit this

Re: [PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable"

Hi Nicolas, Am 06.05.19 um 17:59 schrieb Nicolas Saenz Julienne: > Hi Dan, thanks for reviewing. > > On Mon, 2019-05-06 at 18:20 +0300, Dan Carpenter wrote: >> On Mon, May 06, 2019 at 04:40:29PM +0200, Nicolas Saenz Julienne wrote: >>> @@ -1740,7 +1740,8 @@ parse_rx_slots(struct vchiq_state

Re: [PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable"

Hi Dan, thanks for reviewing. On Mon, 2019-05-06 at 18:20 +0300, Dan Carpenter wrote: > On Mon, May 06, 2019 at 04:40:29PM +0200, Nicolas Saenz Julienne wrote: > > @@ -1740,7 +1740,8 @@ parse_rx_slots(struct vchiq_state *state) > > >bulk_rx : >bulk_tx; > > >

Re: [PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable"

On Mon, May 06, 2019 at 04:40:29PM +0200, Nicolas Saenz Julienne wrote: > @@ -1740,7 +1740,8 @@ parse_rx_slots(struct vchiq_state *state) > >bulk_rx : >bulk_tx; > > DEBUG_TRACE(PARSE_LINE); > - if

[PATCH v2 2/3] staging: vchiq: revert "switch to wait_for_completion_killable"

The killable version of wait_for_completion() is meant to be used on situations where it should not fail at all costs, but still have the convenience of being able to kill it if really necessary. VCHIQ doesn't fit this criteria, as it's mainly used as an interface to V4L2 and ALSA devices. Fixes: