Re: [PATCH v2 68/75] staging: ks7010: Replace manual array copy with ether_addr_copy().

2018-03-31 Thread Dan Carpenter
I'm in a hurry because I'm leaving for a long weekend so I've reviewed the first easy 67 patches but this one is tricky and I'm not able to review it properly before I leave. On Fri, Mar 30, 2018 at 11:08:48PM -0700, Quytelda Kahja wrote: > Copying the dummy HW address into the struct net_device

[PATCH v2 68/75] staging: ks7010: Replace manual array copy with ether_addr_copy().

2018-03-31 Thread Quytelda Kahja
Copying the dummy HW address into the struct net_device doesn't need to be done byte by byte; use ether_addr_copy() instead. Additionally, dev->dev_addr is not eight bytes long. ether_setup() sets the dev->addr_len to ETH_ALEN (defined as 6) in the net core code. Signed-off-by: Quytelda Kahja