The 'device_open_status' member of 'struct ks_wlan_private' is only
ever set to zero or one, so it makes more sense for it to be a bool
instead of an int.

Signed-off-by: Quytelda Kahja <quyte...@tamalin.org>
---
 drivers/staging/ks7010/ks_wlan.h     | 2 +-
 drivers/staging/ks7010/ks_wlan_net.c | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 012e0fe2b60d..91231de5404f 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -441,7 +441,7 @@ struct ks_wlan_private {
        unsigned int need_commit;       /* for ioctl */
 
        /* DeviceIoControl */
-       int device_open_status;
+       bool device_open_status;
        atomic_t event_count;
        atomic_t rec_count;
        int dev_count;
diff --git a/drivers/staging/ks7010/ks_wlan_net.c 
b/drivers/staging/ks7010/ks_wlan_net.c
index afbc472baa05..e1773e57cbb0 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -2871,10 +2871,9 @@ int ks_wlan_net_start(struct net_device *dev)
 
        priv = netdev_priv(dev);
        priv->mac_address_valid = false;
+       priv->device_open_status = true;
        priv->need_commit = 0;
 
-       priv->device_open_status = 1;
-
        /* phy information update timer */
        atomic_set(&update_phyinfo, 0);
        timer_setup(&update_phyinfo_timer, ks_wlan_update_phyinfo_timeout, 0);
@@ -2893,7 +2892,7 @@ int ks_wlan_net_stop(struct net_device *dev)
 {
        struct ks_wlan_private *priv = netdev_priv(dev);
 
-       priv->device_open_status = 0;
+       priv->device_open_status = false;
        del_timer_sync(&update_phyinfo_timer);
 
        if (netif_running(dev))
-- 
2.16.3

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to