Re: [PATCH v3] staging: fieldbus: core: fix ->poll() annotation

2019-05-21 Thread Sven Van Asbroeck
On Tue, May 21, 2019 at 10:37 AM Dan Carpenter wrote: > > > If you're resending someone's patch, you have to add your own Signed off > by line as well. Everyone who touches a patch has to sign that they > didn't add any of SCO's all powerful UnixWare source code into the > patch. > Thank you

Re: [PATCH v3] staging: fieldbus: core: fix ->poll() annotation

2019-05-21 Thread Dan Carpenter
On Tue, May 21, 2019 at 10:20:09AM -0400, Sven Van Asbroeck wrote: > From: Oscar Gomez Fuente > > ->poll() functions should return __poll_t, but the fieldbus > core's poll() does not. This generates a sparse warning. > > Fix the ->poll() return value, and use recommended __poll_t > constants

Re: [PATCH v3] staging: fieldbus: core: fix ->poll() annotation

2019-05-21 Thread Sven Van Asbroeck
On Tue, May 21, 2019 at 10:20 AM Sven Van Asbroeck wrote: > > From: Oscar Gomez Fuente > > ->poll() functions should return __poll_t, but the fieldbus > core's poll() does not. This generates a sparse warning. > > Fix the ->poll() return value, and use recommended __poll_t > constants

[PATCH v3] staging: fieldbus: core: fix ->poll() annotation

2019-05-21 Thread Sven Van Asbroeck
From: Oscar Gomez Fuente ->poll() functions should return __poll_t, but the fieldbus core's poll() does not. This generates a sparse warning. Fix the ->poll() return value, and use recommended __poll_t constants (EPOLLxxx). Signed-off-by: Oscar Gomez Fuente ---