Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-20 Thread Greg KH
On Sat, Oct 19, 2013 at 04:15:25PM -0700, Lisa Nguyen wrote: On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter dan.carpen...@oracle.com wrote: Your patch is great, but actually, are any of the functions in this header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows this

Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-20 Thread Lisa Nguyen
On Sun, Oct 20, 2013 at 12:43 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Oct 19, 2013 at 04:15:25PM -0700, Lisa Nguyen wrote: On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter dan.carpen...@oracle.com wrote: Your patch is great, but actually, are any of the functions in this header

[PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Lisa Nguyen
Fix cfs_bitmap struct, function parameters, and variable declarations to resolve the Do not add new typedefs warning generated by checkpatch.pl in bitmap.h and meet kernel coding style. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- Changes since v3: - Combining the previous two patch

Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Dan Carpenter
Your patch is great, but actually, are any of the functions in this header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows this header file. Perhaps we can delete the whole thing? regards, dan carpenter ___ devel mailing list

Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Lisa Nguyen
On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter dan.carpen...@oracle.com wrote: Your patch is great, but actually, are any of the functions in this header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows this header file. Perhaps we can delete the whole thing? regards, dan