Re: [Outreachy kernel] Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

2018-03-07 Thread Dan Carpenter
On Wed, Mar 07, 2018 at 11:52:16AM +0100, Julia Lawall wrote: > > > On Wed, 7 Mar 2018, Dan Carpenter wrote: > > > On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote: > > > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff > > > *skb, int hdr_len, void *priv) >

Re: [Outreachy kernel] Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

2018-03-07 Thread Julia Lawall
On Wed, 7 Mar 2018, Dan Carpenter wrote: > On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote: > > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff > > *skb, int hdr_len, void *priv) > > keyidx = pos[3]; > > if (!(keyidx & (1 << 5))) { > >

Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

2018-03-07 Thread Dan Carpenter
On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote: > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, > int hdr_len, void *priv) > keyidx = pos[3]; > if (!(keyidx & (1 << 5))) { > if (net_ratelimit()) { > -

[PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.

2018-03-07 Thread Arushi Singhal
printk() is the raw way to print output and should be avoided. For drivers with defined "struct device object", dev_*macro() is prefer and for "struct netdevice object", netdev_*macro() is prefer over dev_*macro() to standardize the output format within the subsystem. If no "struct device