Re: [PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

2018-03-07 Thread Jonathan Cameron
On Sun, 04 Mar 2018 18:37:04 +0530 Shreeya Patel wrote: > On Sun, 2018-03-04 at 18:26 +0530, Himanshu Jha wrote: > > Hi Shreeya, > > > > On Sun, Mar 04, 2018 at 06:06:22PM +0530, Shreeya Patel wrote: > > > > > > Remove some unnecessay comments and group the

Re: [PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

2018-03-04 Thread Shreeya Patel
On Sun, 2018-03-04 at 18:26 +0530, Himanshu Jha wrote: > Hi Shreeya, > > On Sun, Mar 04, 2018 at 06:06:22PM +0530, Shreeya Patel wrote: > > > > Remove some unnecessay comments and group the control > > register and register field macros together. > > Some of the register names does not make it's

Re: [PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

2018-03-04 Thread Himanshu Jha
Hi Shreeya, On Sun, Mar 04, 2018 at 06:06:22PM +0530, Shreeya Patel wrote: > Remove some unnecessay comments and group the control > register and register field macros together. > Some of the register names does not make it's puporse > very clear and hence, add some comments for more >

[PATCH v3 1/4] Staging: iio: adis16209: Remove and add some comments and group the definitions

2018-03-04 Thread Shreeya Patel
Remove some unnecessay comments and group the control register and register field macros together. Some of the register names does not make it's puporse very clear and hence, add some comments for more information. Also there are certain unit based comments which are not providing sufficient