Re: [PATCH v3 20/28] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

[Dan Carpenter]

On Thu, Nov 10, 2016 at 04:25:56AM -0500, Brian Masney wrote:
> in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.

It's a totally safe assumption.  The only problem is that it's less
readable than sizeof().

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 20/28] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

[Jonathan Cameron]

On 10/11/16 09:25, Brian Masney wrote:
> in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.
> Replace this with sizeof(unsigned int).
> 
> Signed-off-by: Brian Masney 
Preferred to use sizeof(value[0]) in case it changes type sometime in the 
future?
> ---
>  drivers/staging/iio/light/tsl2583.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c 
> b/drivers/staging/iio/light/tsl2583.c
> index 1b883b5..bcee31b 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -578,7 +578,7 @@ static ssize_t in_illuminance_lux_table_store(struct 
> device *dev,
>  
>   /* Zero out the table */
>   memset(tsl2583_device_lux, 0, sizeof(tsl2583_device_lux));
> - memcpy(tsl2583_device_lux, [1], value[0] * 4);
> + memcpy(tsl2583_device_lux, [1], value[0] * sizeof(unsigned int));
>  
>   ret = len;
>  
> 

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 20/28] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

[Brian Masney]

in_illuminance_lux_table_store assumes that an unsigned int is 32 bits.
Replace this with sizeof(unsigned int).

Signed-off-by: Brian Masney 
---
 drivers/staging/iio/light/tsl2583.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/light/tsl2583.c 
b/drivers/staging/iio/light/tsl2583.c
index 1b883b5..bcee31b 100644
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -578,7 +578,7 @@ static ssize_t in_illuminance_lux_table_store(struct device 
*dev,
 
/* Zero out the table */
memset(tsl2583_device_lux, 0, sizeof(tsl2583_device_lux));
-   memcpy(tsl2583_device_lux, [1], value[0] * 4);
+   memcpy(tsl2583_device_lux, [1], value[0] * sizeof(unsigned int));
 
ret = len;
 
-- 
2.7.4

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel