Re: [PATCH v4 16/18] dt: bindings: net: add microchip,wilc1000,sdio.yaml
Hi Rob,
Thanks for reviewing.
On 03/03/20 7:25 am, Rob Herring wrote:
>
> On Mon, Mar 02, 2020 at 04:34:40PM +, ajay.kat...@microchip.com wrote:
>> From: Ajay Singh
>>
>> Moved '/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml' to
>> 'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml'.
>>
>> Signed-off-by: Ajay Singh
>> ---
>> .../net/wireless/microchip,wilc1000,sdio.yaml | 68 +++
>> 1 file changed, 68 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
>>
>> b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
>> new file mode 100644
>> index ..b338f569f7e2
>> --- /dev/null
>> +++
>> b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
>> @@ -0,0 +1,68 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:
>> http://devicetree.org/schemas/net/wireless/microchip,wilc1000,sdio.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Microchip WILC wireless SDIO devicetree bindings
>> +
>> +maintainers:
>> + - Adham Abozaeid
>> + - Ajay Singh
>> +
>> +description:
>> + The wilc1000 chips can be connected via SDIO. The node is used to
>> + specify child node to the SDIO controller that connects the device
>> + to the system.
>> +
>> +properties:
>> + compatible:
>> +const: microchip,wilc1000-sdio
>> +
>> + irq-gpios:
>
> Unless you need GPIO control of the line, use 'interrupts' instead.
I will check this.
>
>> +description: The GPIO phandle connect to a host IRQ.
>> +maxItems: 1
>> +
>> + reg:
>> +description: Slot ID used in the controller.
>
> No, it's the function number. But you can just drop this.
>
Ok. I will drop this description.
>> +maxItems: 1
>> +
>> + clocks:
>> +description: phandle to the clock connected on rtc clock line.
>> +maxItems: 1
>> +
>> + bus-width:
>
> I believe this is defined to go in the parent node.
>
In that case, I think we can drop this description here by moving it to
parent node. right?
>> +description: The number of data lines wired up the slot.
>> +allOf:
>> + - $ref: /schemas/types.yaml#/definitions/uint32
>> + - enum: [1, 4, 8]
>> + - default: 1
>> +
>> +required:
>> + - compatible
>> + - irq-gpios
>> + - reg
>> +
>> +examples:
>> + - |
>> +mmc1: mmc@fc00 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <_mmc1_clk_cmd_dat0 _mmc1_dat1_3>;
>> + non-removable;
>> + vmmc-supply = <_mmc1_reg>;
>> + vqmmc-supply = <_3v3_reg>;
>> + status = "okay";
>
> Don't show 'status' in examples.
>
OK. I will remove this.
>> + wilc_sdio@0 {
>
> wifi@0
>
>> +compatible = "microchip,wilc1000-sdio";
>> + irq-gpios = < 27 0>;
>> + reg = <0>;
>> + clocks = <>;
>> + clock-names = "rtc_clk";
>> + assigned-clocks = <>;
>> + assigned-clock-rates = <32768>;
>> + status = "okay";
I will remove 'status' here also.
>> + bus-width = <4>;
I will move this property to parent node.
>> +};
>> +};
>> --
>> 2.24.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v4 16/18] dt: bindings: net: add microchip,wilc1000,sdio.yaml
On Mon, Mar 02, 2020 at 04:34:40PM +, ajay.kat...@microchip.com wrote:
> From: Ajay Singh
>
> Moved '/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml' to
> 'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml'.
>
> Signed-off-by: Ajay Singh
> ---
> .../net/wireless/microchip,wilc1000,sdio.yaml | 68 +++
> 1 file changed, 68 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
> b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
> new file mode 100644
> index ..b338f569f7e2
> --- /dev/null
> +++
> b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/microchip,wilc1000,sdio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip WILC wireless SDIO devicetree bindings
> +
> +maintainers:
> + - Adham Abozaeid
> + - Ajay Singh
> +
> +description:
> + The wilc1000 chips can be connected via SDIO. The node is used to
> + specify child node to the SDIO controller that connects the device
> + to the system.
> +
> +properties:
> + compatible:
> +const: microchip,wilc1000-sdio
> +
> + irq-gpios:
Unless you need GPIO control of the line, use 'interrupts' instead.
> +description: The GPIO phandle connect to a host IRQ.
> +maxItems: 1
> +
> + reg:
> +description: Slot ID used in the controller.
No, it's the function number. But you can just drop this.
> +maxItems: 1
> +
> + clocks:
> +description: phandle to the clock connected on rtc clock line.
> +maxItems: 1
> +
> + bus-width:
I believe this is defined to go in the parent node.
> +description: The number of data lines wired up the slot.
> +allOf:
> + - $ref: /schemas/types.yaml#/definitions/uint32
> + - enum: [1, 4, 8]
> + - default: 1
> +
> +required:
> + - compatible
> + - irq-gpios
> + - reg
> +
> +examples:
> + - |
> +mmc1: mmc@fc00 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_mmc1_clk_cmd_dat0 _mmc1_dat1_3>;
> + non-removable;
> + vmmc-supply = <_mmc1_reg>;
> + vqmmc-supply = <_3v3_reg>;
> + status = "okay";
Don't show 'status' in examples.
> + wilc_sdio@0 {
wifi@0
> +compatible = "microchip,wilc1000-sdio";
> + irq-gpios = < 27 0>;
> + reg = <0>;
> + clocks = <>;
> + clock-names = "rtc_clk";
> + assigned-clocks = <>;
> + assigned-clock-rates = <32768>;
> + status = "okay";
> + bus-width = <4>;
> +};
> +};
> --
> 2.24.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v4 16/18] dt: bindings: net: add microchip,wilc1000,sdio.yaml
From: Ajay Singh
Moved '/drivers/staging/wilc1000/microchip,wilc1000,sdio.yaml' to
'Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml'.
Signed-off-by: Ajay Singh
---
.../net/wireless/microchip,wilc1000,sdio.yaml | 68 +++
1 file changed, 68 insertions(+)
create mode 100644
Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
diff --git
a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
new file mode 100644
index ..b338f569f7e2
--- /dev/null
+++
b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000,sdio.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/microchip,wilc1000,sdio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip WILC wireless SDIO devicetree bindings
+
+maintainers:
+ - Adham Abozaeid
+ - Ajay Singh
+
+description:
+ The wilc1000 chips can be connected via SDIO. The node is used to
+ specify child node to the SDIO controller that connects the device
+ to the system.
+
+properties:
+ compatible:
+const: microchip,wilc1000-sdio
+
+ irq-gpios:
+description: The GPIO phandle connect to a host IRQ.
+maxItems: 1
+
+ reg:
+description: Slot ID used in the controller.
+maxItems: 1
+
+ clocks:
+description: phandle to the clock connected on rtc clock line.
+maxItems: 1
+
+ bus-width:
+description: The number of data lines wired up the slot.
+allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ - enum: [1, 4, 8]
+ - default: 1
+
+required:
+ - compatible
+ - irq-gpios
+ - reg
+
+examples:
+ - |
+mmc1: mmc@fc00 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <_mmc1_clk_cmd_dat0 _mmc1_dat1_3>;
+ non-removable;
+ vmmc-supply = <_mmc1_reg>;
+ vqmmc-supply = <_3v3_reg>;
+ status = "okay";
+ wilc_sdio@0 {
+compatible = "microchip,wilc1000-sdio";
+ irq-gpios = < 27 0>;
+ reg = <0>;
+ clocks = <>;
+ clock-names = "rtc_clk";
+ assigned-clocks = <>;
+ assigned-clock-rates = <32768>;
+ status = "okay";
+ bus-width = <4>;
+};
+};
--
2.24.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
