Re: [PATCH v5.1 1/2] staging: ion: Add generic ion-physmem driver

2015-07-01 Thread Dan Carpenter
I started reviewing this patch but then part way through I relized I must be missing quite a bit of it... On Tue, Jun 30, 2015 at 10:56:27AM -0700, Laura Abbott wrote: > On 06/30/2015 08:34 AM, Andrew Andrianov wrote: > >+static int ion_physmem_probe(struct platform_device *pdev) > >+{ > >+int

Re: [PATCH v5.1 1/2] staging: ion: Add generic ion-physmem driver

2015-06-30 Thread Andrew
Thanks for the detailed review Laura Abbott писал 30.06.2015 20:56: On 06/30/2015 08:34 AM, Andrew Andrianov wrote: if (!idev) + return -ENOMEM; + } Yeah this is a bit messy as your comments note. Since there can only be one Ion device in the system, it s

Re: [PATCH v5.1 1/2] staging: ion: Add generic ion-physmem driver

2015-06-30 Thread Laura Abbott
On 06/30/2015 08:34 AM, Andrew Andrianov wrote: This patch adds a generic ion driver that allows ion heaps to be added via devicetree. It provides a simple and generic way to feed physical memory regions to ion without writing a custom driver, e.g. ion_sram: ion@0x0010 {