Re: [PATCH v6] staging: atomisp: move null check to earlier point

2020-08-06 Thread Cengiz Can
On August 6, 2020 21:39:21 Greg KH wrote: On Thu, Aug 06, 2020 at 09:34:22PM +0300, Cengiz Can wrote: Hello Andy, Can I get some feedback on v6 please? It's been 4 days, in the middle of a merge window, please give people a chance to catch up on other things... I wasn't aware of that

Re: [PATCH v6] staging: atomisp: move null check to earlier point

2020-08-06 Thread Greg KH
On Thu, Aug 06, 2020 at 09:34:22PM +0300, Cengiz Can wrote: > Hello Andy, > > Can I get some feedback on v6 please? It's been 4 days, in the middle of a merge window, please give people a chance to catch up on other things... and do not top post please. thanks, greg k-h

Re: [PATCH v6] staging: atomisp: move null check to earlier point

2020-08-06 Thread Cengiz Can
Hello Andy, Can I get some feedback on v6 please? I hope it suits your standards this time. Thank you On August 2, 2020 01:02:22 Cengiz Can wrote: `find_gmin_subdev()` that returns a pointer to `struct gmin_subdev` can return NULL. In `gmin_v2p8_ctrl()` there's a call to this function but

[PATCH v6] staging: atomisp: move null check to earlier point

2020-08-01 Thread Cengiz Can
`find_gmin_subdev()` that returns a pointer to `struct gmin_subdev` can return NULL. In `gmin_v2p8_ctrl()` there's a call to this function but the possibility of a NULL was not checked before its being dereferenced, i.e.: /* Acquired here v */ struct gmin_subdev *gs =