Re: [Patch v2] staging: rtl8723bs: os_dep: ioctl_linux: make use of kzalloc

2019-06-18 Thread Dan Carpenter
On Tue, Jun 18, 2019 at 07:14:10AM +0530, Hariprasad Kelam wrote: > kmalloc with memset can be replaced with kzalloc. > > Signed-off-by: Hariprasad Kelam > - > changes in v2: Replace rtw_zmalloc with kzalloc > --- > --- The changelog should say something like: This patch is a cleanup

Re: [Patch v2] staging: rtl8723bs: os_dep: ioctl_linux: make use of kzalloc

2019-06-18 Thread Greg Kroah-Hartman
On Tue, Jun 18, 2019 at 07:14:10AM +0530, Hariprasad Kelam wrote: > kmalloc with memset can be replaced with kzalloc. Yes, but did you audit the call-paths of this to ensure that GFP_KERNEL is the correct value for kzalloc() here? If so, please document that in the changelog. thanks, greg k-h

[Patch v2] staging: rtl8723bs: os_dep: ioctl_linux: make use of kzalloc

2019-06-17 Thread Hariprasad Kelam
kmalloc with memset can be replaced with kzalloc. Signed-off-by: Hariprasad Kelam - changes in v2: Replace rtw_zmalloc with kzalloc --- --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git