Re: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-02-11 Thread Dan Carpenter
Why is this loop soo complicated? Why do you need to mess around with this last_ep stuff - you don't actually end up using it. The loop reduces down to this without comments: for (i = 0; !ret; i++) { Philipp, ret isn't set anymore in the new loop.

Re: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-02-11 Thread Philipp Zabel
Hi Dan, Am Dienstag, den 11.02.2014, 11:38 +0300 schrieb Dan Carpenter: Why is this loop soo complicated? Why do you need to mess around with this last_ep stuff - you don't actually end up using it. The loop reduces down to this without comments: for (i = 0; !ret; i++) {

Re: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-02-10 Thread Russell King - ARM Linux
On Mon, Jan 06, 2014 at 03:52:01PM +0100, Philipp Zabel wrote: @@ -438,24 +453,21 @@ int imx_drm_encoder_parse_of(struct drm_device *drm, struct drm_encoder *encoder, struct device_node *np) { struct imx_drm_device *imxdrm = drm-dev_private; + struct device_node *ep, *last_ep

Re: [RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-02-10 Thread Philipp Zabel
On Mon, Feb 10, 2014 at 04:26:31PM +, Russell King - ARM Linux wrote: [...] Why is this loop soo complicated? Why do you need to mess around with this last_ep stuff - you don't actually end up using it. The last_ep dance is necessary because v4l2_of_get_next_endpoint(node,prev) does not

[RFC PATCH 2/3] staging: imx-drm-core: Use graph to find connection between crtc and encoder

2014-01-06 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 44 -- 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index