Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread Sean O. Stalley
On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: Intel has a whole group of very experienced Linux kernel developers who will review code before you sent it out publicly. Please take advantage of them and run this all

Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread Greg KH
On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote: On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: Intel has a whole group of very experienced Linux kernel developers who will review code before you

Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-11 Thread steph
On Wed, Nov 12, 2014 at 10:14:38AM +0900, Greg KH wrote: On Tue, Nov 11, 2014 at 02:42:22PM -0800, Sean O. Stalley wrote: On Tue, Nov 11, 2014 at 01:38:21PM +0900, Greg KH wrote: On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: Yes, I am holding you to a higher standard

[V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-10 Thread Stephanie Wallick
This is where we create, store and handle endpoint and device structures that are specific to the MA USB drivers. Each MA USB structure maps 1:1 with it's corresponding USB structure (e.g. there is one MA USB endpoint per USB endpoint). Signed-off-by: Sean O. Stalley sean.stal...@intel.com

Re: [V2 PATCH 03/10] added media agnostic (MA) data structures and handling

2014-11-10 Thread Greg KH
On Mon, Nov 10, 2014 at 06:09:34PM -0800, Stephanie Wallick wrote: +/** + * Returns the number of urbs currently in the MA USB HCD. Will return 0 if the + * MA USB HCD is empty or a negative errno if an error occurs. How can this function return a negative number? I don't see that codepath