Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

2016-03-23 Thread 'Greg Kroah-Hartman'
On Wed, Mar 23, 2016 at 08:29:49PM +, Simmons, James A. wrote: > > >> > > so the right code should be: > >> > > > >> > > sizeof(**net->ibn_tx_ps); > >> > > and the same for sizeof(**net->ibn_fmr_ps) > >> > That's a mess, isn't there some other way to fix this up to be more > >> >

RE: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

2016-03-23 Thread Simmons, James A.
>> > > so the right code should be: >> > > >> > > sizeof(**net->ibn_tx_ps); >> > > and the same for sizeof(**net->ibn_fmr_ps) >> > That's a mess, isn't there some other way to fix this up to be more >> > "obvious"? >> This must have been encountered in the past. How was it handle in

Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

2016-03-23 Thread Joe Perches
On Wed, 2016-03-23 at 18:31 +, Simmons, James A. wrote: > > On Wed, Mar 23, 2016 at 05:39:36AM +, Dilger, Andreas wrote: > > > On 2016/03/22, 19:49, "lustre-devel on behalf of Greg Kroah-Hartman" > > > > > gre...@linuxfoundation.org>

RE: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

2016-03-23 Thread Simmons, James A.
>On Wed, Mar 23, 2016 at 05:39:36AM +, Dilger, Andreas wrote: >> On 2016/03/22, 19:49, "lustre-devel on behalf of Greg Kroah-Hartman" >> > gre...@linuxfoundation.org> wrote: >> >> >On Tue, Mar 22, 2016 at 06:21:04PM -0400, James Simmons

Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

2016-03-23 Thread Greg Kroah-Hartman
On Wed, Mar 23, 2016 at 05:39:36AM +, Dilger, Andreas wrote: > On 2016/03/22, 19:49, "lustre-devel on behalf of Greg Kroah-Hartman" > gre...@linuxfoundation.org> wrote: > > >On Tue, Mar 22, 2016 at 06:21:04PM -0400, James Simmons wrote: >

Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

2016-03-23 Thread Oucharek, Doug S
Yes, those are “per-CPT allocations”. So the allocator ends up allocating an array of pointers to the given data type. Doug On Mar 22, 2016, at 10:39 PM, Dilger, Andreas > wrote: On 2016/03/22, 19:49, "lustre-devel on behalf of Greg

Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

2016-03-22 Thread Dilger, Andreas
On 2016/03/22, 19:49, "lustre-devel on behalf of Greg Kroah-Hartman" wrote: >On Tue, Mar 22, 2016 at 06:21:04PM -0400, James Simmons wrote: >> Latest testing fails when using ko2iblnd. It was tracked down >> to commit