On Thu, Feb 14, 2019 at 08:54:31PM -0500, Sasha Levin wrote:
> On Sat, Feb 02, 2019 at 03:07:35PM -0500, Kimberly Brown wrote:
> > On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote:
> > > > From: Kimberly Brown
> > > > Sent: Thursday, January 31, 2019 9:47 AM
> > > > ...
> > > > 2)
On Sat, Feb 02, 2019 at 03:07:35PM -0500, Kimberly Brown wrote:
On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote:
> From: Kimberly Brown
> Sent: Thursday, January 31, 2019 9:47 AM
> ...
> 2) Prevent a deadlock that can occur between the proposed mutex_lock()
> call in the
On Fri, Feb 01, 2019 at 06:24:24PM +, Dexuan Cui wrote:
> > From: Kimberly Brown
> > Sent: Thursday, January 31, 2019 9:47 AM
> > ...
> > 2) Prevent a deadlock that can occur between the proposed mutex_lock()
> > call in the vmbus_chan_attr_show() function and the sysfs/kernfs functions.
> Hi
> From: Kimberly Brown
> Sent: Thursday, January 31, 2019 9:47 AM
> ...
> 2) Prevent a deadlock that can occur between the proposed mutex_lock()
> call in the vmbus_chan_attr_show() function and the sysfs/kernfs functions.
Hi Kim,
Can you please share more details about the deadlock?
It's
On Thu, Jan 31, 2019 at 12:47:07PM -0500, Kimberly Brown wrote:
On Thu, Jan 31, 2019 at 04:45:35PM +, Michael Kelley wrote:
From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM
>
> I've queued this one for hyper-fixes, thanks all!
>
Actually, please hold off on queuing this one. In
On Thu, Jan 31, 2019 at 04:45:35PM +, Michael Kelley wrote:
> From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM
> >
> > I've queued this one for hyper-fixes, thanks all!
> >
>
> Actually, please hold off on queuing this one. In a conversation I had
> yesterday with Kim, they had
From: Sasha Levin Sent: Thursday, January 31, 2019 7:20 AM
>
> I've queued this one for hyper-fixes, thanks all!
>
Actually, please hold off on queuing this one. In a conversation I had
yesterday with Kim, they had identified a deadlock. Kim was going to be
looking at some revisions to
On Tue, Jan 29, 2019 at 07:20:28PM +, Dexuan Cui wrote:
From: Kimberly Brown
> ...
> But as you pointed, at least for sub-channels, channel->ringbuffer_page
> can indeed disappear in vmbus_close() -> ... -> vmbus_free_ring(), and
> the "attribute->show()" could crash when the race happens.
> From: Kimberly Brown
> > ...
> > But as you pointed, at least for sub-channels, channel->ringbuffer_page
> > can indeed disappear in vmbus_close() -> ... -> vmbus_free_ring(), and
> > the "attribute->show()" could crash when the race happens.
> > Adding channel_mutex here seems to be able to
On Tue, Jan 22, 2019 at 06:40:30PM +, Dexuan Cui wrote:
> > From: Kimberly Brown
> > Sent: Monday, January 21, 2019 10:43 PM
> > > > @@ -1421,7 +1422,10 @@ static ssize_t vmbus_chan_attr_show(struct
> > > > kobject *kobj,
> > > > if (chan->state != CHANNEL_OPENED_STATE)
> > > >
> From: Kimberly Brown
> Sent: Monday, January 21, 2019 10:43 PM
> > > @@ -1421,7 +1422,10 @@ static ssize_t vmbus_chan_attr_show(struct
> > > kobject *kobj,
> > > if (chan->state != CHANNEL_OPENED_STATE)
> > > return -EINVAL;
> > >
> > > - return attribute->show(chan, buf);
> > > +
On Tue, Jan 22, 2019 at 03:46:48AM +, Dexuan Cui wrote:
> > From: Kimberly Brown
> > Sent: Monday, January 21, 2019 6:08 PM
> > Subject: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show
> > functions
> >
> > The channel level "_show" functions are vulnerable to race conditions.
>
> From: Kimberly Brown
> Sent: Monday, January 21, 2019 6:08 PM
> Subject: [PATCH] Drivers: hv: vmbus: Add mutex lock to channel show functions
>
> The channel level "_show" functions are vulnerable to race conditions.
> Add a mutex lock and unlock around the call to the channel level "_show"
>
13 matches
Mail list logo
