Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"

2018-04-12 Thread Lorenzo Pieralisi
On Thu, Apr 12, 2018 at 03:56:42PM +, Sridhar Pitchai wrote: > > > > >> I am still not happy with this patch. > > >> > > >> - You do not explain at all the dependency on commit > 0c195567a8f6 and > > >>you should because that's fundamental, if that

RE: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"

2018-04-12 Thread Haiyang Zhang
.@microsoft.com>; Stephen Hemminger <sthem...@microsoft.com>; > Jake Oshins <ja...@microsoft.com>; KY Srinivasan <k...@microsoft.com>; > Michael Kelley (EOSG) <michael.h.kel...@microsoft.com>; > de...@linuxdriverproject.org; linux-...@vger.kernel.org; linux- > ke

Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"

2018-04-12 Thread Sridhar Pitchai
> > >> I am still not happy with this patch. > >> > >> - You do not explain at all the dependency on commit 0c195567a8f6 and > >>you should because that's fundamental, if that patch is not present > >>this revert breaks the kernel as per

Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"

2018-04-12 Thread Sridhar Pitchai
>> I am still not happy with this patch. >> >> - You do not explain at all the dependency on commit 0c195567a8f6 and >>you should because that's fundamental, if that patch is not present >>this revert breaks the kernel as per previous discussions[1]. >> - You are

Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"

2018-04-12 Thread Bjorn Helgaas
On Thu, Apr 12, 2018 at 10:17:42AM +0100, Lorenzo Pieralisi wrote: > On Thu, Apr 12, 2018 at 02:44:42AM +, Sridhar Pitchai wrote: > > When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI > > bus to the guest, Hyper-V always provides unique PCI domain. > > > > commit

Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"

2018-04-12 Thread Lorenzo Pieralisi
On Thu, Apr 12, 2018 at 02:44:42AM +, Sridhar Pitchai wrote: > When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI > bus to the guest, Hyper-V always provides unique PCI domain. > > commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain") > overrode unique