[PATCH v2 2/2] staging: lustre: restore initialization of return code

A recent rework removed the initialization of the successful return code from lov_getstripe: drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe': drivers/staging/lustre/lustre/lov/lov_pack.c:426:9: error: 'rc' may be used uninitialized in this function

[PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern

After a recent bugfix, we get a warning about the use of an uninitialized variable: drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function 'cfs_cpt_table_create_pattern': drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c:833:7: error: 'str' may be used uninitialized in this

RE: [PATCH 0/9] staging: fsl-mc: move bus driver out of staging, add dpio

> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Monday, October 24, 2016 9:34 AM > To: Stuart Yoder ; gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org; >

[PATCH] staging: sm750fb: Refine the code and remove unused code.

Every call to the function waitNextVerticalSync() used the macro primaryWaitVerticalSync(), so the macro was removed and the function waitNextVerticalSync() renamed to primary_wait_vertical_sync(). With this change, an unnecessary 'if' statement was removed together with the lines within the

[PATCH v2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

The original arm implementation uses dmac_map_area which is not portable. Replace it with an architecture neutral version which uses dma_map_sg. As you can see that for larger page sizes, the dma_map_sg implementation is faster then the original unportable dma_map_area implementation. Test

Re: [PATCH 09/14] staging: fsl-mc: misc whitespace cleanup

On Mon, Oct 17, 2016 at 01:43:16PM -0500, Stuart Yoder wrote: > From: Ioana Ciornei > > Make whitespace consistent with other fsl-mc source files. > -delete extraneous tabs > -align start of function arguments properly > -for structs and function definitions,

Re: [PATCH] Staging:wlan-ng:hfa384x: fixed 80 character line limit coding style issue

On Fri, Oct 21, 2016 at 06:12:32PM +0530, Nadim Almas wrote: > Fixed coding style issue > > Signed-off-by: Nadim Almas > --- > drivers/staging/wlan-ng/hfa384x.h | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 00/14] staging: fsl-mc: cleanup and uprev to MC v10.x

On Mon, Oct 17, 2016 at 01:42:09PM -0500, Stuart Yoder wrote: > This patch does miscellaneous minor cleanup and uprevs the supported > MC firmware version to 10.x. > > I believe with this series the TODO items on our list are complete, > with the exception of "Add at least one device driver for a

Re: [PATCH 02/37] staging:r8188eu: remove device assignment after netdev_alloc_skb call

On Thu, Oct 20, 2016 at 07:16:20PM +0700, Ivan Safonov wrote: > Andy, > thank you for reviewing patches and tips. Please redo this series based on these responses and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 14/14] staging: fsl-mc: uprev binary interface to match MC v10.x

On Mon, Oct 17, 2016 at 01:43:58PM -0500, Stuart Yoder wrote: > From: Ioana Ciornei > > DPAA2 will not support MC firmware versions prior to MC v10.x. > Update the MC interface code and drivers to reflect this. >-update the object .h files and code that builds commands

Re: [PATCH 11/14] staging: fsl-mc: message cleanup

On Mon, Oct 17, 2016 at 01:43:39PM -0500, Stuart Yoder wrote: > Cleanup and clarify messages > -use "fsl-mc" prefix for all messages that don't come from dev_* >functions Nope, please use the proper pr_fmt() #define at the top of the file, that way you don't have to put the string into all

Re: [PATCH 2/2] staging: ks7010: fix coding style

On Mon, Oct 24, 2016 at 09:50:42PM +0800, Jiong Du wrote: > Fixes all the checkpath errors/warnings for michael_mic.c: > space required before the open brace > no space before tabs > line over 80 characters > space required before the open brace '{' > space required after that

Re: [PATCH] Staging:board:board: fix Block comments should align the * on each line

On Mon, Oct 24, 2016 at 09:18:04PM +0530, Nadim Almas wrote: > Block comments should align the * on each line as reported by checkpatch.pl > > Signed-off-by: Nadim Almas > --- > > drivers/staging/dgnc/dgnc_tty.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH v2] Staging:dgnc:dgnc_tty: fix Block comments should align the * on each line

Block comments should align the * on each line as reported by checkpatch.pl Signed-off-by: Nadim Almas --- Changes in v2: - Made subject better drivers/staging/dgnc/dgnc_tty.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 13/37] staging:r8188eu: remove debug messages after memory allocation failed

On Wed, Oct 19, 2016 at 10:07:41PM +0700, Ivan Safonov wrote: > These messages are redundant. > Also break rtw_usb_if1_init function if HalData allocation failed. > > Signed-off-by: Ivan Safonov Since you're redoing this anyway, please split this one into two patches. We

Re: [PATCH 05/14] staging: fsl-mc: update MAINTAINERS

On Mon, Oct 17, 2016 at 01:42:47PM -0500, Stuart Yoder wrote: > -German has moved on to other things and wished to be > removed as a maintainer > -cleanup the driver description to use the proper name > of the driver (i.e. the fsl-mc bus driver) and remove incorrect > references to Freescale >

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote: > On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote: > > mzo...@crowfest.net writes: > > > > >  */ > > >   > > >  static int > > >  create_pagelist(char __user *buf, size_t count, unsigned short > > > type, > > > - struct task_struct

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote: > mzo...@crowfest.net writes: > > >  */ > >   > >  static int > >  create_pagelist(char __user *buf, size_t count, unsigned short > > type, > > - struct task_struct *task, PAGELIST_T ** ppagelist) > > + struct task_struct *task,

[PATCH 4/5] staging: ks7010: split long line

Fixes checkpatch warning: line over 80 characters Signed-off-by: Jiong Du --- drivers/staging/ks7010/michael_mic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index

[PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"

This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad. This is necessary to detect paz00 (ac100) touchpad properly as one speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't work as the touchpad is detected as an ImPS/2 mouse instead. Commit

Re: [PATCH] Revert "staging: nvec: ps2: change serio type to passthrough"

Hi Paul, Greg, Am Dienstag, 25. Oktober 2016, 15:10:55 CEST schrieb Paul Fertser: > This reverts commit 36b30d6138f4677514aca35ab76c20c1604baaad. > > This is necessary to detect paz00 (ac100) touchpad properly as one > speaking ETPS/2 protocol. Without it X.org's synaptics driver doesn't > work

[PATCH 5/5] staging: ks7010: add a blank line after declarations

Fixes checkpatch warning: Missing a blank line after declarations Signed-off-by: Jiong Du --- drivers/staging/ks7010/michael_mic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index

[PATCH 3/5] staging: ks7010: remove space before tab

Fixes checkpatch warning: space before tabs Signed-off-by: Jiong Du --- drivers/staging/ks7010/michael_mic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index

[PATCH 2/5] staging: ks7010: fix complex macro error

Fixes checkpatch error: Macros with complex values should be enclosed in parentheses Signed-off-by: Jiong Du --- drivers/staging/ks7010/michael_mic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/michael_mic.c

[PATCH 1/5] staging: ks7010: fix spacing errors

Fixes checkpatch errors: spacing errors Signed-off-by: Jiong Du --- drivers/staging/ks7010/michael_mic.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.c b/drivers/staging/ks7010/michael_mic.c index

[PATCH] staging: iio: cdc/ad7746: fix missing return value

As found by "gcc -Wmaybe-uninitialized", the latest change to the driver lacked an initalization for the return code in one of the added cases: drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’: drivers/staging/iio/cdc/ad7746.c:655:2: error: ‘ret’ may be used uninitialized in this

Re: [PATCH] staging: iio: cdc/ad7746: fix missing return value

On 25/10/16 16:56, Arnd Bergmann wrote: > As found by "gcc -Wmaybe-uninitialized", the latest change to the > driver lacked an initalization for the return code in one of the > added cases: > > drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’: >

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

Michael Zoran writes: > On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote: >> On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote: >> > mzo...@crowfest.net writes: >> > >> > >  */ >> > >   >> > >  static int >> > >  create_pagelist(char __user *buf, size_t count,

[PATCH 0/3] staging: most: fix driver issues

This patch set is needed to fix up issues of the USB module and the networking module. Andrey Shvetsov (3): staging: most: aim-networking: keep channels closed if ndo_open fails staging: most: hdm-usb: do h/w specific synchronization at configuration time staging: most: hdm-usb:

RE: [PATCH 00/14] staging: fsl-mc: cleanup and uprev to MC v10.x

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, October 25, 2016 2:50 AM > To: Stuart Yoder > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org; > ag...@suse.de;

Re: [PATCH 2/2] staging: vc04_services: Replace dmac_map_area with dmac_map_sg

On Tue, 2016-10-25 at 09:16 -0700, Eric Anholt wrote: > Michael Zoran writes: > > > On Tue, 2016-10-25 at 08:00 -0700, Michael Zoran wrote: > > > On Mon, 2016-10-24 at 10:31 -0700, Eric Anholt wrote: > > > > mzo...@crowfest.net writes: > > > > > > > > >  */ > > > > >   > >

[PATCH 1/3] staging: most: aim-networking: keep channels closed if ndo_open fails

From: Andrey Shvetsov This patch stops all started channels whenever the function most_nd_open returns an error. Additionally, it renames variable wait_res to ret for the consistency. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm

[PATCH 3/3] staging: most: hdm-usb: introduce synchronization function

From: Andrey Shvetsov This patch introduces the function start_sync_ep() and relocates the triggers for synchronization to this function. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

[PATCH 2/3] staging: most: hdm-usb: do h/w specific synchronization at configuration time

From: Andrey Shvetsov This patch puts the synchronization procedure trigger for asynchronous channels into the function hdm_configure_channel. Likewise, it removes triggering of hardware specific synchronization for other channel types from the probe function as it is not

Re: [PATCH 1/2] staging: lustre: replace uses of class_devno_max by MAX_OBD_DEVICES

On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote: > On Oct 17, 2016, at 15:46, Aya Mahfouz wrote: > > > > class_devno_max is an inline function that returns > > MAX_OBD_DEVICES. Replace all calls to the function > > by MAX_OBD_DEVICES. > > Thanks

Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

On 10/25/2016 06:57 PM, Jonathan Cameron wrote: > On 24/10/16 16:22, Arnd Bergmann wrote: >> The ad5933_i2c_read function returns an error code to indicate >> whether it could read data or not. However ad5933_work() ignores >> this return code and just accesses the data unconditionally, >> which

Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

On 25/10/16 18:00, Lars-Peter Clausen wrote: > On 10/25/2016 06:57 PM, Jonathan Cameron wrote: >> On 24/10/16 16:22, Arnd Bergmann wrote: >>> The ad5933_i2c_read function returns an error code to indicate >>> whether it could read data or not. However ad5933_work() ignores >>> this return code and

Re: [PATCH] staging: rtl8712: Free memory and return failure when kmalloc fails

Hi Greg, On Tue, Oct 25, 2016 at 2:33 PM, Greg KH wrote: > On Thu, Oct 20, 2016 at 12:29:33PM +0530, Souptick Joarder wrote: >> This patch is added to free memory and return failure when kmalloc fails > > I'm sorry, but I can not parse that sentance. Can you

Re: [PATCH] [v2] staging: iio: ad5933: avoid uninitialized variable in error case

On 24/10/16 16:22, Arnd Bergmann wrote: > The ad5933_i2c_read function returns an error code to indicate > whether it could read data or not. However ad5933_work() ignores > this return code and just accesses the data unconditionally, > which gets detected by gcc as a possible bug: > >

[PATCH] staging: iio: cdc: ad7746: set ret on IIO_VOLTAGE case

From: Colin Ian King For a IIO_VOLTAGE case, ret is not being set causing an uninitialized value being returned by ad7746_read_raw. Fix this by setting ret to IIO_VAL_INT for this specific case. Signed-off-by: Colin Ian King ---

Re: [PATCH] staging: iio: cdc: ad7746: set ret on IIO_VOLTAGE case

On 10/25/2016 08:44 PM, Colin King wrote: > From: Colin Ian King > > For a IIO_VOLTAGE case, ret is not being set causing an > uninitialized value being returned by ad7746_read_raw. Fix > this by setting ret to IIO_VAL_INT for this specific case. > > Signed-off-by:

Re: [PATCH] staging: rtl8712: Free memory and return failure when kmalloc fails

On Tue, Oct 25, 2016 at 10:06:48PM +0530, Souptick Joarder wrote: > Hi Greg, > > > On Tue, Oct 25, 2016 at 2:33 PM, Greg KH wrote: > > On Thu, Oct 20, 2016 at 12:29:33PM +0530, Souptick Joarder wrote: > >> This patch is added to free memory and return failure when

Re: [PATCH 00/14] staging: fsl-mc: cleanup and uprev to MC v10.x

On Tue, Oct 25, 2016 at 03:43:56PM +, Stuart Yoder wrote: > > > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, October 25, 2016 2:50 AM > > To: Stuart Yoder > > Cc: German Rivera ;