On Sun, Jun 18, 2017 at 04:27:42PM +0300, Andy Shevchenko wrote:
> This doesn't have actual parameter name.
> Btw, I would drop dev_ suffix completely from parameter (you have it
> in function name).
Good call, thanks.
> > + * Locking: this acquires tty_mutex
>
> ...and releases.
>
> Perhap
On Sun, Jun 18, 2017 at 09:58:27AM +0100, Okash Khawaja wrote:
> +int ser_to_dev(int ser, dev_t *dev_no)
> +{
> + if (ser < 0 || ser > (255 - 64)) {
> +pr_err("speakup: Invalid ser param. \
> + Must be between 0 and 191 inclusive.\n");
I pointed out
On Sat, Jun 17, 2017 at 02:56:48PM +1200, Derek Robson wrote:
> Fix checkpatch.pl warnings of the form "function definition argument
> 'foo' should also have an identifier name" in header files.
>
> Signed-off-by: Derek Robson
>
> V1 and V2 had vague subject line
> ---
The subject is *still* to
From: Pan Li
Convertn __le to cpu type when access pd_header count.
Signed-off-by: Pan Li
---
drivers/staging/typec/tcpci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index df72d8b..2adb543 100644
--- a/driv
From: Pan Li
Clean endianness of pd_message header, add tcpci_read16_le and
tcpci_write16_le for header read and write.
*** BLURB HERE ***
Pan Li (3):
staging: typec: Replace pd_header_cnt with pd_header_cnt_le
staging: typec: add tcpci_read16_le.
staging: typec: add tcpci_write16_le.
d
From: Pan Li
Add tcpci_read16_le for pd_message header type __le16.
Signed-off-by: Pan Li
---
drivers/staging/typec/tcpci.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 2adb543..8da4a38
From: Pan Li
Add tcpci_write16_le for pd_message header type __le16.
Signed-off-by: Pan Li
---
drivers/staging/typec/tcpci.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
index 8da4a38..5c3d91b 10064
On 06/19/2017 03:11 AM, ? ? wrote:
From: Pan Li
Add tcpci_read16_le for pd_message header type __le16.
> Signed-off-by: Pan Li
---
drivers/staging/typec/tcpci.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/typec/tcpci.c b/drivers/stagi
On 05/24/2017 05:51 PM, Dmitry Safonov wrote:
binder_mmap() protected proc->buffer from concurrent changes.
It was introduced with commit bd1eff9741af ("Staging: android: binder:
Fix crashes when sharing a binder file between processes").
The commit fixed such races alike:
task1
=
fd = open
> -Original Message-
> From: Derek Robson [mailto:robso...@gmail.com]
> Sent: Friday, June 16, 2017 11:13 PM
> To: Kershner, David A ;
> gre...@linuxfoundation.org; Sell, Timothy C ;
> Binder, David Anthony ; Wadgaonkar, Sameer
> Laxmikant ;
> marcos.souza@gmail.com; robso...@gmail.com
This patch removes typedefs from enum _logical_chip_type_t and enum
_clock_type_t and rename them to logical_chip_type_t and clock_type_t
respectively.
Fix checkpatch warning:
WARNING: do not add new typedefs
Signed-off-by: Simran Singhal
---
drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
dri
The previous patch which updated screen resolution was tested under
wrong environment. sm750 driver does not support 24bpp. It only
supports 8bpp, 16bpp and 32bpp.
Lets update the default screen resolution to use 32bpp for a better
screen performance.
Fixes: ac669251087d ("staging: sm750fb: change
From: Teddy Wang
If vesafb is enabled in the config then /dev/fb0 is created by vesa
and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to
effectively work with xorg.
So if it has been alloted fb1, then try to remove the other fb0.
Signed-off-by: Teddy Wang
Signed-off-by: Sudip
On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee
wrote:
> +#ifdef CONFIG_X86
> + primary = pdev->resource[PCI_ROM_RESOURCE].flags &
> + IORESOURCE_ROM_SHADOW;
> +#endif
Why do we need #ifdef?
In any case you may introduce a temporary variable to hav
[+cc Christoph]
On Wed, May 24, 2017 at 01:39:15PM -0700, Haiyang Zhang wrote:
> From: Haiyang Zhang
>
> This patch uses the lower 16 bits of the serial number as PCI
> domain, otherwise some drivers may not be able to handle it.
>
> Besides Nvidia drivers, we also found X.org, and DPDK handle
FYI, I've also got another driver in progress that will need domains
assigned outside the ACPI range, so it's not just limited to VMD.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-d
Okash Khawaja, on sam. 17 juin 2017 22:32:55 +0100, wrote:
> This patch adds definition of tty_open_by_driver when CONFIG_TTY is not
> defined. This was supposed to have been included in commit
> 12e84c71b7d4ee38d51377fd494ac748ee4e6912 ("tty: export
> tty_open_by_driver"). The patch follows conven
On Mon, Jun 19, 2017 at 03:28:19PM +, Kershner, David A wrote:
>
> > -Original Message-
> > From: Derek Robson [mailto:robso...@gmail.com]
> > Sent: Friday, June 16, 2017 11:13 PM
> > To: Kershner, David A ;
> > gre...@linuxfoundation.org; Sell, Timothy C ;
> > Binder, David Anthony ;
From: Jhih-Ming Hunag
In this series patches, I fix all of the coding style error in
driver/staging/ccree/ssi_aead.c from 54 errors to 0 error.
The first patch fixed 'ERROR: space required after that'.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 22 +++--
From: Jhih-Ming Hunag
Fixed 'ERROR: spaces required around that'
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 5bc3a5
From: Jhih-Ming Hunag
Fixed 'ERROR: space required before the open brace'.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 0f9
From: Jhih-Ming Hunag
Fixed 'ERROR: that open brace { should be on the previous line'.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead
From: Jhih-Ming Hunag
Fixed "ERROR: space prohibited after that open parenthesis '('".
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccr
From: Jhih-Ming Hunag
Fixed "ERROR: space prohibited before that close parenthesis ')'".
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/d
From: Jhih-Ming Hunag
Fixed "ERROR: space prohibited before that ','".
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index 6d2c0
From: Jhih-Ming Hunag
Fixed "ERROR: open brace '{' following function declarations go on the next
line".
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/sta
From: Jhih-Ming Hunag
Fixied "ERROR: space prohibited before open square bracket '['".
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
ind
From: Jhih-Ming Hunag
Fixed 'ERROR: "foo* bar" should be "foo *bar"'.
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index c148d81..c70e4
From: Jhih-Ming Hunag
Fixied "ERROR: else should follow close brace '}'".
Signed-off-by: Jhih-Ming Hunag
---
drivers/staging/ccree/ssi_aead.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index d697244.
This patch assigns (true/false) to boolean EDCCA_State instead of (1/0).
And, there is no need of comparing EDCCA_State explicitly with constant
1.
Signed-off-by: simran singhal
---
drivers/staging/rtl8723bs/hal/odm_DIG.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
This patch adds functionality to validate and convert either a device
name or 'ser' memmber of synth into dev_t. Subsequent patch in this set
will call it to convert user-specified device into device number. For
device name, this patch does some basic sanity checks on the string
passed in. It curre
The function converts strings like ttyS0 and ttyUSB0 to dev_t like
(4, 64) and (188, 0). It does this by scanning tty_drivers list for
corresponding device name and index. If the driver is not registered,
this function returns -ENODEV. It also acquires tty_mutex.
Signed-off-by: Okash Khawaja
---
Hi,
I have updated the patches based on feedback. For patch 1, In favour of
consistency, I've updated the code which extracts trailing digits so
that it is like similar code in tty_find_polling_driver. Also fixed
checkpatch warnings.
Here's summary of the patches
Patch 1 adds functionality to co
This patch introduces new module parameter, dev, which takes a string
representing the device that the external synth is connected to, e.g.
ttyS0, ttyUSB0 etc. This is then used to communicate with the synth.
That way, speakup can support more than ttyS*. As of this patch, it
only supports ttyS*, t
34 matches
Mail list logo
