Re: [PATCH 6/8] staging: wilc1000: fix line over 80 char in wilc_wlan_handle_rxq()

On Mon, Feb 26, 2018 at 10:02:00PM +0530, Ajay Singh wrote: > Fix 'line over 80 character' issue found by checkpatch.pl script. > Refactor wilc_wlan_handle_rxq() code to remove the checkpatch.pl > warnings. > > Signed-off-by: Ajay Singh > --- >

Re: [PATCH 7/8] staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set()

On Mon, Feb 26, 2018 at 10:02:01PM +0530, Ajay Singh wrote: > Fix 'line over 80 character' issue found by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [PATCH 3/3] media: imx: Don't initialize vars that won't be used

On Mon, 2018-02-26 at 08:40 -0500, Mauro Carvalho Chehab wrote: > As reported by gcc: > > + drivers/staging/media/imx/imx-media-csi.c: warning: variable 'input_fi' > set but not used [-Wunused-but-set-variable]: => 671:33 > + drivers/staging/media/imx/imx-media-csi.c: warning: variable

Re: [PATCH 7/8] staging: wilc1000: fix line over 80 char in wilc_wlan_cfg_set()

On Mon, Feb 26, 2018 at 10:02:01PM +0530, Ajay Singh wrote: > Fix 'line over 80 character' issue found by checkpatch.pl script. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [PATCH 8/8] staging: wilc1000: fix open parenthesis mismatch issue in wilc_wlan_cfg_set()

The first 5 patches are good, but the last 3 are not OK. Normally "tmp" is used as an iterator pointer or something along those lines. For example, here is a good use of "tmp". tmp = left; left = right; right = tmp; In this example, you want to store a pointer

Re: [PATCH 8/8] staging: wilc1000: fix open parenthesis mismatch issue in wilc_wlan_cfg_set()

Hi Dan, On Tue, 27 Feb 2018 12:41:40 +0300 Dan Carpenter wrote: > The first 5 patches are good, but the last 3 are not OK. Thanks for your review comments. I will resubmit the patch series by only including first 5 patches. I will recheck the last 3 patches and

Re: [PATCH 8/8] staging: wilc1000: fix open parenthesis mismatch issue in wilc_wlan_cfg_set()

On Tue, Feb 27, 2018 at 06:53:40PM +0530, Ajay Singh wrote: > Hi Dan, > > On Tue, 27 Feb 2018 12:41:40 +0300 > Dan Carpenter wrote: > > > The first 5 patches are good, but the last 3 are not OK. > > Thanks for your review comments. > I will resubmit the patch series

Re: [PATCH v2] Staging: bcm2048: Fix function argument alignment in radio-bcm2048.c.

On Tue, Feb 27, 2018 at 08:32:30AM +0100, Hans Verkuil wrote: > On 02/27/2018 02:53 AM, Quytelda Kahja wrote: > > Hans, > > > > Thank you very much for your input on the patch; however this patch > > has already been applied to the staging tree. Additionally: > > I have no record of this being

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

On 02/26/2018 06:48 PM, Laura Abbott wrote: > On 02/26/2018 09:07 AM, Shuah Khan wrote: >> On 02/19/2018 11:33 AM, Daniel Vetter wrote: >>> On Mon, Feb 19, 2018 at 10:18:21AM -0800, Laura Abbott wrote: On 02/19/2018 07:31 AM, Daniel Vetter wrote: > On Thu, Feb 15, 2018 at 05:24:45PM

[RFC PATCH] staging: fsl-mc/dpio: qbman_pull_desc_set_token() can be static

Fixes: 1628e2e4dc76 ("staging: fsl-mc/dpio: allow the driver to compile multi-arch") Signed-off-by: Fengguang Wu --- qbman-portal.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c

Re: [PATCH 4/4] staging: fsl-dpaa2/eth: allow the driver to compile multi-arch

Hi Ioana, I love your patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.16-rc3 next-20180227] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

[PATCH] staging: android: ashmem: Fix possible deadlock in ashmem_ioctl

ashmem_mutex may create a chain of dependencies like: CPU0CPU1 mmap syscall ioctl syscall -> mmap_sem (acquired) -> ashmem_ioctl -> ashmem_mmap-> ashmem_mutex (acquired) ->

Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

On 02/26/2018 10:56 AM, Dan Carpenter wrote: On Fri, Feb 23, 2018 at 05:57:42PM +0300, Ivan Safonov wrote: Custom AES decrypt implementation replaced with lib80211 library. Signed-off-by: Ivan Safonov The new code looks like original RTL code (really bad) so I'm

Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

Hm... Sorry. I was looking at the wrong code. I was looking at aes_decipher() instead of rtw_aes_decrypt(). The aes_decipher() was acceptable style (although, it's of course good that you deleted it). rtw_aes_decrypt() was always really really awful. That's fine then. Sorry again. regards,

Prize Notice!

Microsoft Iberica S.L Lottery Intl. Program FOREIGN SERVICE SECTION BARCELONA. REFERENCE NUMBER:BYQCX7ZPO63 BATCH NUMBER: 2018/HZK/3NW/127 OFFICIAL WINNING NOTIFICATION. We are pleased to inform you of the released results of the Microsoft Iberica S.L Sweepstakes Promotion in conjunction with