[PATCH] staging: pi433: use help in Kconfig description

2018-04-15 Thread Valentin Vidic
Fixes checkpatch warning: WARNING: prefer 'help' over '---help---' for new help texts Signed-off-by: Valentin Vidic --- drivers/staging/pi433/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/Kconfig b/drivers/staging/pi433/Kconfig index 87c2ee1

[PATCH] staging: vboxvideo: Fix line size exceeding 80 columns.

2018-04-15 Thread Daniel Junho
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters + vbva = (void __force *)vbox->vbva_buffers + i * VBVA_MIN_BUFFER_SIZE; Signed-off-by: Daniel Junho --- drivers/staging/vboxvideo/vbox_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 07/25] staging: lustre: libcfs: NUMA support

2018-04-15 Thread James Simmons
From: Amir Shehata This patch adds NUMA node support. NUMA node information is stored in the CPT table. A NUMA node mask is maintained for the entire table as well as for each CPT to track the NUMA nodes related to each of the CPTs. Add new function cfs_cpt_of_node() which returns the CPT of a pa

[PATCH 19/25] staging: lustre: libcfs: update debug messages

2018-04-15 Thread James Simmons
From: Dmitry Eremin For cfs_cpt_bind() change the CERROR to CDEBUG. Make the debug message in cfs_cpt_table_create_pattern() more understandable. Report rc value for when cfs_cpt_create_table() fails. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed

[PATCH 18/25] staging: lustre: libcfs: clear up failure patch in cfs_cpt_*_print

2018-04-15 Thread James Simmons
From: Dmitry Eremin Currently both cfs_cpt_table_print() and cfs_cpt_distance_print() handle the error path in a confusing way. Simplify it so it just returns E2BIG on failure instead of testing rc value before exiting. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/brow

[PATCH 25/25] staging: lustre: libcfs: merge UMP and SMP libcfs cpu header code

2018-04-15 Thread James Simmons
Currently we have two headers, linux-cpu.h that contains the SMP version and libcfs_cpu.h contains the UMP version. We can simplify the headers into a single header which handles both cases. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9859 Reviewed-on: https:/

[PATCH 00/25] staging: lustre: libcfs: SMP rework

2018-04-15 Thread James Simmons
Recently lustre support has been expanded to extreme machines with as many as a 1000+ cores. On the other end lustre also has been ported to platforms like ARM and KNL which have uniquie NUMA and core setup. For example some devices exist that have NUMA nodes with no cores. With these new platforms

[PATCH 04/25] staging: lustre: libcfs: replace MAX_NUMNODES with nr_node_ids

2018-04-15 Thread James Simmons
From: Amir Shehata Replace depricated MAX_NUMNODES with nr_node_ids. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- driver

[PATCH 16/25] staging: lustre: libcfs: rename cpumask_var_t variables to *_mask

2018-04-15 Thread James Simmons
From: Dmitry Eremin Because we handle both cpu mask as well as core identifiers it can easily be confused. To avoid this rename various cpumask_var_t to have appended *_mask to their names. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https:

[PATCH 08/25] staging: lustre: libcfs: add cpu distance handling

2018-04-15 Thread James Simmons
From: Amir Shehata Add functionality to calculate the distance between two CPTs. Expose those distance in debugfs so people deploying a setup can debug what is being created for CPTs. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review

[PATCH 01/25] staging: lustre: libcfs: remove useless CPU partition code

2018-04-15 Thread James Simmons
From: Dmitry Eremin * remove scratch buffer and mutex which guard it. * remove global cpumask and spinlock which guard it. * remove cpt_version for checking CPUs state change during setup because of just disable CPUs state change during setup. * remove whole global struct cfs_cpt_data cpt_data.

[PATCH 24/25] staging: lustre: libcfs: change CPT estimate algorithm

2018-04-15 Thread James Simmons
From: Dmitry Eremin The main idea to have more CPU partitions is based on KNL experience. When a thread submit IO for network communication one of threads from current CPT is used for network stack. Whith high parallelization many threads become involved in network submission but having less CPU

[PATCH 14/25] staging: lustre: libcfs: rename i to node for cfs_cpt_set_nodemask

2018-04-15 Thread James Simmons
From: Dmitry Eremin Rename variable i to node to make code easier to understand. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin

[PATCH 10/25] staging: lustre: libcfs: provide debugfs files for distance handling

2018-04-15 Thread James Simmons
From: Amir Shehata On systems with large number of NUMA nodes and cores it is easy to incorrectly configure their use with Lustre. Provide debugfs files which can help track down any issues. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http:/

[PATCH 09/25] staging: lustre: libcfs: use distance in cpu and node handling

2018-04-15 Thread James Simmons
From: Amir Shehata Take into consideration the location of NUMA nodes and core when calling cfs_cpt_[un]set_cpu() and cfs_cpt_[un]set_node(). This enables functioning on platforms with 100s of cores and NUMA nodes. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-

[PATCH 17/25] staging: lustre: libcfs: rename goto label in cfs_cpt_table_print

2018-04-15 Thread James Simmons
From: Dmitry Eremin Change goto label out to err. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin Signed-off-by: James Simmons

[PATCH 12/25] staging: lustre: libcfs: fix libcfs_cpu coding style

2018-04-15 Thread James Simmons
From: Dmitry Eremin This patch bring the lustre CPT code into alignment with the Linux kernel coding style. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23304 Reviewed-by: James Simmons Reviewed-by: Doug Ouchare

[PATCH 05/25] staging: lustre: libcfs: remove excess space

2018-04-15 Thread James Simmons
From: Amir Shehata The function cfs_cpt_table_print() was adding two spaces to the string buffer. Just add it once. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Ouch

[PATCH 23/25] staging: lustre: libcfs: rework CPU pattern parsing code

2018-04-15 Thread James Simmons
From: Dmitry Eremin Currently the module param string for CPU pattern can be modified which is wrong. Rewrite CPU pattern parsing code to avoid the passed buffer from being changed. This change also enables us to add real errors propogation to the caller functions. Signed-off-by: Dmitry Eremin

[PATCH 13/25] staging: lustre: libcfs: use int type for CPT identification.

2018-04-15 Thread James Simmons
From: Dmitry Eremin Use int type for CPT identification to match the linux kernel CPU identification. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23304 Reviewed-by: James Simmons Reviewed-by: Doug Oucharek Rev

[PATCH 21/25] staging: lustre: libcfs: report NUMA node instead of just node

2018-04-15 Thread James Simmons
From: Dmitry Eremin Reporting "HW nodes" is too generic. It really is reporting "HW NUMA nodes". Update the debug message. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23306 Reviewed-by: James Simmons Reviewed-b

[PATCH 11/25] staging: lustre: libcfs: invert error handling for cfs_cpt_table_print

2018-04-15 Thread James Simmons
From: Amir Shehata Instead of setting rc to -EFBIG for several cases in the loop lets initialize rc to -EFBIG and just break out of the loop in case of failure. Just set rc to zero once we successfully finish the loop. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse

[PATCH 02/25] staging: lustre: libcfs: rename variable i to cpu

2018-04-15 Thread James Simmons
From: Dmitry Eremin Change the name of the variable i used for for_each_cpu() to cpu for code readability. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23303 Reviewed-by: James Simmons Reviewed-by: Doug Oucharek

[PATCH 03/25] staging: lustre: libcfs: implement cfs_cpt_cpumask for UMP case

2018-04-15 Thread James Simmons
From: Amir Shehata The function cfs_cpt_cpumask() exist for SMP systems but when CONFIG_SMP is disabled it only returns NULL. Fill in this missing function. Also properly initialize ctb_mask for the UMP case. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 R

[PATCH 20/25] staging: lustre: libcfs: make tolerant to offline CPUs and empty NUMA nodes

2018-04-15 Thread James Simmons
From: Dmitry Eremin Rework CPU partition code in the way of make it more tolerant to offline CPUs and empty nodes. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James

[PATCH 22/25] staging: lustre: libcfs: update debug messages in CPT code

2018-04-15 Thread James Simmons
From: Dmitry Eremin Update the debug messages for the CPT table creation code. Place the passed in string in quotes to make it clear what it is. Captialize cpu in the debug strings. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review

[PATCH 15/25] staging: lustre: libcfs: rename i to cpu for cfs_cpt_bind

2018-04-15 Thread James Simmons
From: Dmitry Eremin Rename variable i to cpu to make code easier to understand. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8703 Reviewed-on: https://review.whamcloud.com/23222 Reviewed-by: Amir Shehata Reviewed-by: James Simmons Reviewed-by: Oleg Drokin

[PATCH 06/25] staging: lustre: libcfs: replace num_possible_cpus() with nr_cpu_ids

2018-04-15 Thread James Simmons
From: Amir Shehata Move from num_possible_cpus() to nr_cpu_ids. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7734 Reviewed-on: http://review.whamcloud.com/18916 Reviewed-by: Olaf Weber Reviewed-by: Doug Oucharek Signed-off-by: James Simmons --- drivers/sta

[PATCH 18/22] staging: lustre: llite: style changes in xattr.c

2018-04-15 Thread James Simmons
Small style changes to match more the kernel code standard and it make it more readable. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed-by: Sebast

[PATCH 21/22] staging: lustre: llite: correct removexattr detection

2018-04-15 Thread James Simmons
In ll_xattr_set_common() detect the removexattr() case correctly by testing for a NULL value as well as XATTR_REPLACE. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10787 Reviewed-on: https://review.whamcloud.com/ Reviewed-by: Dmitry Eremin Reviewed-by: James

[PATCH 11/22] staging: lustre: llite: eat -EEXIST on setting trusted.lov

2018-04-15 Thread James Simmons
From: Bobi Jam Tools like rsync, tar, cp may copy and restore the xattrs on a file. The client previously ignored the setting of trusted.lov/lustre.lov if the layout had already been specified, to avoid causing these tools to fail for no reason. For PFL files we still need to silently eat -EEXIS

[PATCH 10/22] staging: lustre: llite: return from ll_adjust_lum() if lump is NULL

2018-04-15 Thread James Simmons
From: Bobi Jam No need to check several times if lump is NULL. Just test once and return 0 if NULL. Signed-off-by: Bobi Jam Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://review.whamcloud.com/27126 Reviewed-by: Dmitry Eremin Reviewed-by: Niu Yawei Reviewed-by: J

[PATCH 19/22] staging: lustre: llite: add support set_acl method in inode operations

2018-04-15 Thread James Simmons
From: Dmitry Eremin Linux kernel v3.14 adds set_acl method to inode operations. This patch adds support to Lustre for proper acl management. Signed-off-by: Dmitry Eremin Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamclou

[PATCH 09/22] staging: lustre: llite: break up ll_setstripe_ea function

2018-04-15 Thread James Simmons
From: Bobi Jam Place all the handling of information of trusted.lov that is not stripe related into the new function ll_adjust_lum(). Now ll_setstripe_ea() only handles striping information. Signed-off-by: Bobi Jam Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9484 Reviewed-on: https://re

[PATCH 06/22] staging: lustre: llite: Remove filtering of seclabel xattr

2018-04-15 Thread James Simmons
From: Robin Humble The security.capability xattr is used to implement File Capabilities in recent Linux versions. Capabilities are a fine grained approach to granting executables elevated privileges. eg. /bin/ping can have capabilities cap_net_admin, cap_net_raw+ep instead of being setuid root.

[PATCH 13/22] staging: lustre: llite: remove newline in fullname strings

2018-04-15 Thread James Simmons
In creating the full name of a xattr a new line was added that was seen by the remote MDS server which confused it. Remove the newline. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin

[PATCH 00/22] staging: lustre: llite: fix xattr handling

2018-04-15 Thread James Simmons
From: James Simmons Lustre utilities and user land APIs heavly depend on special xattr handling. Sadly much of the xattr handling for lustre client has been broken for awhile. This is all the fixes needed to make xattr handling work properly with the latest kernels. Bobi Jam (3): staging: lust

[PATCH 04/22] staging: lustre: ldlm: xattr locks are lost on mdt

2018-04-15 Thread James Simmons
From: Vitaly Fertman On the server side mdt_intent_getxattr() can return EFAULT if a buffer cannot be found, it is returned after lock_replace, where a new lock is installed into lockp. An error forces ldlm_lock_enqueue() to destroy the original lock, but ldlm_handle_enqueue0() drops the referenc

[PATCH 12/22] staging: lustre: llite: fix invalid size test in ll_setstripe_ea()

2018-04-15 Thread James Simmons
The size check at the start of ll_setstripe_ea() is only valid for a directory. Move that check to the section of code handling the S_ISDIR case. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmit

[PATCH 02/22] staging: lustre: obd: create it_has_reply_body()

2018-04-15 Thread James Simmons
From: Vitaly Fertman The lookup_intent it_op fields in many cases will be compared to the settings of IT_OPEN | IT_UNLINK | IT_LOOKUP | IT_GETATTR. Create a simple inline function for this common case. Signed-off-by: Vitaly Fertman Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7433 Seagat

[PATCH 22/22] staging: lustre: llite: remove unused parameters from md_{get, set}xattr()

2018-04-15 Thread James Simmons
From: "John L. Hammond" md_getxattr() and md_setxattr() each have several unused parameters. Remove them and improve the naming or remaining parameters. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10792 Reviewed-on: https://review.whamcloud.com/ Reviewed-b

[PATCH 17/22] staging: lustre: llite: cleanup xattr code comments

2018-04-15 Thread James Simmons
Add proper punctuation to the comments. Change buf_size to size for comment in ll_listxattr() since buf_size doesn't exit which will confuse someone reading the code. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27

[PATCH 07/22] staging: lustre: llite: refactor lustre.lov xattr handling

2018-04-15 Thread James Simmons
From: Niu Yawei The function ll_xattr_set() contains special code to handle the lustre specific xattr lustre.lov. Move all this code to a new function ll_setstripe_ea(). Signed-off-by: Bobi Jam Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8998 Reviewed-on: https

[PATCH 03/22] staging: lustre: obd: change debug reporting in lmv_enqueue()

2018-04-15 Thread James Simmons
From: Vitaly Fertman Remove LL_IT2STR(it) from debug macros in lmv_enqueue(). The removal makes it possible to simplify the md_enqueue() functions. Signed-off-by: Vitaly Fertman Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7433 Seagate-bug-id: MRP-3072 MRP-3137 Reviewed-on: http://review

[PATCH 01/22] staging: lustre: llite: initialize xattr->xe_namelen

2018-04-15 Thread James Simmons
When the allocation of xattr->xe_name was moved to kstrdup() setting xattr->xe_namelen was dropped. This field is used in several parts of the xattr cache code so it broke xattr handling. Initialize xattr->xe_namelen when allocating xattr->xe_name succeeds. Also change the debugging statement to re

[PATCH 20/22] staging: lustre: llite: use xattr_handler name for ACLs

2018-04-15 Thread James Simmons
From: "John L. Hammond" If struct xattr_handler has a name member then use it (rather than prefix) for the ACL xattrs. This avoids a bug where ACL operations failed for some kernels. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10785 Reviewed-on: https://re

[PATCH 16/22] staging: lustre: llite: use proper types in the xattr code

2018-04-15 Thread James Simmons
Convert __uXX types to uXX types since this is kernel code. The function ll_lov_user_md_size() returns ssize_t so change lum_size from int to ssize_t. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by:

[PATCH 15/22] staging: lustre: llite: cleanup posix acl xattr code

2018-04-15 Thread James Simmons
Having an extra ifdef makes the code harder to read. For the case of ll_xattr_get_common() we have a variable initialized at the start of the function but it is only used in XATTR_ACL_ACCESS_T code block. Lets move that variable to that location since its only used there and make the code look clea

[PATCH 14/22] staging: lustre: llite: record in stats attempted removal of lma/link xattr

2018-04-15 Thread James Simmons
Keep track of attempted deletions as well as changing of the lma/link xattrs. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183 Reviewed-on: https://review.whamcloud.com/27240 Reviewed-by: Dmitry Eremin Reviewed-by: Bob Glossman Reviewed-by: Sebastien Buisson

[PATCH 05/22] staging: lustre: llite: handle xattr cache refill race

2018-04-15 Thread James Simmons
From: "John L. Hammond" In ll_xattr_cache_refill() if the xattr cache was invalid (and no request was sent) then return -EAGAIN so that ll_getxattr_common() caller will fetch the xattr from the MDT. Signed-off-by: John L. Hammond Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10132 Reviewe

[PATCH 08/22] staging: lustre: llite: add simple comment about lustre.lov xattrs

2018-04-15 Thread James Simmons
From: Niu Yawei Simple comment added to ll_xattr_set. Signed-off-by: Bobi Jam Signed-off-by: Niu Yawei Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8998 Reviewed-on: https://review.whamcloud.com/24851 Reviewed-by: Andreas Dilger Reviewed-by: Lai Siyao Reviewed-by: Jinshan Xiong Signe