Re: [PATCH] staging: erofs: adds a space around '*'

2018-10-09 Thread DaeSeok Youn
2018년 10월 8일 (월) 오후 9:37, Gustavo A. R. Silva 님이 작성: > > Hi, > > On 10/8/18 1:45 PM, Daeseok Youn wrote: > > fix checkpatch.pl error: > > ERROR: need consistent spacing around '*' (ctx:WxV) > > + memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE); > > > > Signed-off-by: Daeseok Youn >

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-10-09 Thread Quentin Schulz
Hi Frieder, On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote: > Hi, > > On 27.09.2018 10:14, Maxime Ripard wrote: > > On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote: > > > On 26-09-18 16:44, Frieder Schrempf wrote: > > > > Hi, > > > > > > > > On Fri, Feb 09, 2018

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-09 Thread Michal Hocko
On Fri 05-10-18 13:40:05, Arun KS wrote: > When free pages are done with higher order, time spend on > coalescing pages by buddy allocator can be reduced. With > section size of 256MB, hot add latency of a single section > shows improvement from 50-60 ms to less than 1 ms, hence > improving the

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-09 Thread Arun KS
On 2018-10-09 14:59, Michal Hocko wrote: On Fri 05-10-18 13:40:05, Arun KS wrote: When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

2018-10-09 Thread Michal Hocko
On Tue 09-10-18 15:24:13, Arun KS wrote: > On 2018-10-09 14:59, Michal Hocko wrote: > > On Fri 05-10-18 13:40:05, Arun KS wrote: > > > When free pages are done with higher order, time spend on > > > coalescing pages by buddy allocator can be reduced. With > > > section size of 256MB, hot add

Re: [PATCH v5 2/2] mm/page_alloc: remove software prefetching in __free_pages_core

2018-10-09 Thread Michal Hocko
On Fri 05-10-18 13:40:06, Arun KS wrote: > They not only increase the code footprint, they actually make things > slower rather than faster. Remove them as contemporary hardware doesn't > need any hint. I agree with the change but it is much better to add some numbers whenever arguing about

Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

2018-10-09 Thread Marcelo Tosatti
On Mon, Oct 08, 2018 at 10:38:22AM -0700, Andy Lutomirski wrote: > On Mon, Oct 8, 2018 at 8:27 AM Marcelo Tosatti wrote: > > > > On Sat, Oct 06, 2018 at 03:28:05PM -0700, Andy Lutomirski wrote: > > > On Sat, Oct 6, 2018 at 1:29 PM Marcelo Tosatti > > > wrote: > > > > > > > > On Thu, Oct 04,

Re: [PATCH] STAGING/EMXX_UDC: Fixed all meaningful sparse errors.

2018-10-09 Thread Greg KH
On Sat, Oct 06, 2018 at 03:13:39AM -0400, Carmeli Tamir wrote: > Fixed all meaningful sparse errors: > 1. Added static to udc_controller > 2. Added mising __iomem modifier to handle p_regs > 3. Added missing le16_to_cpu > > Signed-off-by: Tamir Carmeli > --- > Hi, This is the friendly

[PATCH] staging: erofs: add the missing __init tags

2018-10-09 Thread Gao Xiang
Append __init to `erofs_init_inode_cache', `z_erofs_init_zip_subsystem' and move these declarations to internal.h. Signed-off-by: Gao Xiang --- drivers/staging/erofs/internal.h | 6 ++ drivers/staging/erofs/super.c | 13 + drivers/staging/erofs/unzip_vle.c | 2 +- 3 files

[PATCH 4/4] staging: rtl8188eu: remove whitespace - style

2018-10-09 Thread Michael Straube
Replace tabs with spaces and/or remove extra spaces where appropriate. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c

[PATCH 2/4] staging: rtl8188eu: add spaces around operators - style

2018-10-09 Thread Michael Straube
Add spaces around '*' and '/' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c

[PATCH 0/4] staging: rtl8188eu: cleanup style issues in xmit_linux.c

2018-10-09 Thread Michael Straube
This series clears most of the remaining style/checkpatch issues in the file os_dep/xmit_linux.c. Michael Straube (4): staging: rtl8188eu: use __func__ instead of hardcoded name - style staging: rtl8188eu: add spaces around operators - style staging: rtl8188eu: cleanup lines over 80

[PATCH 3/4] staging: rtl8188eu: cleanup lines over 80 characters - style

2018-10-09 Thread Michael Straube
Clear 'line over 80 characters' checkpatch warnings by adding appropriate line breaks and moving a comment. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH 1/4] staging: rtl8188eu: use __func__ instead of hardcoded name - style

2018-10-09 Thread Michael Straube
Use __func__ instead of hardcoded function name in rtw_xmit_entry(). Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/os_dep/xmit_linux.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] staging: emxx_udc: Remove unused device_desc declaration

2018-10-09 Thread Greg KH
On Fri, Oct 05, 2018 at 02:05:45PM -0700, Nick Desaulniers wrote: > On Wed, Oct 3, 2018 at 10:56 PM Nathan Chancellor > wrote: > > > > Clang warns: > > > > drivers/staging/emxx_udc/emxx_udc.c:1373:37: warning: variable > > 'device_desc' is not needed and will not be emitted > >

Re: [PATCH] staging: gasket: Fix sparse "incorrect type in assignment" warnings.

2018-10-09 Thread Greg Kroah-Hartman
On Thu, Oct 04, 2018 at 06:52:25PM +0100, Laurence Rochfort wrote: > Silence the below sparse warnings by casting betwen u8 __iomem *, and > void *. > > warning: incorrect type in assignment (different address spaces) >expected unsigned char [noderef] [usertype] *virt_base >got void

Re: [PATCH v4] staging: android: ion: Add per-heap counters

2018-10-09 Thread Greg KH
On Sun, Sep 30, 2018 at 06:24:52PM +0300, Alexey Skidanov wrote: > Heap statistics have been removed and currently even basics statistics > are missing. > > This patch creates per heap debugfs directory /sys/kernel/debug/ > and adds the following counters: > - the number of allocated buffers; > -

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-10-09 Thread Frieder Schrempf
Hi Quentin, On 09.10.2018 09:52, Quentin Schulz wrote: Hi Frieder, On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote: Hi, On 27.09.2018 10:14, Maxime Ripard wrote: On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote: On 26-09-18 16:44, Frieder Schrempf wrote: Hi,

Re: [PATCH v4 00/13] device-global identifiers and routes introduced

2018-10-09 Thread Greg Kroah-Hartman
On Wed, Oct 03, 2018 at 02:55:59PM -0600, Spencer E. Olson wrote: > This patch set is the second revision of a recent patch set of the same name. Thanks for sticking with this, all now applied. greg k-h ___ devel mailing list

Re: [PATCH 02/11] staging:rtl8192u: Removed commented out include - Style

2018-10-09 Thread Greg KH
On Sun, Oct 07, 2018 at 10:40:16PM +0100, John Whitmore wrote: > Remove commented out #include directive. > > Additionally shorted a block comment to clear the checkpatch issue > with line length. You really should only do one type of thing per patch, but I'll let this one go...

Re: [PATCH 06/11] staging:rtl8192u: Rewrite test for null - Style

2018-10-09 Thread Greg KH
On Sun, Oct 07, 2018 at 10:40:20PM +0100, John Whitmore wrote: > Rewrite a test for NULL to comply with the coding style and clear the > checkpatch issue. > > This is a coding style change which should not impact runtime > code execution. > > Signed-off-by: John Whitmore > --- >

[PATCH] staging: erofs: harden inode lookup for 32-bit platforms

2018-10-09 Thread Gao Xiang
This patch introduces inode hash function, test and set callbacks, and iget5_locked to find the right inode for 32-bit platforms. Reviewed-by: Chao Yu Signed-off-by: Gao Xiang --- The patch has been previewed in the linux-erofs mailing list, submit to the staging mailing list for linux-4.20.

[RESEND PATCH] staging: mt7621-pci: dt-bindings: add dt bindings for mt7621 pcie controller

2018-10-09 Thread Sergio Paracuellos
This commit adds pci device tree bindings for the Mt7621 pci controller. This is a temporal file included in staging driver directory and will be moved to its correct location when this driver gets out of staging. Cc: Rob Herring Signed-off-by: Sergio Paracuellos --- I resend this because I

Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

2018-10-09 Thread Andy Lutomirski
On Tue, Oct 9, 2018 at 8:28 AM Marcelo Tosatti wrote: > > On Mon, Oct 08, 2018 at 10:38:22AM -0700, Andy Lutomirski wrote: > > On Mon, Oct 8, 2018 at 8:27 AM Marcelo Tosatti wrote: > > I read the comment three more times and even dug through the git > > history. It seems like what you're

[PATCH v5] staging: android: ion: Add per-heap counters

2018-10-09 Thread Alexey Skidanov
Heap statistics have been removed and currently even basics statistics are missing. This patch creates per heap debugfs directory /sys/kernel/debug/ and adds the following counters: - the number of allocated buffers; - the number of allocated bytes; - the number of allocated bytes watermark.