[PATCH] staging: mt7621-mmc: Fix lines over 80 characters in dbg.c

This patch fixes lines over 80 characters in dbg.c. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.c | 79 +++- 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/drivers/staging/mt7621-mmc/dbg.c

[PATCH 3.18 036/120] staging: android: ashmem: Fix mmap size validation

3.18-stable review patch. If anyone has any objections, please let me know. -- From: Alistair Strachan [ Upstream commit 8632c614565d0c5fdde527889601c018e97b6384 ] The ashmem driver did not check that the size/offset of the vma passed to its .mmap() function was not larger

Re: [PATCH 03/21] media: davinci_vpfe: fix vpfe_ipipe_init() error handling

On Mon, Oct 08, 2018 at 09:46:01PM -0700, Joel Fernandes wrote: > On Fri, Apr 06, 2018 at 10:23:04AM -0400, Mauro Carvalho Chehab wrote: > > As warned: > > drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1834 vpfe_ipipe_init() > > error: we previously assumed 'res' could be null (see line

[PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in dbg.h

Replace explicit shifting with BIT macro in dbg.h. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/mt7621-mmc/dbg.h

[PATCH] staging: mt7621-mmc: Fix lines over 80 characters in dbg.h

This patch fixes lines over 80 characters in dbg.h. Issue found by checkpatch. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-mmc/dbg.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/staging/mt7621-mmc/dbg.h

Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks

On paź 11, 2018 10:32, Dan Carpenter wrote: > On Sat, Oct 06, 2018 at 10:25:42PM +0200, Slawomir Stepien wrote: > > On paź 06, 2018 13:27, Gabriel Capella wrote: > > > This patch does not change the logic, it only > > > corrects the checkpatch checks. > > > > > > The patch fixes 2 checks of type:

[PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info

From: Haiyang Zhang The VF device's serial number is saved as a string in PCI slot's kobj name, not the slot->number. This patch corrects the netvsc driver, so the VF device can be successfully paired with synthetic NIC. Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number")

[PATCH] staging: comedi: tio: fix multiple missing break in switch bugs

Currently, there are multiple missing break statements in two switch code blocks. This makes the execution path to fall all the way down through to the default cases, which makes the function ni_tio_set_gate_src() to always return -EINVAL. Fix this by adding the missing break statements. Also,

[PATCH 7/8] staging: rtl8188eu: cleanup long lines in stop_sta_xmit()

Line break lines over 80 characters in stop_sta_xmit() to clear checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 6/8] staging: rtl8188eu: cleanup long lines in rtw_get_sta_pending()

Line break lines over 80 characters in rtw_get_sta_pending() to clear checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 8/8] staging: rtl8188eu: remove whitespace in qos_acm()

Remove whitespace in qos_acm() to improve readability. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 4/8] staging: rtl8188eu: remove commented code

Remove unused commented code in the file core/rte_xmit.c. Clears 'please, no space before tabs' and 'line over 80 characters' checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++- 1 file changed, 2 insertions(+), 21

[PATCH 5/8] staging: rtl8188eu: cleanup block comments

Cleanup block comments to clear 'please, no space before tabs' and 'line over 80 characters' checkpatch warnings. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git

[PATCH 3/8] staging: rtl8188eu: cleanup alignment issue

Clear a 'Alignment should match open parenthesis' checkpatch issue. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 2/8] staging: rtl8188eu: use __func__ in qos_acm()

Use __func__ instead of hardcoded name in qos_acm(). Reported by checkpatch. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c

[PATCH 1/8] staging: rtl8188eu: cleanup missing spaces around operators

Clear all missing spaces around operators checkpatch issues in the file core/rtw_xmit.c. Use '+=' or '-=' where possible. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 60 ++- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git

[PATCH 0/8] staging: rtl8188eu: cleanup style issues in rtw_xmit.c

Cleanup style/checkpatch issues in the file core/rtw_xmit.c. Michael Straube (8): staging: rtl8188eu: cleanup missing spaces around operators staging: rtl8188eu: use __func__ in qos_acm() staging: rtl8188eu: cleanup alignment issue staging: rtl8188eu: remove commented code staging:

Re: Direct io failed with ion

On 10/11/2018 03:44 AM, Rock Lee wrote: On Thu, Oct 11, 2018 at 4:12 PM Dan Carpenter wrote: On Thu, Oct 11, 2018 at 11:24:49AM +0800, Rock Lee wrote: Hi I tested direct io with a ion allocated buffer, got a -EFAULT error. It turned out that ion_mmap() set VM_IO & VM_PFNMAP, but

RE: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info

> -Original Message- > From: Haiyang Zhang > Sent: Thursday, October 11, 2018 4:15 PM > To: da...@davemloft.net; net...@vger.kernel.org > Cc: Haiyang Zhang ; KY Srinivasan > ; Stephen Hemminger ; > o...@aepfle.de; vkuznets ; > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org

Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

On Tue, Oct 09, 2018 at 01:09:42PM -0700, Andy Lutomirski wrote: > On Tue, Oct 9, 2018 at 8:28 AM Marcelo Tosatti wrote: > > > > On Mon, Oct 08, 2018 at 10:38:22AM -0700, Andy Lutomirski wrote: > > > On Mon, Oct 8, 2018 at 8:27 AM Marcelo Tosatti > > > wrote: > > > > I read the comment three

Re: [patch 00/11] x86/vdso: Cleanups, simmplifications and CLOCK_TAI support

On Thu, Oct 11, 2018 at 3:28 PM Marcelo Tosatti wrote: > > On Tue, Oct 09, 2018 at 01:09:42PM -0700, Andy Lutomirski wrote: > > On Tue, Oct 9, 2018 at 8:28 AM Marcelo Tosatti wrote: > > > > > > On Mon, Oct 08, 2018 at 10:38:22AM -0700, Andy Lutomirski wrote: > > > > On Mon, Oct 8, 2018 at 8:27

Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks

On Sat, Oct 06, 2018 at 10:25:42PM +0200, Slawomir Stepien wrote: > On paź 06, 2018 13:27, Gabriel Capella wrote: > > This patch does not change the logic, it only > > corrects the checkpatch checks. > > > > The patch fixes 2 checks of type: > > "CHECK: spaces preferred around that '-'" > > I've

[staging:staging-testing 240/554] ERROR: "__udivdi3" [drivers/md/dm-thin-pool.ko] undefined!

Hi Nick, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: a2d6e3e60abddbd0b949841611140c614957f6d5 commit: c3873a5c741f75847ae50a3f566fea2c171c1054 [240/554] staging: gasket: fix

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

On Thu 11-10-18 07:59:32, Arun KS wrote: > On 2018-10-10 23:03, Michal Hocko wrote: > > On Wed 10-10-18 22:26:41, Arun KS wrote: > > > On 2018-10-10 21:00, Vlastimil Babka wrote: > > > > On 10/5/18 10:10 AM, Arun KS wrote: > > > > > When free pages are done with higher order, time spend on > > > >

[PATCH] staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()

We need to unlock before returning on this error path. Fixes: 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c index

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

On 10/10/18 6:56 PM, Arun KS wrote: > On 2018-10-10 21:00, Vlastimil Babka wrote: >> On 10/5/18 10:10 AM, Arun KS wrote: >>> When free pages are done with higher order, time spend on >>> coalescing pages by buddy allocator can be reduced. With >>> section size of 256MB, hot add latency of a single

Re: Direct io failed with ion

On Thu, Oct 11, 2018 at 11:24:49AM +0800, Rock Lee wrote: > Hi > I tested direct io with a ion allocated buffer, got a -EFAULT > error. It turned out that ion_mmap() set VM_IO & VM_PFNMAP, but > check_vma_flags() (do_direct_IO() calls it) doesn't allow that VMA has > these flags set. Could you

Re: [PATCH v5 1/2] memory_hotplug: Free pages as higher order

On Thu 11-10-18 10:07:02, Vlastimil Babka wrote: > On 10/10/18 6:56 PM, Arun KS wrote: > > On 2018-10-10 21:00, Vlastimil Babka wrote: > >> On 10/5/18 10:10 AM, Arun KS wrote: > >>> When free pages are done with higher order, time spend on > >>> coalescing pages by buddy allocator can be reduced.

Re: [PATCH] staging: erofs: harden inode lookup for 32-bit platforms

On Tue, Oct 09, 2018 at 10:07:13PM +0800, Gao Xiang wrote: > This patch introduces inode hash function, test and set callbacks, > and iget5_locked to find the right inode for 32-bit platforms. > The way I read this changelog, we're trying to deal with corrupt file systems? Is that correct?

Re: [PATCH] staging: vboxvideo: unlock on error in vbox_cursor_atomic_update()

Hi, On 11-10-18 09:59, Dan Carpenter wrote: We need to unlock before returning on this error path. Fixes: 35f3288c453e ("staging: vboxvideo: Atomic phase 1: convert cursor to universal plane") Signed-off-by: Dan Carpenter Thanks, the kbuild test robot had already notified me about this but

Re: [PATCH] staging: vboxvideo: make a couple of funcs static

Hi, On 10-10-18 22:17, Craig Kewley wrote: Fix Sparse warnings: drivers/staging/vboxvideo/vbox_mode.c:309:6: warning: symbol 'vbox_primary_atomic_disable' was not declared. Should it be static? drivers/staging/vboxvideo/vbox_mode.c:452:6: warning: symbol 'vbox_cursor_atomic_disable' was not

Re: [PATCH] staging: erofs: harden inode lookup for 32-bit platforms

On 2018/10/11 16:44, Dan Carpenter wrote: > On Tue, Oct 09, 2018 at 10:07:13PM +0800, Gao Xiang wrote: >> This patch introduces inode hash function, test and set callbacks, >> and iget5_locked to find the right inode for 32-bit platforms. >> > > The way I read this changelog, we're trying to

Re: [PATCH 2/3] staging: greybus: loopback.c: do insertion in O(n) instead of O(n lg n)

On 2018-10-11 01:03, Bryan O'Donoghue wrote: > On 05/10/2018 15:28, Rasmus Villemoes wrote: >> Signed-off-by: Rasmus Villemoes >> --- >> I have no idea if the performance matters (it probably doesn't). Feel >> free to ignore this and the followup cleanup. > > What's the problem you're fixing here

Re: [PATCH] staging: erofs: harden inode lookup for 32-bit platforms

On Thu, Oct 11, 2018 at 05:46:26PM +0800, Gao Xiang wrote: > > > On 2018/10/11 16:44, Dan Carpenter wrote: > > On Tue, Oct 09, 2018 at 10:07:13PM +0800, Gao Xiang wrote: > >> This patch introduces inode hash function, test and set callbacks, > >> and iget5_locked to find the right inode for

Re: [PATCH 0/15] Add support for OLPC XO 1.75 Embedded Controller

On Wed, 2018-10-10 at 14:26 -0500, Rob Herring wrote: > On Wed, Oct 10, 2018 at 12:23 PM Lubomir Rintel wrote: > > Hi. > > > > This patchset adds support for the Embedded Controller on an OLPC XO > > 1.75 machine. OLPC XO 1.75 is a MMP2 based ARM laptop. It plugs into > > the existing OLPC

Re: Direct io failed with ion

On Thu, Oct 11, 2018 at 4:12 PM Dan Carpenter wrote: > > On Thu, Oct 11, 2018 at 11:24:49AM +0800, Rock Lee wrote: > > Hi > > I tested direct io with a ion allocated buffer, got a -EFAULT > > error. It turned out that ion_mmap() set VM_IO & VM_PFNMAP, but > > check_vma_flags() (do_direct_IO()

Re: [PATCH] staging: erofs: harden inode lookup for 32-bit platforms

Hi Dan, On 2018/10/11 18:18, Dan Carpenter wrote: > On Thu, Oct 11, 2018 at 05:46:26PM +0800, Gao Xiang wrote: >> >> >> On 2018/10/11 16:44, Dan Carpenter wrote: >>> On Tue, Oct 09, 2018 at 10:07:13PM +0800, Gao Xiang wrote: This patch introduces inode hash function, test and set callbacks,

Re: [PATCH] staging: erofs: harden inode lookup for 32-bit platforms

On Thu, Oct 11, 2018 at 06:49:57PM +0800, Gao Xiang wrote: > Hi Dan, > > On 2018/10/11 18:18, Dan Carpenter wrote: > > On Thu, Oct 11, 2018 at 05:46:26PM +0800, Gao Xiang wrote: > >> > >> > >> On 2018/10/11 16:44, Dan Carpenter wrote: > >>> On Tue, Oct 09, 2018 at 10:07:13PM +0800, Gao Xiang

Re: [PATCH] staging: erofs: harden inode lookup for 32-bit platforms

Hi Dan, On 2018/10/11 19:12, Dan Carpenter wrote: > On Thu, Oct 11, 2018 at 06:49:57PM +0800, Gao Xiang wrote: >> Hi Dan, >> >> On 2018/10/11 18:18, Dan Carpenter wrote: >>> On Thu, Oct 11, 2018 at 05:46:26PM +0800, Gao Xiang wrote: On 2018/10/11 16:44, Dan Carpenter wrote: >