[PATCH 0/3] staging: wlan-ng: formatting changes

2018-11-07 Thread Tim Collier
Formatting changes to resolve 80 character limit warnings reported by checkpatch. Tim Collier (3): staging: wlan-ng: formatting change in cfg80211.c staging: wlan-ng: reformatting in hfa384x.h to fit 80 character limit staging: wlan-ng: reformatting in prism2mib.c to fit 80 character

[PATCH 2/3] staging: iio: ad7780: check if ad778x before gain update

2018-11-07 Thread Giuliano Belinassi
Only the ad778x have the 'gain' status bit. Check it before updating. Signed-off-by: Giuliano Belinassi --- drivers/staging/iio/adc/ad7780.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c index

[PATCH 3/3] staging: iio: ad7780: generates pattern_mask from PAT bits

2018-11-07 Thread Giuliano Belinassi
Previously, all pattern_masks in the chip_info table were hardcoded. Now they are generated using the PAT macros, as described in the datasheets. Signed-off-by: Giuliano Belinassi --- drivers/staging/iio/adc/ad7780.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 1/3] staging: iio: ad7780: Add is_ad778x flag chip info

2018-11-07 Thread Giuliano Belinassi
This patch allows further checking of whatever the chip is (ad778x or ad717x). Signed-off-by: Giuliano Belinassi --- drivers/staging/iio/adc/ad7780.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c index

[PATCH 0/3] staging: iio: ad7780: pattern generation and gain update

2018-11-07 Thread Giuliano Belinassi
This series of patches fixes a bug in ad717x chips where the PAT2 bit was wrongly read as a GAIN bit. It also refactors the pattern_mask generation with the PAT bits. Giuliano Belinassi (3): staging: iio: ad7780: Add is_ad778x flag chip info staging: iio: ad7780: check if ad778x before gain

[PATCH 3/3] staging: wlan-ng: reformatting in prism2mib.c to fit 80 character limit

2018-11-07 Thread Tim Collier
Reformat lines over 80 characters in prism2mib.c to resolve "line over 80 characters" warnings reported by checkpatch. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2mib.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git

[PATCH 1/3] staging: wlan-ng: formatting change in cfg80211.c

2018-11-07 Thread Tim Collier
Resolve "line over 80 characters" warning reported by checkpatch by splitting function header over 2 lines. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/cfg80211.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c

[PATCH 2/3] staging: wlan-ng: reformatting in hfa384x.h to fit 80 character limit

2018-11-07 Thread Tim Collier
Reformat lines over 80 characters in hfa384x.h to resolve "line over 80 characters" warnings reported by checkpatch. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x.h | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git

[PATCH 3/3] staging: emxx_udc: Added missing le16_to_cpu conversions

2018-11-07 Thread Carmeli Tamir
Fixed sparse tool warnings due to missing convesion from le16 to cpu endienness. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH 2/3] staging: emxx_udc: Added missing __iomem modifier to handle p_regs

2018-11-07 Thread Carmeli Tamir
Since in nbu2ss_drv_probe() p_regs is assigned from mmio_base, which is marked as __iomem, p_regs also should be market with __iomem. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 44 ++--- drivers/staging/emxx_udc/emxx_udc.h | 2 +- 2

[PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller

2018-11-07 Thread Carmeli Tamir
Added static modifier to the udc_controller, since it's only required within emxx_udc.c. Signed-off-by: Carmeli Tamir --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH 0/3] staging: emxx_udc: Fixed all meaningful sparse warnings

2018-11-07 Thread Carmeli Tamir
This series fixes all meaningful sparse (running make C=2... ) warnings. The number of warnings is reduced from ~280 to 12 (only warnings of type 'expression using sizeof(void)' are left). Resent the series to Greg's request. Carmeli Tamir (3): staging: emxx_udc: Added static modifier to

Re: [PATCH V2] binder: ipc namespace support for android binder

2018-11-07 Thread Andrew Morton
On Wed, 7 Nov 2018 01:48:12 + chouryzhou(周威) wrote: > > > --- a/ipc/namespace.c > > > +++ b/ipc/namespace.c > > > @@ -56,6 +56,9 @@ static struct ipc_namespace *create_ipc_ns(struct > > user_namespace *user_ns, > > > ns->ucounts = ucounts; > > > > > > err = mq_init_ns(ns); >

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

2018-11-07 Thread wahahab
> On 7 Nov 2018, at 5:15 PM, Greg Kroah-Hartman wrote: > > On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: >> Add a attribute called permissions under vsoc device node for examining >> current granted permissions in vsoc_device. >> >> This file will display permissions in following

RE: [PATCH V2] binder: ipc namespace support for android binder

2018-11-07 Thread 周威
> -Original Message- > From: Andrew Morton > Sent: Thursday, November 8, 2018 6:38 AM > To: chouryzhou(周威) > Cc: gre...@linuxfoundation.org; a...@android.com; tk...@android.com; > d...@stgolabs.net; de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH V2]

Re: [PATCH] staging: erofs: use the new LZ4_decompress_safe_partial()

2018-11-07 Thread Gao Xiang
Hi Chao, On 2018/11/8 14:11, Chao Yu wrote: > On 2018/11/8 12:00, Gao Xiang wrote: >> LZ4_decompress_safe_partial() can now decode exactly the nb of bytes >> requested after the upstreamed commit 2209fda323e2 ("lib/lz4: update LZ4 >> decompressor module"), remove the erofs hacked lz4

Re: [PATCH V2] binder: ipc namespace support for android binder

2018-11-07 Thread Davidlohr Bueso
On Mon, 29 Oct 2018, chouryzhou(??) wrote: +// If init_ipc_ns is not defined elsewhere, +// we make a fake one here to put our variable. /* * comments like this please */ +#if !defined(CONFIG_SYSVIPC) && !defined(CONFIG_POSIX_MQUEUE) +struct ipc_namespace init_ipc_ns; ... ---

Re: [PATCH 1/3] staging: iio: ad7780: Add is_ad778x flag chip info

2018-11-07 Thread Ardelean, Alexandru
On Wed, 2018-11-07 at 16:49 -0200, Giuliano Belinassi wrote: > This patch allows further checking of whatever the chip is (ad778x or > ad717x). Hey, The patch looks good overall. I only have one nitpick for this patch. See inline. And you can squash this patch with patch `[PATCH 2/3] staging:

Re: [PATCH V2] binder: ipc namespace support for android binder

2018-11-07 Thread Davidlohr Bueso
On Wed, 07 Nov 2018, Bueso wrote: On Mon, 29 Oct 2018, chouryzhou(??) wrote: +// If init_ipc_ns is not defined elsewhere, +// we make a fake one here to put our variable. /* * comments like this please */ Actually, just drop the comment altogether. Forward declaring does not merit it.

Re: [PATCH V2] binder: ipc namespace support for android binder

2018-11-07 Thread Davidlohr Bueso
On Mon, 29 Oct 2018, chouryzhou(??) wrote: @@ -63,6 +63,12 @@ struct ipc_namespace { unsigned intmq_msg_default; unsigned intmq_msgsize_default; + /* next fields are for binder */ + struct mutex binder_procs_lock; + struct hlist_head

Re: [PATCH] staging: erofs: use the new LZ4_decompress_safe_partial()

2018-11-07 Thread Chao Yu
On 2018/11/8 12:00, Gao Xiang wrote: > LZ4_decompress_safe_partial() can now decode exactly the nb of bytes > requested after the upstreamed commit 2209fda323e2 ("lib/lz4: update LZ4 > decompressor module"), remove the erofs hacked lz4 decompression code. > > A more cleaned compressor wrapper

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

2018-11-07 Thread Greg Kroah-Hartman
On Thu, Nov 08, 2018 at 08:49:41AM +0800, wahahab wrote: > > > On 7 Nov 2018, at 5:15 PM, Greg Kroah-Hartman wrote: > > > > On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: > >> Add a attribute called permissions under vsoc device node for examining > >> current granted permissions in

[PATCH] staging: erofs: use the new LZ4_decompress_safe_partial()

2018-11-07 Thread Gao Xiang
LZ4_decompress_safe_partial() can now decode exactly the nb of bytes requested after the upstreamed commit 2209fda323e2 ("lib/lz4: update LZ4 decompressor module"), remove the erofs hacked lz4 decompression code. A more cleaned compressor wrapper will be introduced in the subsequent patches in

Re: RFC: staging: gasket: re-implement using UIO

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 04:20:49PM -0800, Todd Poynor wrote: > On Mon, Sep 10, 2018 at 8:28 AM Ahmed S. Darwish wrote: > > > > The gasket in-kernel framework, recently introduced under staging, > > re-implements what is already long-time provided by the UIO > > subsystem, with extra PCI BAR

Re: [PATCH v7 05/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-07 Thread Sakari Ailus
On Fri, Aug 10, 2018 at 03:20:38PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Reviewed-by: Rob Herring > Signed-off-by: Rui Miguel Silva Acked-by: Sakari Ailus - -- Sakari Ailus

Re: [PATCH] staging: sm750fb: Add spaces around '+'

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 10:28:04PM -0200, Laís Pessine do Carmo wrote: > Add spaces around '+' to correct the following checkpath.pl warnings: > > WARNING: line over 80 characters > + write_dpPort(accel, *(unsigned int *)(pSrcbuf + > (j * 4))); > > WARNING: line over 80

Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller

2018-11-07 Thread Greg KH
On Thu, Nov 01, 2018 at 03:58:57PM -0400, Carmeli Tamir wrote: > Added static modifier to the udc_controller, since it's only > required within emxx_udc.c. > Previously posted without any feedback, now updated according to master. > > Signed-off-by: Carmeli Tamir > --- >

Re: [PATCH] staging: mt7621-mmc: Add blank line after declaration

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 10:42:42PM -0200, nico...@autobyte.com.br wrote: > From: Nícolas F. R. A. Prado > > Correct the following warning from checkpatch.pl: > > WARNING: Missing a blank line after declarations > + struct msdc_host *host = mmc_priv(mmc); > +

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-07 Thread gre...@linuxfoundation.org
On Mon, Oct 22, 2018 at 03:41:05AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > This staging driver is modified from this upstream driver at >

Re: [PATCH] staging: gasket: Use octal permissions instead of symbolic.

2018-11-07 Thread Rohit Sarkar
On Tue, Nov 06, 2018 at 09:12:45PM +0100, Greg KH wrote: > On Tue, Nov 06, 2018 at 04:33:47PM +0530, Rohit Sarkar wrote: > > Replace S_IRUGO with 0444. Issue found by checkpatch. > > > > Signed-off-by: Rohit Sarkar > > --- > > drivers/staging/gasket/gasket_sysfs.h | 4 ++-- > > 1 file changed,

Re: [PATCH] staging: rtl8723bs: Correct errors from checkpatch

2018-11-07 Thread Hans de Goede
Hi, On 07-11-18 00:27, Josenivaldo Benito Jr wrote: Correct following errors reported by checkpath.pl: ERROR: space required before the open parenthesis '(' #265: FILE: drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c:265: +   if(!precvframe) ')' Also similar errors on line

[PATCH] staging: rtl8192u: rename struct name _rt_firmare_seg_container

2018-11-07 Thread Colin King
From: Colin Ian King Rename struct _rt_firmare_seg_container to _fw_seg_container to match the typedef name of this structure. Also removes the spelling mistake of 'firmare'. Signed-off-by: Colin Ian King --- drivers/staging/rtl8192u/r8192U.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v3] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-07 Thread Greg Kroah-Hartman
On Tue, Nov 06, 2018 at 01:13:19PM +0530, Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface in olpc_dcon_xo_1.c. > --- > Changes in v3: > - Resolve a few compilation errors. > Changes in v2: > - Resolve a few compilation errors. > - Add a

Re: [PATCH] media: staging: tegra-vde: Change from __attribute to __packed.

2018-11-07 Thread Dmitry Osipenko
On 07.11.2018 5:23, rafaelgoncal...@riseup.net wrote: > From: Rafael Goncalves > > Correct the following warnings from checkpatch.pl: > > WARNING: __packed is preferred over __attribute__((packed)) > +} __attribute__((packed)); > > WARNING: __packed is preferred over __attribute__((packed)) >

Re: [PATCH v3] driver-staging: vsoc.c: Add sysfs support for examining the permissions of regions.

2018-11-07 Thread Greg Kroah-Hartman
On Wed, Nov 07, 2018 at 10:30:43AM +0800, Jerry Lin wrote: > Add a attribute called permissions under vsoc device node for examining > current granted permissions in vsoc_device. > > This file will display permissions in following format: > begin_offset end_offset owner_offset owned_value >

Re: [PATCH v7 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-07 Thread Hans Verkuil
Hi Rui, On 08/10/18 16:20, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in the imx media

Re: [PATCH] staging: gasket: Use octal permissions instead of symbolic.

2018-11-07 Thread Greg KH
On Wed, Nov 07, 2018 at 05:41:29PM +0530, Rohit Sarkar wrote: > On Tue, Nov 06, 2018 at 09:12:45PM +0100, Greg KH wrote: > > On Tue, Nov 06, 2018 at 04:33:47PM +0530, Rohit Sarkar wrote: > > > Replace S_IRUGO with 0444. Issue found by checkpatch. > > > > > > Signed-off-by: Rohit Sarkar > > > ---

Re: [PATCH v7 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-07 Thread Rui Miguel Silva
Hi Hans, On Wed 07 Nov 2018 at 09:58, Hans Verkuil wrote: Hi Rui, On 08/10/18 16:20, Rui Miguel Silva wrote: Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an

Re: [PATCH v3 2/4] staging: wilc1000: validate cfg parameters before scheduling the work

2018-11-07 Thread kbuild test robot
Hi Adham, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.20-rc1 next-20181106] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Staging: vchi: Add license id and change int type

2018-11-07 Thread Greg KH
On Tue, Nov 06, 2018 at 10:07:38PM -0200, andrealm...@riseup.net wrote: > From: André Almeida > > Fix the following checkpatch issues: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > CHECK: Prefer kernel type 's32' over 'int32_t' > > Signed-off-by: André Almeida > >

Re: [PATCH] Staging: vchi: Add license id and change int type

2018-11-07 Thread Stefan Wahren
Hi Andre, Am 07.11.18 um 01:07 schrieb andrealm...@riseup.net: > From: André Almeida > > Fix the following checkpatch issues: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > CHECK: Prefer kernel type 's32' over 'int32_t' thanks for your patch, but there are some

Re: [PATCH v2] staging: wilc1000: update wilc1000 driver maintainer ids

2018-11-07 Thread Greg KH
On Wed, Nov 07, 2018 at 05:05:01AM +, ajay.kat...@microchip.com wrote: > From: Ajay Singh > > We would like to update the maintainer email id's for wilc1000 driver. > > Signed-off-by: Aditya Shankar > Signed-off-by: Ganesh Krishna > Signed-off-by: Adham Abozaeid > Signed-off-by: Ajay

[PATCH v4] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-07 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface in olpc_dcon_xo_1.c. Signed-off-by: Nishad Kamdar --- Changes in v4: - Move changelog after signed-off line. Changes in v3: - Resolve a few compilation errors. Changes in v2: - Resolve a few compilation errors. -

[staging:staging-testing 42/93] drivers/staging//media/tegra-vde/tegra-vde.c:265:5: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'

2018-11-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 64ce301c971bb323ab63f59014498d7e975586ee commit: 42e764d05712c07e44318bc8f6b8665a9c216505 [42/93] staging: tegravde: replace bit assignment with macro config: sh-allmodconfig (attached as .config)

Re: [PATCH v3] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-11-07 Thread Nishad Kamdar
On Wed, Nov 07, 2018 at 12:36:52PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 06, 2018 at 01:13:19PM +0530, Nishad Kamdar wrote: > > Use the gpiod interface instead of the deprecated old non-descriptor > > interface in olpc_dcon_xo_1.c. > > --- > > Changes in v3: > > - Resolve a few

Re: [staging:staging-testing 42/93] drivers/staging//media/tegra-vde/tegra-vde.c:265:5: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long unsigned int'

2018-11-07 Thread Greg Kroah-Hartman
On Wed, Nov 07, 2018 at 08:45:40PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 64ce301c971bb323ab63f59014498d7e975586ee > commit: 42e764d05712c07e44318bc8f6b8665a9c216505 [42/93] staging: tegravde: >

Re: [PATCH v6 33/33] staging: mt7621-pci: replace 'mdelay()' with 'msleep()'

2018-11-07 Thread Sergio Paracuellos
On Mon, Nov 05, 2018 at 09:09:39AM +0100, Frans Klaver wrote: > On Sun, Nov 4, 2018 at 11:51 AM Sergio Paracuellos > wrote: > > > > Function 'mt7621_pcie_init_ports' is never called in atomic context. > > It calls mdelay() to busily wait, which is not necessary. mdelay() > > can be replaced with