Hi Geert,
Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100:
> On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen
> wrote:
> > Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:
> > > On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote:
> > > > As the driver has some support for the audio
Hi Alex,
On Fri, Mar 20, 2020 at 9:58 AM Alex Riesen
wrote:
> Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100:
> > > +int adv748x_dai_init(struct adv748x_dai *dai)
> > > +{
> > > + int ret;
> > > + struct adv748x_state *state = adv748x_dai_to_state(dai);
> > > +
> > > +
Geert Uytterhoeven, Fri, Mar 20, 2020 10:15:17 +0100:
> On Fri, Mar 20, 2020 at 10:03 AM Alex Riesen
> wrote:
> > Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100:
> > > On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen
> > > wrote:
> > > > Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:
> >
Hi Alex,
On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen
wrote:
> Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:
> > On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote:
> > > As the driver has some support for the audio interface of the device,
> > > the bindings file should mention
Hi Alex,
CC linux-clk for the clock provider.
On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen
wrote:
> This adds an implemention of SoC DAI driver which provides access to the
> I2S port of the device.
>
> Signed-off-by: Alexander Riesen
Thanks for your patch!
One comment below.
> ---
>
Hi Geert,
Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100:
> CC linux-clk for the clock provider.
Thanks!
> > +int adv748x_dai_init(struct adv748x_dai *dai)
> > +{
> > + int ret;
> > + struct adv748x_state *state = adv748x_dai_to_state(dai);
> > +
> > + dai->mclk =
Hi Laurent,
Laurent Pinchart, Thu, Mar 19, 2020 18:48:02 +0100:
> On Thu, Mar 19, 2020 at 06:41:48PM +0100, Alex Riesen wrote:
> > To follow the established practice of not depending on others to
> > pull everything in.
>
> Good idea. While at it, could you include "adv748x.h" as the very first
Hi Laurent,
Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:
> On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex Riesen wrote:
> > As the driver has some support for the audio interface of the device,
> > the bindings file should mention it.
>
> While at it, how about converting the bindings to
Laurent Pinchart, Thu, Mar 19, 2020 19:06:14 +0100:
> On Thu, Mar 19, 2020 at 06:41:53PM +0100, Alex Riesen wrote:
> > #define io_read(s, r) adv748x_read(s, ADV748X_PAGE_IO, r)
> > #define io_write(s, r, v) adv748x_write(s, ADV748X_PAGE_IO, r, v)
> > -#define io_clrset(s, r, m, v) io_write(s, r,
Hi Alex,
On Fri, Mar 20, 2020 at 10:03 AM Alex Riesen
wrote:
> Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100:
> > On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen
> > wrote:
> > > Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:
> > > > On Thu, Mar 19, 2020 at 06:42:36PM +0100, Alex
Hi Alex,
On Fri, Mar 20, 2020 at 11:58 AM Alex Riesen
wrote:
> Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100:
> > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen
> > wrote:
> > > This adds an implemention of SoC DAI driver which provides access to the
> > > I2S port of the device.
>
> I
On Wed, Mar 18, 2020 at 02:31:27PM -0300, Camylla Cantanheide wrote:
> Dear Dan Carpenter and Joe Perches,
>
> Thank you very much for the suggestions, I found the evaluation of both
> very significant. Now, I have another perspective on variables.
>
> I solved the problem for the *setKey
Hi Geert,
Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100:
> CC linux-clk for the clock provider.
>
> On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen
> wrote:
> > This adds an implemention of SoC DAI driver which provides access to the
> > I2S port of the device.
I just noticed I don't do
Hi Geert,
Geert Uytterhoeven, Fri, Mar 20, 2020 12:05:20 +0100:
> On Fri, Mar 20, 2020 at 11:58 AM Alex Riesen
> wrote:
> > Geert Uytterhoeven, Fri, Mar 20, 2020 09:43:29 +0100:
> > > On Thu, Mar 19, 2020 at 6:42 PM Alex Riesen
> > > wrote:
> > > > This adds an implemention of SoC DAI driver
Hi Alex,
On Fri, Mar 20, 2020 at 10:03:39AM +0100, Alex Riesen wrote:
> Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100:
> > On Fri, Mar 20, 2020 at 9:44 AM Alex Riesen
> > wrote:
> > > Laurent Pinchart, Thu, Mar 19, 2020 19:01:25 +0100:
> > > > On Thu, Mar 19, 2020 at 06:42:36PM +0100,
As all known variants of the Salvator board have the HDMI decoder
chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482
endpoint and the connection definitions are placed in the common board
file.
For the same reason, the CLK_C clock line and I2C configuration (similar
to the ak4613,
Function 'devm_gpiod_get_index_optional' returns NULL if the
descriptor is invalid and the error associated for the error
pointer is ENOENT. Sometimes if the pin is just assigned the
error associated for the pointer might not be ENOENT but other.
In order to avoid weirds behaviours if this happen
This soc has two phy's for the pcie one of them using just a different
register for settig it up but sharing all the rest of the config. Until
now we was presenting this schema as three different phy's in the device
tree using the 'phy-cells' node property to discriminate an index and
setting up a
Mt7621 soc has two phy's for the pcie one of them using just a different
register for settig it up but sharing all the rest of the config. Until
now we was presenting this schema as three different phy's in the device
tree using the 'phy-cells' node property to discriminate an index and setting
up
We are using the counter to print the slot which has been
enabled. Use the correct associated slot for the port instead.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-pci/pci-mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
In order to align work with the mt7621-pci-phy part of
the driver and device tree which is now using only two
real phys one of them dual ported properly parse the
device tree and don't call phy initialization for the
slot 1 because is being taking into account when the
phy for the slot 0 is
This soc has only two real pcie phys one of them
having a different register to enable and disable it.
Change this to have only two dt nodes for the phys and
use 'phy-cells' properly to say if the phy has dual ports.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/mt7621-dts/mt7621.dtsi |
Dear Sir/Madam
HAPPY SURVIVAL OF CORONAVIRUS
We the West African Monitoring Committee of the West African Economic
Community(ECOWAS)are contacting you for a business transaction which
we feel will be of great interest to you.
Our duty is to see to the coming in and out of funds into this sub
The following changes since commit f8788d86ab28f61f7b46eb6be375f8a726783636:
Linux 5.6-rc3 (2020-02-23 16:17:42 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
tags/staging-5.6-rc7
for you to fetch changes up to
Hi Chuanhong,
On Fri, Mar 20, 2020 at 3:59 PM Chuanhong Guo wrote:
>
> Hi!
>
> On Sat, Mar 14, 2020 at 4:10 AM Sergio Paracuellos
> wrote:
> >
> > R3G's LEDs fail to initialize because one of them uses GPIO8
>
> A gpio can't be used as pcie reset and led simultaneously.
>
Obviously it can't.
Hi Sergio,
On 20/3/20 2:14 am, Sergio Paracuellos wrote:
In some platforms gpio's are not used for reset but
for other purposes. Because of that when we try to
get them are valid gpio's but are already assigned
to do other function. To avoid those kind of problems
in those platforms just notice
Hi Sergio,
On 21/3/20 12:38 am, Sergio Paracuellos wrote:
On Fri, Mar 20, 2020 at 3:30 PM Greg Ungerer wrote:
On 20/3/20 2:14 am, Sergio Paracuellos wrote:
[snip]
rt2880-pinmux pinctrl: pcie is already enabled
mt7621-pci 1e14.pcie: Error applying setting, reverse things back
Hi!
On Fri, Mar 20, 2020 at 11:29 PM Sergio Paracuellos
wrote:
> > This pin conflict comes from incorrectly occupying pins that are not
> > used by pcie,
> > and should be fixed by not occupying those pins in the first place.
> > Releasing all
> > gpios isn't the proper way to go.
>
> So, you
Hi Greg,
On Fri, Mar 20, 2020 at 3:30 PM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 20/3/20 2:14 am, Sergio Paracuellos wrote:
> > In some platforms gpio's are not used for reset but
> > for other purposes. Because of that when we try to
> > get them are valid gpio's but are already assigned
> >
Hi Greg,
On Fri, Mar 20, 2020 at 4:08 PM Greg Ungerer wrote:
>
> Hi Sergio,
>
> On 21/3/20 12:38 am, Sergio Paracuellos wrote:
> > On Fri, Mar 20, 2020 at 3:30 PM Greg Ungerer wrote:
> >> On 20/3/20 2:14 am, Sergio Paracuellos wrote:
> [snip]
> >> rt2880-pinmux pinctrl: pcie is already enabled
Hi!
On Sat, Mar 14, 2020 at 4:10 AM Sergio Paracuellos
wrote:
>
> R3G's LEDs fail to initialize because one of them uses GPIO8
A gpio can't be used as pcie reset and led simultaneously.
> Hence, release the GPIO resources after PCIe initialization
> and properly release also in driver error
Phy for slot 0 and 1 is shared and handled properly in slot 0.
If there is only one port in use,(slot 0) we shall not call the
'phy_power_off' function with an invalid slot because kernel
will crash with an unaligned access fault like the following:
mt7621-pci 1e14.pcie: Error applying
The regmap provides a convenient utility for this.
The hdmi_* and dpll_* register modification macros added for symmetry
with the existing operations (io_*, sdp_*).
Signed-off-by: Alexander Riesen
Reviewed-by: Laurent Pinchart
--
v3: remove _update name in favor of existing _clrset
---
On Fri, Mar 20, 2020 at 5:32 PM Sergio Paracuellos
wrote:
>
> Hi,
>
> On Fri, Mar 20, 2020 at 4:39 PM Chuanhong Guo wrote:
> >
> > Hi!
> >
> > On Fri, Mar 20, 2020 at 11:29 PM Sergio Paracuellos
> > wrote:
> > > > This pin conflict comes from incorrectly occupying pins that are not
> > > > used
As the driver has some support for the audio interface of the device,
the bindings file should mention it.
Signed-off-by: Alexander Riesen
Reviewed-by: Rob Herring
Reviewed-by: Laurent Pinchart
--
v3: remove optionality off MCLK clock cell to ensure the description
matches the hardware
This adds minimal support for accessing the HDMI audio provided through the
I2S port available on ADV7481 and ADV7482 decoder devices by ADI.
The port carries audio signal from the decoded HDMI stream.
Currently, the driver only supports I2S in TDM, 8 channels a 24bit at 48kHz.
Furthermore, only
To follow the established practice of not depending on others to
pull everything in. While at it, make sure it stays like this.
Signed-off-by: Alexander Riesen
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/adv748x/adv748x-afe.c | 6 ++
drivers/media/i2c/adv748x/adv748x-core.c | 6
Signed-off-by: Alexander Riesen
---
drivers/media/i2c/adv748x/adv748x.h | 32 +
1 file changed, 32 insertions(+)
diff --git a/drivers/media/i2c/adv748x/adv748x.h
b/drivers/media/i2c/adv748x/adv748x.h
index 0a9d78c2870b..1a1ea70086c6 100644
---
Hi,
On Fri, Mar 20, 2020 at 4:39 PM Chuanhong Guo wrote:
>
> Hi!
>
> On Fri, Mar 20, 2020 at 11:29 PM Sergio Paracuellos
> wrote:
> > > This pin conflict comes from incorrectly occupying pins that are not
> > > used by pcie,
> > > and should be fixed by not occupying those pins in the first
As there is nothing else (the consumers are supposed to do that) which
enables the clock, do it in the driver.
Signed-off-by: Alexander Riesen
--
v3: added
---
drivers/media/i2c/adv748x/adv748x-dai.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git
Hi Laurent,
Laurent Pinchart, Fri, Mar 20, 2020 10:59:07 +0100:
> On Fri, Mar 20, 2020 at 10:03:39AM +0100, Alex Riesen wrote:
> > Geert Uytterhoeven, Fri, Mar 20, 2020 09:48:14 +0100:
> > >
> > > You'd be surprised how many board designers would consider this a cheap
> > > 12.288 MHz clock
The pull request you sent on Fri, 20 Mar 2020 15:27:58 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> tags/staging-5.6-rc7
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3bd14829d3275d96ff723a6c57429e9238117779
Thank you!
--
Signed-off-by: Alexander Riesen
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/adv748x/adv748x-core.c | 24
drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/media/i2c/adv748x/adv748x-core.c
To avoid setting it up even if the hardware is not actually connected
to anything physically.
Besides, the bindings explicitly notes that port definitions are
"optional if they are not connected to anything at the hardware level".
Signed-off-by: Alexander Riesen
---
As all known variants of the Salvator board have the HDMI decoder
chip (the ADV7482) connected to the SSI4 on R-Car SoC, the ADV7482
endpoint and the connection definitions are placed in the common board
file.
For the same reason, the CLK_C clock line and I2C configuration (similar
to the ak4613,
This makes it possible to load a EDID reported by the device
with v4l2-ctl utility:
vdev=/dev/$(grep -l '^adv748x.*hdmi$' /sys/class/video4linux/v4l-subdev*/name
|cut -d/ -f5-5)
v4l2-ctl -d $vdev --set-edid=pad=0,file=/etc/adv7482.edid
Signed-off-by: Alexander Riesen
--
I would like to
Use the BIT() macro instead of the hexadecimal value to define the
different bits in registers.
Signed-off-by: Oscar Carter
---
drivers/staging/vt6656/desc.h | 35 ++---
drivers/staging/vt6656/device.h | 9 +-
drivers/staging/vt6656/mac.h| 263
3 files
On Wed, Mar 11, 2020 at 12:18:50PM +, ajay.kat...@microchip.com wrote:
> From: Ajay Singh
>
> This file describes the binding details to connect wilc1000 device. It's
> moved from staging to 'Documentation/devicetree/bindings/net/wireless'
> path.
>
> Signed-off-by: Ajay Singh
> ---
>
This adds an implemention of SoC DAI driver which provides access to the
I2S port of the device.
Signed-off-by: Alexander Riesen
--
v3: fix clock registration in case of multiple adv748x devices
Suggested-by: Geert Uytterhoeven
---
drivers/media/i2c/adv748x/Makefile | 3 +-
The logged information provides insights about cable connection and the
state of the HDMI decoder. It is very useful when debugging hardware
problems in environments without easy access to the connectors.
This change adds a device-specific wrapper for register block read,
because some of the
The last parameter in the functions vnt_mac_reg_bits_on and
vnt_mac_reg_bits_off defines the bits to set or unset. So, it's more
clear to use the BIT() macro instead of an hexadecimal value.
Signed-off-by: Oscar Carter
---
drivers/staging/vt6656/baseband.c | 5 +++--
According to the TODO code valid only for 5 GHz should be removed.
- find and remove remaining code valid only for 5 GHz. Most of the obvious
ones have been removed, but things like channel > 14 still exist.
Remove if statement that checks for channel > 14 from rtw_ieee80211.c.
Signed-off-by:
Hello,
syzbot found the following crash on:
HEAD commit:e17994d1 usb: core: kcov: collect coverage from usb comple..
git tree: https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=11d74573e0
kernel config:
allyesconfig
pariscgeneric-32bit_defconfig
x86_64 randconfig-a001-20200320
x86_64 randconfig-a002-20200320
x86_64 randconfig-a003-20200320
i386 randconfig-a001-20200320
i386
mips malta_kvm_defconfig
pariscallnoconfig
parisc allyesconfig
pariscgeneric-32bit_defconfig
pariscgeneric-64bit_defconfig
x86_64 randconfig-a001-20200320
x86_64
Quoting Alex Riesen (2020-03-20 09:12:00)
> diff --git a/drivers/media/i2c/adv748x/adv748x-dai.c
> b/drivers/media/i2c/adv748x/adv748x-dai.c
> new file mode 100644
> index ..6fce7d000423
> --- /dev/null
> +++ b/drivers/media/i2c/adv748x/adv748x-dai.c
> @@ -0,0 +1,265 @@
> +//
56 matches
Mail list logo
