vchi has a set of transfer flags which almost map 1:1 to vchiq's own
transfer modes. For the sake of simplicity let's use the later and
delete vchi's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-audio/bcm2835.h |
They are neither produced nor expected, so just delete them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 40 ++-
1 file changed, 3 insertions(+), 37 deletions(-)
diff --git
Nothing in it is being used.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 1 -
.../vc04_services/interface/vchi/vchi_cfg.h | 238 --
2 files changed, 239 deletions(-)
delete mode 100644
There are no gains from that extra indirection level. Also, get rid of
the function description, the whole file will disappear soon.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_shim.c | 29 +++
1 file changed, 4 insertions(+), 25 deletions(-)
vchiq consumer drivers may need to use this function in order to get the
benefits of vchiq's per service message queueing mechanism.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 1 +
1 file changed, 1 insertion(+)
diff --git
enum vchi_callback_reason maps 1:1 to enum vchiq_reason, in an effort to
simplify things, let's use the later, and get rid of the extra
indirection.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 5 +--
.../interface/vchi/vchi_common.h |
Multiple connections are not handled by the IO thread, so it's not
really necessary to handle them on initialization.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/vc-sm-cma/vc_sm.c | 3 +-
.../vc04_services/vc-sm-cma/vc_sm_cma_vchi.c | 67 ++-
All users are ignoring the flags argument. So for the sake of
simplicity delete it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +--
drivers/staging/vc04_services/interface/vchi/vchi.h | 1 -
For initialization, vchi has its own params structure, which is then
translated to vchiq's params structure. They are essentially the same,
so lets directly use vchiq's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 9 +
The header file only provides other includes. Move the relevant includes
to their respective C files and delete it for good.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h | 1 -
.../interface/vchiq_arm/vchiq_2835_arm.c | 1 +
They don't exist, they have no users, get rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 59 ---
1 file changed, 59 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
For messages with a reason different from VCHIQ_MESSAGE_AVAILABLE the
responsibility for releasing them is kept in vchi, in other words,
services don't need to worry about it. As we're trying to unify vchi and
vchiq, move the release code into vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
When adding a new service validate the configuration parameters
provided, and remove unnecessary checks in vchi, now that we have
validated service's config.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.c | 15 +++
vchi created an opaque structure to be held by services while they
process callback messages. The contents of this opaque structure are the
service handle, which all services already maintain, and a pointer to
vchiq's message structure, struct vchiq_header.
Let's get rid of this opaque structure
The structure only contains a single parameter, which is the underlying
vchiq handle. Get rid of the struct and directly pass the handle around.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 23 ++---
.../vc04_services/interface/vchi/vchi.h | 25
The idea behind struct vchi_service_handle is to create an opaque handle
to struct shim_service. This can be achieved by doing a forward
declaration of struct shim_service, which will avoid unwarranted casts
and pointer play.
Ultimately as a rename is due all over the vchi user space, rename
There is already enough duplication with regard to fourcc generation in
the kernel. Let's at least use the same macro all over the vchiq
ecosystem.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
This is for service's callbacks to get their private data.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
The services have access to struct vchiq_header's internals, so we can
let them get the data pointer. This pretty much makes both functions
exactly the same, which will allow us to make a switch to
vchiq_msg_hold() further down the road.
Signed-off-by: Nicolas Saenz Julienne
---
On Wed, May 27, 2020 at 01:53:05PM +0200, Nicolas Saenz Julienne wrote:
> vchi acts as a mid layer between vchiq and its kernel services, while
> arguably providing little to no benefit: half of the functions exposed
> are a 1:1 copy of vchiq's, and the rest provide some functionality which
> can
Attn:
Es tut uns leid, dass wir Sie aufgrund eines Mismanagent of Beneficaries-Fonds
von unseren ernannten Zonal Managern versptet kontaktiert haben. Bitte
beachten Sie, dass Sie qualifiziert sind, die Zahlung von 900.000,00 USD an der
ATM-Karte mit neunhunderttausend Dollar zu erhalten.
Als
你好 ..
你那边怎么样我希望你一切都好吗？
我叫艾琳女士。 （28岁），我是妻子冈比亚的寡妇
的后期工程。伯纳德·巴卡里·扎卡里亚（Bernard Bakary Zakaria）。 Bajam Enterprise主管
（冈比亚的建筑公司）也是Bernard的首席执行官
进出口（GAMBIA）。
事实上，我丈夫为此死于冠状病毒19
他前往法国正式旅行之后的日期为2019年12月5日
见面后，他带着我2岁零6个月的女儿离开了我，
在我丈夫因冠状病毒19死亡后，他的兄弟（
我已故的购销销售经理
丈夫公司（詹姆斯·托昆博·奥里亚德·扎卡里亚先生）想要
On Wed, May 27, 2020 at 03:14:28PM +0200, Christian Gromm wrote:
> This patch adds the usb driver source file most_usb.c and
> modifies the Makefile and Kconfig accordingly.
>
> Signed-off-by: Christian Gromm
> ---
> v2:
> Reported-by: Greg Kroah-Hartman
> - don't remove usb driver from
Attn:
Es tut uns leid, dass wir Sie aufgrund eines Mismanagent of Beneficaries-Fonds
von unseren ernannten Zonal Managern versptet kontaktiert haben. Bitte
beachten Sie, dass Sie qualifiziert sind, die Zahlung von 900.000,00 USD an der
ATM-Karte mit neunhunderttausend Dollar zu erhalten.
Als
Nobody uses it and it's routinely discarded in vchi.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 9 -
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 4
2 files changed, 13 deletions(-)
diff --git
This is an include only used by the Linux kernel, so no need to worry
about C++ compatibility.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 8
1 file changed, 8 deletions(-)
diff --git
vchi_msg_dequeue() provides the same functionality as vchi_msg_hold()
except it copies the message data as opposed to the later which provides
the data in place.
The copying is done on a local variable, so there is no need to keep the
message out the function's bounds, so use vchi_msg_hold()
As vchiq_shim's callback does nothing aside from pushing messages into
the service's queue, let's bypass it and jump directly to the service's
callbacks, letting them choose whether to use the message queue.
It turns out most services don't need to use the message queue, which
makes for simpler
This has historically been handled by vchi, but there is no reason why
this couldn't be handled directly in vchiq.
The patch tries to avoid altering any behavior, with the exception of
the msg_queue size, which is now fixed to VCHIQ_MAX_SLOTS (it was set to
VCHIQ_MAX_SLOTS / 2). This is done to
There is a series of structures and enums defined but never used. Get
rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 65 ---
1 file changed, 65 deletions(-)
diff --git
The idea behind this was to create an opaque handle to struct
vchiq_instance. This can be achieved without creating a new type by
means of a forward declaration of struct vchiq_instance.
This saves us from a lot of useless casting and overall simplifies code.
Signed-off-by: Nicolas Saenz
Those defines aren't used by anyone. Get rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 11 ---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
2 files changed, 12 deletions(-)
diff --git
It's already forward declared in vchiq_if.h. So no need to insist
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
This file is internal to vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
All vchi users use the kernel variant of the copy callback. The only
user for the user space variant of the copy callback is in the ioctl
implementation. So move all this copying logic into vchiq, and expose a
new function that explicitly passes kernel messages.
Signed-off-by: Nicolas Saenz
It was probably there to trick compilers into ignoring unused variables,
which isn't needed in Linux.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 --
1 file changed, 2 deletions(-)
diff --git
Linux coding style says to avoid typdefs.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchi/vchi.h| 5 -
.../vc04_services/interface/vchiq_arm/vchiq_if.h | 14 --
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git
This will make further changes easier. The struct will ultimately
disappear.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 10 +++---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 7 ---
2 files changed, 7 insertions(+),
vchi acts as a mid layer between vchiq and its kernel services, while
arguably providing little to no benefit: half of the functions exposed
are a 1:1 copy of vchiq's, and the rest provide some functionality which
can be easly integrated into vchiq without all the churn. Moreover it
has been found
The function has no users.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 6
.../interface/vchiq_arm/vchiq_shim.c | 34 ---
2 files changed, 40 deletions(-)
diff --git
vchiq functions return an enum and vchi's ints. Those are compatible, no
need to explicitly cast them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_shim.c | 25 ---
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git
There are no users for that function.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 5 ---
.../interface/vchiq_arm/vchiq_shim.c | 31 ---
2 files changed, 36 deletions(-)
diff --git
There already is a function that covers most of the functionality
vchi_msg_peek() provides: vchi_msg_hold(). The main difference being
that the later removes the message from vchu's queue while the other
does it later on, while releasing the message.
There are no users of this function that can't
Nobody uses it. Get rid of it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 7
.../interface/vchiq_arm/vchiq_shim.c | 39 ---
2 files changed, 46 deletions(-)
diff --git
The function has no users.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 3 ---
.../interface/vchiq_arm/vchiq_shim.c | 19 ---
2 files changed, 22 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
vchiq_if.h is used by service consumers and only the exported API should
be present. Move the rest of definitions, which were not exported by the
way, to vchiq_core.h where they belong.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.h | 22
Those functions don't actually exist, nor have any use, nor the macros.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_if.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
We can't really merge it with vchiq_queue_message() as it has internal
users that will not benefit from the retry mechanism
vchiq_queue_kernel_message() uses. So, for the sake of getting rid of
vchi, move it into vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c
Those are only used in the core vchiq code, while present in vchiq's
'public' API header. Move them into the right place.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h| 5 -
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.h
Jerome Pouiller writes:
> This series introduces some nl80211 vendor extensions to the wfx driver.
>
> This series may lead to some discussions:
>
> 1. Patch 7 allows to change the dynamic PS timeout. I have found
> an API in wext (cfg80211_wext_siwpower()) that do more or less the
>
The barrier is only used by core code. So keep the barrier definition in
the core header.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h| 11 ---
.../vc04_services/interface/vchiq_arm/vchiq_core.h | 12
2 files changed, 12
All the functions that vchi currently provides are a 1:1 mapping to its
vchiq counterparts. Get rid of vchi altogether and use vchiq's on all
services.
In the process also get rid of the vchi directory, as the only remaining
file was a TODO file, which now lives in the parent directory.
Its vchiq counterpart, vchiq_bulk_transmit() is only used by vchi. We
can then merge both functions by moving vchi_bulk_queue_transmit()'s
retry mechanism into vchiq_bulk_transmit() and let services call the
later.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c
To make the separation clear between vchiq's header files and vchiq.h,
which is to be used by services and is the 'public' API, move it into a
dedicated includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile | 2 +-
This used to be vchiq_if.h but vchiq.h is more concise for an include
file that will hopefully be in the future in the includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/bcm2835-audio/bcm2835.h | 2 +-
.../vc04_services/interface/vchiq_arm/vchiq.h | 107
Its vchiq counterpart, vchiq_bulk_receive() is only used by vchi. We can
then merge both functions by moving vchi_bulk_queue_receive()'s retry
mechanism into vchiq_bulk_receive() and let services call the later.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h
The function is being exported although there is no use for it outside
of vchiq's core code. Keep it local then.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 3 ---
On Wed, May 27, 2020 at 10:45:25AM +0200, Mauro Carvalho Chehab wrote:
> Em Wed, 27 May 2020 00:11:43 -0700
> Nathan Chancellor escreveu:
>
> > Hi all,
> >
> > This series aims to clean up the code while addressing the majority of
> > clang warnings in this driver, some found by the 0day bot
On Wednesday 27 May 2020 14:34:37 CEST Kalle Valo wrote:
> Jerome Pouiller writes:
>
> > This series introduces some nl80211 vendor extensions to the wfx driver.
> >
> > This series may lead to some discussions:
> >
> > 1. Patch 7 allows to change the dynamic PS timeout. I have found
> >
This patch adds the usb driver source file most_usb.c and
modifies the Makefile and Kconfig accordingly.
Signed-off-by: Christian Gromm
---
v2:
Reported-by: Greg Kroah-Hartman
- don't remove usb driver from staging area
- don't touch staging/most/Kconfig
- remove
Attn:
Es tut uns leid, dass wir Sie aufgrund eines Mismanagent of Beneficaries-Fonds
von unseren ernannten Zonal Managern versptet kontaktiert haben. Bitte
beachten Sie, dass Sie qualifiziert sind, die Zahlung von 900.000,00 USD an der
ATM-Karte mit neunhunderttausend Dollar zu erhalten.
Als
Em Wed, 27 May 2020 09:45:21 -0700
Nathan Chancellor escreveu:
> On Wed, May 27, 2020 at 10:45:25AM +0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 27 May 2020 00:11:43 -0700
> > Nathan Chancellor escreveu:
> >
> > > Hi all,
> > >
> > > This series aims to clean up the code while addressing
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
driver-core-next
branch HEAD: 46d26819a5056f4831649c5887ad5c71a16d86f7 software node: implement
software_node_unregister()
elapsed time: 1524m
configs tested: 90
configs skipped: 2
The following configs
I need you as a partner to invest US$27.5Million.
You will invest and manage it based on terms of agreement
We shall do the needful to position and make you the beneficiary.
Please confirm your full names, contact address, phone, numbers, age, sex,
occupation.
I will supply you all necessary
Cursos Bonificables JUNIO 2020 (Empleados activos y en ERTE)
Buenos días
Se encuentra abierto el plazo de inscripción de Cursos Bonificables para
empleados en activo y en situación de ERTE (JUNIO 2020)
Todos los cursos son totalmente Bonificables con cargo al Crédito de Formación
2020 que
Rather than using a dependency on VIDEO_V4L2, this driver uses
"select", which fails when other dependencies are missing:
WARNING: unmet direct dependencies detected for VIDEO_V4L2
Depends on [n]: MEDIA_SUPPORT [=y] && (I2C [=y] || I2C [=y]=n) && VIDEO_DEV
[=n]
Selected by [y]:
-
On Sat, May 23, 2020 at 10:29:19PM +0100, Pascal Terjan wrote:
> This is one of the 9 drivers redefining rfc1042_header.
>
This is how the patch looks like in my email client:
https://marc.info/?l=linux-driver-devel=159026973821890=2
Do you see how the subject is far away from the body of the
allnoconfig
powerpc defconfig
x86_64 randconfig-a006-20200527
x86_64 randconfig-a002-20200527
x86_64 randconfig-a005-20200527
x86_64 randconfig-a003-20200527
x86_64 randconfig-a004-20200527
x86_64
This code was using get_user_pages_fast(), in a "Case 2" scenario
(DMA/RDMA), using the categorization from [1]. That means that it's
time to convert the get_user_pages_fast() + put_page() calls to
pin_user_pages_fast() + unpin_user_page() calls.
There is some helpful background in [2]:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
staging-testing
head: 36cf583eaff3458abbfac144c5e4d417a23fa1a1
commit: 398999dabc8cfc51c7274639cb87e2a316138859 [391/415] staging: wfx: split
wfx_get_ps_timeout() from wfx_update_pm()
config: x86_64-allyesconfig
Em Wed, 27 May 2020 00:11:43 -0700
Nathan Chancellor escreveu:
> Hi all,
>
> This series aims to clean up the code while addressing the majority of
> clang warnings in this driver, some found by the 0day bot and others
> found by me.
>
> There are several enum conversion warnings that happen,
The sk_buff needs to preserved for copying to various parts
of context and passing back to mac80211
clone sk_buff in context so to continue to writing to orginal
sk_buff data area to send in vnt_tx_context.
dev_kfree_skb the context on error or dev_kfree_skb the
orignal when done. The error
Move the USB element out of vnt_tx_packet and vnt_beacon_xmit to
vnt_tx_context with sk_buff passed in parameters with the data now
between skb->data and skb->len.
The vnt_tx_usb header is moved from vnt_tx_buffer to usbpipe.h with the
size added to extra_tx_headroom the largest possible size.
Hello,
syzbot found the following crash on:
HEAD commit:44456565 Merge tag 'io_uring-5.7-2020-05-22' of git://git...
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12990cba10
kernel config: https://syzkaller.appspot.com/x/.config?x=b3368ce0cc5f5ace
This patch replaces function strcmp() with sysfs_streq() to compare
strings provided via sysfs.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
drivers/staging/most/usb/usb.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
This patch makes function drci_rd_reg return 0 in case of success
and a negative number else. As no caller is evaluating the number
of bytes transferred by function usb_control_msg this information is
being omitted.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
This series fixes the comments received from the mailing list.
Christian Gromm (10):
staging: most: usb: change order of function parameters
staging: most: usb: don't use expressions that might fail in a
declaration
staging: most: usb: change return value of function drci_rd_reg
This patch moves function calls that can fail out of the declararion block
of a function body. This is done to enhance readability.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
drivers/staging/most/usb/usb.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff
This patch puts the call to usb_alloc_urb() before the critical
section starts that is protected with the io_mutex lock. This is
to make the section as short as possible and to use the regular
GFP_KERNEL flag.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
This patch returns 0 instead of variable in case of invalid parameter
has been passed to function to increase readability.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
drivers/staging/most/usb/usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This patch adds the missing put_device() function calls to
properly free allocated resources and maintain reference counts.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
drivers/staging/most/usb/usb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
This patch swaps the arguments of function get_stream_frame_size to
have the struct device as first parameter.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
drivers/staging/most/usb/usb.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git
This patch uses the -EINVAL return code where -EFAULT is wrongly being
used.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
drivers/staging/most/usb/usb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/usb/usb.c
This patch makes it transparent whether the function is exiting
with an error or successful.
Signed-off-by: Christian Gromm
Reported-by: Dan Carpenter
---
drivers/staging/most/usb/usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/most/usb/usb.c
This patch removes the expression that makes use of a priori knowledge
about channel numbers to calculate an array index.
The expression 'peer = 1 - channel' utilizes the fact that an USB interface
that operates on the asynchronous data of the Network only has two
endpoints. Hence, channel being 0
On Sat, May 23, 2020 at 10:12:47PM +0100, Pascal Terjan wrote:
> The value in shared headers was fixed 9 years ago in commit 8d661f1e462d
> ("ieee80211: correct IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK macro") and
> while looking at using shared headers for other duplicated constants
> I noticed this
On Sat, May 23, 2020 at 10:29:19PM +0100, Pascal Terjan wrote:
> This is one of the 9 drivers redefining rfc1042_header.
I do not understand what this changelog is trying to say. Can you fix
this up to be more explicit and detained and resend?
thanks,
greg k-h
On Tue, May 26, 2020 at 07:18:11PM +0200, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> Hello,
>
> This series introduces some nl80211 vendor extensions to the wfx driver.
>
> This series may lead to some discussions:
I've applied the first 6 patches here, until you get some answers from
Clang warns:
drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c:1707:64:
warning: implicit conversion from enumeration type 'const enum
ia_css_frame_format' to different enumeration type 'enum
atomisp_input_format' [-Wenum-conversion]
binary_supports_input_format(xcandidate,
Clang warns:
drivers/staging/media/atomisp/pci/isp/kernels/xnr/xnr_3.0/ia_css_xnr3.host.c:129:35:
warning: implicit conversion from 'unsigned long' to 'int32_t' (aka
'int') changes value from 18446744073709543424 to -8192
[-Wconstant-conversion]
return MAX(MIN(isp_strength, 0),
Clang warns:
drivers/staging/media/atomisp/pci/atomisp_cmd.c:4278:17: warning:
address of 'config->info' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (!>info) {
~ ^~~~
config cannot be NULL because it comes from an ioctl, which ensures
Hi all,
This series aims to clean up the code while addressing the majority of
clang warnings in this driver, some found by the 0day bot and others
found by me.
There are several enum conversion warnings that happen, which I do not
really know how to solve without understanding how exactly this
Clang warns:
../drivers/staging/media/atomisp/pci/atomisp_v4l2.c:1097:3: warning:
variable 'count' is incremented both in the loop header and in the loop
body [-Wfor-loop-analysis]
count++;
^
This was probably unintentional, remove it.
Link:
Clang warns:
../drivers/staging/media/atomisp/pci/sh_css.c:8537:14: warning: address
of 'pipe->output_stage' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (>output_stage)
~~ ~~^~~~
../drivers/staging/media/atomisp/pci/sh_css.c:8545:14:
Clang warns:
../drivers/staging/media/atomisp/pci/atomisp_v4l2.c:764:12: warning:
unused function 'atomisp_mrfld_power' [-Wunused-function]
static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable)
^
Use an '#if 0' preprocessor define to hide the broken code, leaving the
Clang warns:
../drivers/staging/media/atomisp/pci/sh_css_sp.c:1039:23: warning:
address of 'binary->in_frame_info' will always evaluate to 'true'
[-Wpointer-bool-conversion]
} else if (>in_frame_info) {
~~ ^
in_frame_info is not a
In commit 3436accadc3f
("staging: vt6656: Move vnt_get_frame_time and vnt_get_phy_field to rxtx")
not quite all of the code was removed.
Remove unused vnt_frame_time variable.
Reported-by: kbuild test robot
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6656/rxtx.c | 4
1 file
In commit 61bb798767e4
("staging: vt6656: vnt_get_rtscts_rsvtime_le replace with rts/cts duration.")
not quite all of the code was removed.
Remove unused vnt_frame_time variable.
Reported-by: kbuild test robot
Signed-off-by: Malcolm Priestley
---
v2 corrected the commit
Hi Mauro,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20200526]
[cannot apply to staging/staging-testing v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system.
99 matches
Mail list logo
