Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

- Original Message - > From: "Daeseok Youn" > Sent: Tuesday, March 25, 2014 10:01:48 PM > Subject: [PATCH] staging: vme: fix memory leak in vme_user_probe() > > > If vme_master_request() returns NULL when it failed, > it need to free buffers for master. > > And also removes unreachable

Re: [PATCH] staging: vme: fix memory leak in vme_user_probe()

- Original Message - > From: "DaeSeok Youn" > Sent: Wednesday, March 26, 2014 8:47:51 PM > > 2014-03-27 3:51 GMT+09:00 Aaron Sierra : > > - Original Message - > >> From: "Daeseok Youn" > >> Sent: Tuesday, March 25, 2014 10

[PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

From: Joe Schultz This patch corrects a failure to dereference a pointer in tsi148_slave_get(). It also removes the following compile warning on some platforms: warning: cast from pointer to integer of different size Signed-off-by: Joe Schultz --- drivers/vme/bridges/vme_tsi148.c |2 +- 1

[PATCH 2/3] vme_tsi148: Fix PCI address mapping assumption

uring an invalid master window translation. This patch updates the vme_tsi148 driver to first convert the address contained in the PCI bus resource into a PCI bus address before using it. [asierra: account for pcibios_resource_to_bus() prototype change] Signed-off-by: Joe Schultz Signed-off-by:

[PATCH 3/3] vme_tsi148: Utilize to_pci_dev() macro

Save some characters by using to_pci_dev() instead of container_of(). Signed-off-by: Aaron Sierra --- drivers/vme/bridges/vme_tsi148.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index

Re: [PATCH 1/3] vme_tsi148: Fix PCI base calculation for slave window

- Original Message - > From: "Dan Carpenter" > Sent: Thursday, April 3, 2014 1:05:03 PM > > On Thu, Apr 03, 2014 at 12:42:17PM -0500, Aaron Sierra wrote: > > From: Joe Schultz > > > > This patch corrects a failure to dereference a pointer in &

[PATCH 2/3 v2] vme_tsi148: Fix PCI address mapping assumption

uring an invalid master window translation. This patch updates the vme_tsi148 driver to first convert the address contained in the PCI bus resource into a PCI bus address before using it. [asierra: account for pcibios_resource_to_bus() prototype change] Signed-off-by: Joe Schultz Signed-off-by:

[PATCH 1/3 v2] vme_tsi148: Fix typo in tsi148_slave_get()

integer of different size [asierra: commit title/log rewording] Signed-off-by: Joe Schultz Signed-off-by: Aaron Sierra --- drivers/vme/bridges/vme_tsi148.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_ts

[PATCH 3/3 v2] vme_tsi148: Utilize to_pci_dev() macro

Save some characters by using to_pci_dev() instead of container_of(). Signed-off-by: Aaron Sierra --- drivers/vme/bridges/vme_tsi148.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c index

[PATCH] vme: trivial spelling and capitalization fixes

Fix a typo in the spurious interrupt warning and consistently capitalize VME, PCI, and DMA acronyms. Signed-off-by: Aaron Sierra --- drivers/vme/vme.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 72924b0..537b209

[PATCH] vme: change LM callback argument to void pointer

. Signed-off-by: Aaron Sierra --- drivers/vme/bridges/vme_ca91cx42.c | 6 -- drivers/vme/bridges/vme_ca91cx42.h | 3 ++- drivers/vme/bridges/vme_tsi148.c | 5 +++-- drivers/vme/bridges/vme_tsi148.h | 3 ++- drivers/vme/vme.c | 4 ++-- drivers/vme/vme_bridge.h | 3

[PATCH] vme: add vme_init_bridge for common bridge init

priv->bridge); Signed-off-by: Aaron Sierra --- drivers/vme/bridges/vme_ca91cx42.c | 9 + drivers/vme/bridges/vme_tsi148.c | 9 + drivers/vme/vme.c | 14 ++ drivers/vme/vme_bridge.h | 1 + 4 files changed, 17 insertions(+), 16 de

[PATCH v2] vme: change LM callback argument to void pointer

compiled. Signed-off-by: Aaron Sierra --- v2 - change new argument name from cookie to data - add data cleanup to vme_tsi148.c - update VME API documentation with new prototype - fix checkpatch.pl style warning in vme_bridge.h Documentation/vme_api.txt | 4 ++-- drivers/vme

Re: [PATCH v2] vme: change LM callback argument to void pointer

- Original Message - > From: "Dan Carpenter" > Sent: Saturday, April 30, 2016 5:16:19 AM > > On Fri, Apr 29, 2016 at 04:41:02PM -0500, Aaron Sierra wrote: > > There appear to be no in-kernel callers of vme_lm_attach (or > > vme_lme_request for that ma

Re: [PATCH v2] vme: change LM callback argument to void pointer

an Carpenter wrote: > > > On Fri, Apr 29, 2016 at 04:41:02PM -0500, Aaron Sierra wrote: > > >> There appear to be no in-kernel callers of vme_lm_attach (or > > >> vme_lme_request for that matter), so this change only affects the VME > > >> subsystem and b

staging: vme_user: accept bus_num of zero

epted during probe. This patch changes the default value of bus_num to -1, so that any number in the range of 0 to VME_USER_BUS_MAX will be accepted during probe. Signed-off-by: Aaron Sierra --- drivers/staging/vme/devices/vme_user.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-)

[PATCH 3/3] staging: vme_user: alloc buffer when setting slave

r Cc: Dmitry Kalinkin Signed-off-by: Aaron Sierra --- drivers/staging/vme/devices/vme_user.c | 48 +++--- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index c68e2b8..a0

[PATCH 2/3] staging: vme_user: look up image once in ioctl

Assign a pointer to the image descriptor once at the beginning of the ioctl to help keep code concise. Signed-off-by: Aaron Sierra --- drivers/staging/vme/devices/vme_user.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c

[PATCH 1/3] staging: vme_user: return retval in vme_user_ioctl

Update each case to set retval and return that value at the end of the function. This also replaces most case statement returns with breaks and collapses some whitespace. Signed-off-by: Aaron Sierra --- drivers/staging/vme/devices/vme_user.c | 22 ++ 1 file changed, 10

Re: [PATCH 1/3] staging: vme_user: return retval in vme_user_ioctl

- Original Message - > From: "Martyn Welch" > Subject: Re: [PATCH 1/3] staging: vme_user: return retval in vme_user_ioctl > On Fri, Sep 02, 2016 at 04:16:48PM -0500, Aaron Sierra wrote: >> Update each case to set retval and return that value at the end of t

Re: [PATCH 2/3] staging: vme_user: look up image once in ioctl

- Original Message - > From: "Martyn Welch" > Sent: Thursday, September 8, 2016 2:24:11 PM > On Fri, Sep 02, 2016 at 04:16:55PM -0500, Aaron Sierra wrote: >> Assign a pointer to the image descriptor once at the beginning of >> the ioctl to help keep code c

Re: [PATCH 3/3] staging: vme_user: alloc buffer when setting slave

- Original Message - > From: "Martyn Welch" > To: "Aaron Sierra" > Cc: "Manohar Vanga" , "Greg Kroah-Hartman" > , "devel" > , "Egor Uleyskiy" , > "Dmitry Kalinkin" > Sent: Thursday, September

Re: [PATCH 3/3] staging: vme_user: alloc buffer when setting slave

- Original Message - > From: "Martyn Welch" > Sent: Friday, September 9, 2016 3:03:57 PM > On Fri, Sep 09, 2016 at 02:41:43PM -0500, Aaron Sierra wrote: >> - Original Message - >> > From: "Martyn Welch" >> > To: "Aar

Re: staging: vme_user: accept bus_num of zero

- Original Message - > From: "Martyn Welch" > Sent: Thursday, September 8, 2016 2:17:35 PM > On Fri, Sep 02, 2016 at 03:59:45PM -0500, Aaron Sierra wrote: >> The driver's bus_num parameter is used to select a VME bus during probe. >> This parameter i

[PATCH 0/3] vme_user: Resolving in-kernel and mixed-environment issues

[PATCH 1/3] vme_user: Ensure driver compiles after VME bridges [PATCH 2/3] vme_user: Update API to work in mixed environments [PATCH 3/3] vme_user: Remove superfluous bus module parameter Patches #1 and #2 above were needed to use vme_user driver with a Tsi148 bridge with both drivers compiled int

[PATCH 3/3] vme_user: Remove superfluous bus module parameter

: Aaron Sierra --- drivers/staging/vme/devices/vme_user.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e69f0cd..afe518f3 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b

[PATCH 1/3] vme_user: Ensure driver compiles after VME bridges

general VME Makefile after all VME buses are built. Signed-off-by: Aaron Sierra --- drivers/staging/Makefile |1 - drivers/vme/Makefile |1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile index 415772e..8082bdb 100644 --- a

[PATCH 2/3] vme_user: Update API to work in mixed environments

-off-by: Aaron Sierra --- drivers/staging/vme/devices/vme_user.c |1 + drivers/staging/vme/devices/vme_user.h | 26 +- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index

Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges

te enough? Do you feel that it doesn't resolve any issue? -Aaron > > On 31/10/13 23:47, Aaron Sierra wrote: > > If VME bridge and vme_user modules are compiled into the kernel, then > > vme_user will attempt to register itself before any VME buses have been > > probed. This

Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges

- Original Message - > From: "Martyn Welch" > Subject: Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges > > On 05/11/13 17:53, Aaron Sierra wrote: > > Martyn, > > Can you please elaborate on why you feel it is not a fix? For instance,

Re: [PATCH 3/3] vme_user: Remove superfluous bus module parameter

> From: "Martyn Welch" > > This patch removes the bus parameter since its primary function in > > practice is to prevent the driver from registering itself with the VME > > subsystem entirely unless some (any) value is passed via the parameter. > > > > The bus module parameter seems to be provide

Re: [PATCH 2/3] vme_user: Update API to work in mixed environments

- Original Message - > From: "Greg Kroah-Hartman" > Sent: Tuesday, December 3, 2013 1:07:51 PM > [snip] > > > > diff --git a/drivers/staging/vme/devices/vme_user.h > > b/drivers/staging/vme/devices/vme_user.h > > index 7d24cd6..6726a42 100644 > > --- a/drivers/staging/vme/devices/vme_

Re: [PATCH 1/3] vme_user: Ensure driver compiles after VME bridges

- Original Message - > From: "Martyn Welch" > Sent: Thursday, November 7, 2013 7:00:35 AM > > On 05/11/13 20:58, Aaron Sierra wrote: > > - Original Message - > >> From: "Martyn Welch" > >> Subject: Re: [PATCH 1/3]

[PATCH] vme: Convert VME core to register as a subsystem

are compiled. Tested-by: Aaron Sierra Signed-off-by: Martyn Welch --- drivers/vme/Kconfig |2 +- drivers/vme/vme.c |6 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/vme/Kconfig b/drivers/vme/Kconfig index c5c2246..a6a6f95 100644 --- a/drivers/vme/Kconfig

[PATCH v2] vme_user: Update API to work in mixed environments

-off-by: Aaron Sierra --- drivers/staging/vme/devices/vme_user.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme/devices/vme_user.h index 280ccc7..c3b4964 100644 --- a/drivers/staging/vme

Re: [PATCH v2] vme_user: Update API to work in mixed environments

- Original Message - > From: "Greg KH" > To: "Aaron Sierra" > Cc: "martyn welch" , de...@driverdev.osuosl.org, > "manohar vanga" , "dan > carpenter" > Sent: Tuesday, December 17, 2013 7:06:06 PM > Subject: Re: [P

[PATCH 1/2] vme_user: Enable compat_ioctl for mixed environment

Now that the VME userspace API structures compile to a consistent size in mixed environments (32-bit userspace and 64-bit kernel), enable the .compat_ioctl to allow ioctls to execute in this environment. Signed-off-by: Aaron Sierra --- drivers/staging/vme/devices/vme_user.c |1 + 1 file

[PATCH 2/2] vme_user: Use __u64 and __u32 in userspace structs

Signed-off-by: Aaron Sierra Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vme/devices/vme_user.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.h b/drivers/staging/vme/devices/vme_user.h index c3b4964

[PATCH] vme_tsi148: Allow setting VMEbus Global Timeout

-bits instead of 3-bits. Signed-off-by: Aaron Sierra --- drivers/vme/bridges/vme_tsi148.c | 12 drivers/vme/bridges/vme_tsi148.h | 14 -- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_t

Re: [PATCH] vme_tsi148: Allow setting VMEbus Global Timeout

- Original Message - > From: "Martyn Welch" > Sent: Monday, June 16, 2014 4:56:16 AM > Subject: Re: [PATCH] vme_tsi148: Allow setting VMEbus Global Timeout > > On 06/06/14 20:41, Aaron Sierra wrote: > > Add a "gto" parameter to this driver so tha